Re: [FFmpeg-devel] [PATCH v1 3/3] fate/jpeg2000: add JPEG 2000 tests using ITU/ISO conformance materials

[Pierre-Anthony Lemieux <pal@sandflow.com>]

On Sun, Apr 2, 2023 at 12:32 PM Michael Niedermayer
<michael@niedermayer.cc> wrote:
>
> On Sun, Apr 02, 2023 at 09:27:42PM +0200, Michael Niedermayer wrote:
> > On Fri, Mar 31, 2023 at 08:29:41AM -0700, pal@sandflow.com wrote:
> > > From: Pierre-Anthony Lemieux <pal@palemieux.com>
> > >
> > > Adds JPEG 2000 decoder tests using materials from the conformance suite specified in
> > > Rec. ITU-T T.803 | ISO/IEC 15444-4.
> > >
> > > The test materials are available at https://gitlab.com/wg1/htj2k-codestreams
> > > ---
> > >  tests/Makefile                           |  1 +
> > >  tests/fate/jpeg2000.mak                  | 64 ++++++++++++++++++++++++
> > >  tests/ref/fate/jpeg2000dec-ds0_ht_01_b11 |  6 +++
> > >  tests/ref/fate/jpeg2000dec-p0_01         |  6 +++
> > >  tests/ref/fate/jpeg2000dec-p0_02         |  6 +++
> > >  tests/ref/fate/jpeg2000dec-p0_03         |  6 +++
> > >  tests/ref/fate/jpeg2000dec-p0_04         |  6 +++
> > >  tests/ref/fate/jpeg2000dec-p0_05         |  6 +++
> > >  tests/ref/fate/jpeg2000dec-p0_07         |  6 +++
> > >  tests/ref/fate/jpeg2000dec-p0_08         |  6 +++
> > >  tests/ref/fate/jpeg2000dec-p0_09         |  6 +++
> > >  tests/ref/fate/jpeg2000dec-p0_11         |  6 +++
> > >  tests/ref/fate/jpeg2000dec-p0_12         |  6 +++
> > >  tests/ref/fate/jpeg2000dec-p0_14         |  6 +++
> > >  tests/ref/fate/jpeg2000dec-p0_15         |  6 +++
> > >  tests/ref/fate/jpeg2000dec-p0_16         |  6 +++
> > >  16 files changed, 149 insertions(+)
> > >  create mode 100644 tests/fate/jpeg2000.mak
> > >  create mode 100644 tests/ref/fate/jpeg2000dec-ds0_ht_01_b11
> > >  create mode 100644 tests/ref/fate/jpeg2000dec-p0_01
> > >  create mode 100644 tests/ref/fate/jpeg2000dec-p0_02
> > >  create mode 100644 tests/ref/fate/jpeg2000dec-p0_03
> > >  create mode 100644 tests/ref/fate/jpeg2000dec-p0_04
> > >  create mode 100644 tests/ref/fate/jpeg2000dec-p0_05
> > >  create mode 100644 tests/ref/fate/jpeg2000dec-p0_07
> > >  create mode 100644 tests/ref/fate/jpeg2000dec-p0_08
> > >  create mode 100644 tests/ref/fate/jpeg2000dec-p0_09
> > >  create mode 100644 tests/ref/fate/jpeg2000dec-p0_11
> > >  create mode 100644 tests/ref/fate/jpeg2000dec-p0_12
> > >  create mode 100644 tests/ref/fate/jpeg2000dec-p0_14
> > >  create mode 100644 tests/ref/fate/jpeg2000dec-p0_15
> > >  create mode 100644 tests/ref/fate/jpeg2000dec-p0_16
> >
> > fails on x86_32

Thanks. I have added checking for compatibility with 32-bit and
big-endian architectures to my checklist.

I have also pinged @Caleb Etemesi .


> >
> > --- src/tests/ref/fate/jpeg2000dec-ds0_ht_01_b11      2023-04-02 20:22:07.533882127 +0200
> > +++ tests/data/fate/jpeg2000dec-ds0_ht_01_b11 2023-04-02 21:22:52.570695888 +0200
> > @@ -3,4 +3,4 @@
> >  #codec_id 0: rawvideo
> >  #dimensions 0: 128x128
> >  #sar 0: 0/1
> > -0,          0,          0,        1,    16384, 0x44426324
> > +0,          0,          0,        1,    16384, 0x69cdc6ea
> > Test jpeg2000dec-ds0_ht_01_b11 failed. Look at tests/data/fate/jpeg2000dec-ds0_ht_01_b11.err for details.
> > src/tests/Makefile:307: recipe for target 'fate-jpeg2000dec-ds0_ht_01_b11' failed
> > make: *** [fate-jpeg2000dec-ds0_ht_01_b11] Error 1
> > make: Target 'fate-jpeg2000dec' not remade because of errors.
>
> and these fail on mips (big endian)
>
> TEST    jpeg2000dec-p0_15
> TEST    jpeg2000dec-p0_16
> TEST    jpeg2000dec-ds0_ht_01_b11
> --- tests/ref/fate/jpeg2000dec-ds0_ht_01_b11    2023-04-02 20:22:07.533882127 +0200
> +++ tests/data/fate/jpeg2000dec-ds0_ht_01_b11   2023-04-02 21:28:50.179134974 +0200
> @@ -3,4 +3,4 @@
>  #codec_id 0: rawvideo
>  #dimensions 0: 128x128
>  #sar 0: 0/1
> -0,          0,          0,        1,    16384, 0x44426324
> +0,          0,          0,        1,    16384, 0x69cdc6ea
> Test jpeg2000dec-ds0_ht_01_b11 failed. Look at tests/data/fate/jpeg2000dec-ds0_ht_01_b11.err for details.
> tests/Makefile:307: recipe for target 'fate-jpeg2000dec-ds0_ht_01_b11' failed
> make: *** [fate-jpeg2000dec-ds0_ht_01_b11] Error 1
> --- tests/ref/fate/jpeg2000dec-p0_08    2023-04-02 20:22:07.533882127 +0200
> +++ tests/data/fate/jpeg2000dec-p0_08   2023-04-02 21:28:52.263158866 +0200
> @@ -3,4 +3,4 @@
>  #codec_id 0: rawvideo
>  #dimensions 0: 257x1536
>  #sar 0: 0/1
> -0,          0,          0,        1,  2368512, 0xece49ff9
> +0,          0,          0,        1,  2368512, 0xc6bf9ff9
> Test jpeg2000dec-p0_08 failed. Look at tests/data/fate/jpeg2000dec-p0_08.err for details.
> tests/Makefile:307: recipe for target 'fate-jpeg2000dec-p0_08' failed
> make: *** [fate-jpeg2000dec-p0_08] Error 1
> --- tests/ref/fate/jpeg2000dec-p0_07    2023-04-02 20:22:07.533882127 +0200
> +++ tests/data/fate/jpeg2000dec-p0_07   2023-04-02 21:29:06.179317958 +0200
> @@ -3,4 +3,4 @@
>  #codec_id 0: rawvideo
>  #dimensions 0: 2048x2048
>  #sar 0: 0/1
> -0,          0,          0,        1, 25165824, 0x9685aad6
> +0,          0,          0,        1, 25165824, 0x4860aad6
> Test jpeg2000dec-p0_07 failed. Look at tests/data/fate/jpeg2000dec-p0_07.err for details.
> tests/Makefile:307: recipe for target 'fate-jpeg2000dec-p0_07' failed
> make: *** [fate-jpeg2000dec-p0_07] Error 1
> make: Target 'fate-jpeg2000dec' not remade because of errors.
>
>
> [...]
>
> --
> Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB
>
> The misfortune of the wise is better than the prosperity of the fool.
> -- Epicurus
> _______________________________________________
> ffmpeg-devel mailing list
> ffmpeg-devel@ffmpeg.org
> https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
>
> To unsubscribe, visit link above, or email
> ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".
_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel

To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".