From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTP id 44F3544204 for ; Sun, 2 Oct 2022 16:44:03 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id 7FDE568BBA4; Sun, 2 Oct 2022 19:44:02 +0300 (EEST) Received: from mail-pj1-f49.google.com (mail-pj1-f49.google.com [209.85.216.49]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id D56B268BA9B for ; Sun, 2 Oct 2022 19:43:55 +0300 (EEST) Received: by mail-pj1-f49.google.com with SMTP id 70so8067619pjo.4 for ; Sun, 02 Oct 2022 09:43:55 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=sandflow-com.20210112.gappssmtp.com; s=20210112; h=to:subject:message-id:date:from:in-reply-to:references:mime-version :from:to:cc:subject:date; bh=CaDn71d96AkpP8+VrCUY4JYEqB6ekrhfcQ1R9ms7rKQ=; b=AcHHT7iGMtjk0gg+ZtodcH0pWRCiysH21sKM84ug9WcIP5T5b4xskWjH4IG78fJJZV UW0urELsW173jWEzwRSfibn6WpP+z1l5Hw2l49+kMmdf8SdFQyjusPLaajkrMKj1+kGQ 8j9miM9QG+Uw5YWm6bPaHcV+N8WyDrqLzCg6PRCK4d+hDPWq3Ln1c+QK5eWoPmxxfbCf odSUZCouZmDZJ8jluVTFwLPo0h/mL3S9pTubDrVR0XVex0+sokBAGfgViB4tLSp5oWHP 9NDEtaEGxvMPqo0Lt/9dIpIIazmpi5T5j+mPitE7TwXIovbSRRHL+17u0OYguk3YappJ T6oA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=to:subject:message-id:date:from:in-reply-to:references:mime-version :x-gm-message-state:from:to:cc:subject:date; bh=CaDn71d96AkpP8+VrCUY4JYEqB6ekrhfcQ1R9ms7rKQ=; b=0c/Xsu4kFjEcvFOgv8I5PWyQltFT9ws7HwnYiZ1+CXU25eyeE42diMKW+pF0vNKJWY spImebvTTbDZsU5fBbEViRy/vXen0cg0qlsusVkLlchYRXtw9yuDR7BSETYZ35RgSvvB yiweOg/SXSZE7yWQnEZjACGCPkyub76NoDzqIP3tCvsmYha9nnnQLogzboEVP4YeLdHn XD1eST4UgqnGsY73uIJFsHMG1z5nHGBns2W9Y+c+gEWfmIBJ8QzM9SCiNxsHBkhZ1Y2q a9JdsnE+JEfTX+8oa6NGHOAIPJ3//O8v4wVLMaqE2EaaGjyTVi5DEL5cdjXBhhTe4zSx KAdA== X-Gm-Message-State: ACrzQf2SmOLllN/09SpLouBYn5KPxqZrQSnMdGGvrkOqkonYqXXF47hk cIQYiLpYNggJF9RfizrCJ0BAjWHS9/n8kw== X-Google-Smtp-Source: AMsMyM7bmuk2zDaHszFmqllk91L6cmRawJQ/GtSqNFCx0En6HUAI0ViRD6iK4xaiOEXUn6em3SSCfw== X-Received: by 2002:a17:902:d70a:b0:178:5d52:9e41 with SMTP id w10-20020a170902d70a00b001785d529e41mr18135854ply.0.1664729033782; Sun, 02 Oct 2022 09:43:53 -0700 (PDT) Received: from mail-pl1-f175.google.com (mail-pl1-f175.google.com. [209.85.214.175]) by smtp.gmail.com with ESMTPSA id 21-20020a170902c11500b0017eea4a3979sm1216472pli.154.2022.10.02.09.43.53 for (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Sun, 02 Oct 2022 09:43:53 -0700 (PDT) Received: by mail-pl1-f175.google.com with SMTP id f23so7848318plr.6 for ; Sun, 02 Oct 2022 09:43:53 -0700 (PDT) X-Received: by 2002:a17:902:e5c3:b0:178:192c:6b3b with SMTP id u3-20020a170902e5c300b00178192c6b3bmr18767581plf.92.1664729032873; Sun, 02 Oct 2022 09:43:52 -0700 (PDT) MIME-Version: 1.0 References: <20220823051050.3515-1-pal@sandflow.com> <275e4cfb-7d05-542a-3275-e7e75bd14a7a@zanevaniperen.com> In-Reply-To: <275e4cfb-7d05-542a-3275-e7e75bd14a7a@zanevaniperen.com> From: Pierre-Anthony Lemieux Date: Sun, 2 Oct 2022 09:43:40 -0700 X-Gmail-Original-Message-ID: Message-ID: To: FFmpeg development discussions and patches Subject: Re: [FFmpeg-devel] [PATCH v1 1/2] avformat/imfdec: use CPL start timecode if available X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: On Tue, Sep 27, 2022 at 5:40 AM Zane van Iperen wrote: > > Looks mostly ok from a cursory glance, just one minor nit. > > On 23/8/22 15:10, pal@sandflow.com wrote: > > > > +static int ff_imf_xml_read_boolean(xmlNodePtr element, int *value) > > +{ > > + xmlChar *element_text = NULL; > > + int ret = 0; > > + > > + element_text = xmlNodeListGetString(element->doc, element->xmlChildrenNode, 1); > > + > > No need for "element_text = NULL". Addressed at v2. > > > > > +static int digit_to_int(char digit) > > +{ > > + if (digit >= '0' && digit <= '9') > > + return digit - '0'; > > + return -1; > > +} > > + > > I feel like there should be a av_* helper for this, but apparently there isn't. > Maybe it's worth adding one in a future patch? av_isdigit() is in avstring.h, so > perhaps there? Ok. This probably requires more planning since the idioms `x >= '0' && x <= '9'` and `x >= 'a' && x <= 'z'` are used in many places. > _______________________________________________ > ffmpeg-devel mailing list > ffmpeg-devel@ffmpeg.org > https://ffmpeg.org/mailman/listinfo/ffmpeg-devel > > To unsubscribe, visit link above, or email > ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe". _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".