From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTP id A82AE42EDA for ; Tue, 9 May 2023 14:29:13 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id 9E04068C218; Tue, 9 May 2023 17:29:10 +0300 (EEST) Received: from mail-pj1-f47.google.com (mail-pj1-f47.google.com [209.85.216.47]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id 2D9EF68BA9C for ; Tue, 9 May 2023 17:29:04 +0300 (EEST) Received: by mail-pj1-f47.google.com with SMTP id 98e67ed59e1d1-24e2bbec3d5so4295397a91.3 for ; Tue, 09 May 2023 07:29:04 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=sandflow-com.20221208.gappssmtp.com; s=20221208; t=1683642541; x=1686234541; h=to:subject:message-id:date:from:in-reply-to:references:mime-version :from:to:cc:subject:date:message-id:reply-to; bh=cPz9Jg6g6dAoxquHLPT7SbSYkAYPc/5Q2vns+bOYzV0=; b=lxatm/nM0f6P9th4v93VIn4tWEtoeR0r5b5rxHePf/fLW6AdY4LFK6nflyTkBBsjW2 pCwuOgHtV32XRSO+jit8xNWintNqbAXuV5V0Hff0aGh3AZ7h7y46OMZsmkt4ynMb8wjK ONsg6K8TkXuGcXyhaGLdzBs6/8wwJ0CIovPU+eLeArlX6HbBKQRjI00d2R66cACzriuv Nx00S/x+haXmq96FZhJ/7j4kej8/g700oTIvtMd40L4oPS7hUWHn9YQSVVR5y1yZlF9w Z8DdWGCthZA4fUPEkrAwtYCHOEdEl3bKyIEm2AKP2z3f5ysFNvJoubpIT4JIXUl/WgxE /OdA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1683642541; x=1686234541; h=to:subject:message-id:date:from:in-reply-to:references:mime-version :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=cPz9Jg6g6dAoxquHLPT7SbSYkAYPc/5Q2vns+bOYzV0=; b=Dltmtg62K25+jWt/HiaDvc0A5G3PO0afubu6g6sLUG5WQRsEmGgYPzK1uMUBpV6HcT eh2tHgNrKVE5Pl2ILKav9JQEK5UeS5hG1VJaNmB/4cz4gxgKRcqfRBJPy+rqCVc8Rx18 QngYQUitMyKmH58oOOWL+kiodQwFeAM8Tfc7n5hoDnDKCW3T6YAKdjf8BR7QNpsMLb/g E9gm+Wjm05nhnNesuVKI2S9aIdbwTh5XvX5lY3GM8dWjCZiPmoajHZ2VQLt+BITgnuAd OggLUrIoPHHRvF6oMOXdlUCebYQX3lMrRR4JzwIaRd2FLsifg1P/gyiLHC59aVm4D8gj HsHw== X-Gm-Message-State: AC+VfDwZZ8zULhg1wJzzp13HRi8xRMtBZEjM3pSxU/JhLTORAuR3pAe6 c0HWAHI4BkVl+7/a//NVR/rHC/zL3yQ2XRXnlGI= X-Google-Smtp-Source: ACHHUZ6yKjcl9m5n41jVDxcKUoKxZljSARobksL3k1FMvFRK42n+WnrkV942vFsK1rnPuYCdIBg08w== X-Received: by 2002:a17:90b:fd8:b0:24e:4231:ec6b with SMTP id gd24-20020a17090b0fd800b0024e4231ec6bmr14487071pjb.21.1683642541212; Tue, 09 May 2023 07:29:01 -0700 (PDT) Received: from mail-pg1-f174.google.com (mail-pg1-f174.google.com. [209.85.215.174]) by smtp.gmail.com with ESMTPSA id lr8-20020a17090b4b8800b0024752ff8061sm20068390pjb.12.2023.05.09.07.29.00 for (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 09 May 2023 07:29:00 -0700 (PDT) Received: by mail-pg1-f174.google.com with SMTP id 41be03b00d2f7-51f6461af24so4200468a12.2 for ; Tue, 09 May 2023 07:29:00 -0700 (PDT) X-Received: by 2002:a17:90b:3504:b0:24e:4b02:4f0 with SMTP id ls4-20020a17090b350400b0024e4b0204f0mr14281839pjb.6.1683642539887; Tue, 09 May 2023 07:28:59 -0700 (PDT) MIME-Version: 1.0 References: <20230331214701.GC1164690@pb2> <7a09e1d3-8d2e-7318-dab0-776247171251@ektacom.com> <20230403151448.GT1164690@pb2> <64da988c-0269-6d65-d8a6-b9c0113d0480@ektacom.com> <9ce39ded-b34f-702d-6ee6-514b9d794fb0@ektacom.com> In-Reply-To: <9ce39ded-b34f-702d-6ee6-514b9d794fb0@ektacom.com> From: Pierre-Anthony Lemieux Date: Tue, 9 May 2023 07:28:47 -0700 X-Gmail-Original-Message-ID: Message-ID: To: FFmpeg development discussions and patches Subject: Re: [FFmpeg-devel] [PATCH] MXF - Add jpeg2000 subdescriptor - Sponsored by INA X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: Couple of follow-up comments. - "mxf_parse_jpeg2000_frame" could be moved to one of jpeg2000 source files, to keep J2K parsing code together. Maybe there is a way to reuse jpeg2000_read_main_headers() at jpeg2000dec.c? - when defining the J2K descriptor items, please refer to the symbol name from the SMPTE registers, it make following/debugging the code a lot easier: { 0x8405, {0x06,0x0e,0x2b,0x34,0x01,0x01,0x01,0x0a,0x04,0x01,0x06,0x03,0x05,0x00,0x00,0x00}}, /* Vertical offset from the origin of the reference grid to the left side of the image area */ becomes { 0x8405, {0x06,0x0e,0x2b,0x34,0x01,0x01,0x01,0x0a,0x04,0x01,0x06,0x03,0x05,0x00,0x00,0x00}}, /* YOsiz: vertical offset from the origin of the reference grid to the left side of the image area */ _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".