From: Pierre-Anthony Lemieux <pal@sandflow.com> To: FFmpeg development discussions and patches <ffmpeg-devel@ffmpeg.org> Subject: Re: [FFmpeg-devel] [PATCH 1/3] avformat/mxfdec: SMPTE RDD 48:2018 support Date: Fri, 29 Jul 2022 16:24:35 +0200 Message-ID: <CAF_7JxBvcPiL7X+eh53uVTL9Pu98sePBR5VaaL5hJsw3QiOKxg@mail.gmail.com> (raw) In-Reply-To: <e1ece03e60bac5ad443304f8c0e9eaba03904568.camel@acc.umu.se> On Fri, Jul 29, 2022 at 4:19 PM Tomas Härdin <tjoppen@acc.umu.se> wrote: > > fre 2022-07-29 klockan 14:14 +0200 skrev Pierre-Anthony Lemieux: > > On Fri, Jul 29, 2022 at 6:15 AM Tomas Härdin <tjoppen@acc.umu.se> > > wrote: > > > > > > fre 2022-07-29 klockan 01:18 +0200 skrev Michael Niedermayer: > > > > On Tue, Jul 19, 2022 at 03:48:59PM +0200, Tomas Härdin wrote: > > > > > mån 2022-07-11 klockan 23:44 +0200 skrev Michael Niedermayer: > > > > > > > > > > > > + { { > > > > > > 0x06,0x0e,0x2b,0x34,0x04,0x01,0x01,0x0D,0x04,0x01,0x02,0x02,0 > > > > > > x03, > > > > > > 0x09 > > > > > > ,0x01,0x00 }, 15, AV_CODEC_ID_FFV1 }, /*FFV1 V0 */ > > > > > > + { { > > > > > > 0x06,0x0e,0x2b,0x34,0x04,0x01,0x01,0x0D,0x04,0x01,0x02,0x02,0 > > > > > > x03, > > > > > > 0x09 > > > > > > ,0x02,0x00 }, 15, AV_CODEC_ID_FFV1 }, /*FFV1 V1 */ > > > > > > + { { > > > > > > > > > > Double-checked, these are correct > > > > I recommend the draft SMPTE metadata registry at the following as the > > reference for ULs: > > > > https://registry.smpte-ra.org/apps/pages/ > > > > The registry is kept up-to-date, machine readable and free to access. > > Neato. I actually have a tool for parsing ULs that I call wtful. For > now it parses relevant RP spreadsheets, but it's kinda shitty. Maybe I > can improve and publish it. The canonical format for the SMPTE registers is XML. The data (and corresponding XSDs) can also be found at: https://registry.smpte-ra.org/apps/pages/draft/ ("draft" registries are 99% correct. "published" are 99.9% correct but lag by about 6 months.) The following are Java bindings for folks that are into that :) https://github.com/sandflow/regxmllib/tree/master/src/main/java/com/sandflow/smpte/register > > > > > > > > > > > > > > + { { > > > > > > 0x06,0x0e,0x2b,0x34,0x02,0x53,0x01,0x01,0x0d,0x01,0x01,0x01,0 > > > > > > x01, > > > > > > 0x01 > > > > > > ,0x81,0x03 }, mxf_read_ffv1_sub_descriptor, > > > > > > sizeof(MXFFFV1SubDescriptor), FFV1SubDescriptor }, > > > > > > > > > > The spec says 0x7F not 0x53. 0x53 is used in groups with 2-byte > > > > > tags > > > > > > > > If i put 0x7F with no other change there, it will break demuxing > > > > the > > > > files i have > > > > I guess i must have copied this from the files without noticing > > > > it > > > > mismatches > > > > the spec > > > > > > Yeah I would expect it to break with 0x7F. Perhaps this will change > > > when the spec becomes official. If you have contact with the people > > > involved in this then I suggest asking them about this. It could > > > also > > > be a typo in the spec. > > > > Byte 6 of Group ULs is set by convention to the wildcard value 0x7F > > to > > indicate that the encoding of the Group is not limited to 0x53 (local > > set with 2-byte local tags and length field). See the following: > > > > > > https://registry.smpte-ra.org/view/draft/docs/Submissions%20Overview/Document-Editors-Information--Style-Guide/#groups-ul > > > > MXF restricts header metadata to local sets with 2-byte local tags > > and > > 2-byte or BER lengths, so byte 6 can be 0x13 or 0x53. > > Alright, then it's fine. Maybe at some point we'll need to implement > BER lengths in local sets, but not now > > /Tomas > > _______________________________________________ > ffmpeg-devel mailing list > ffmpeg-devel@ffmpeg.org > https://ffmpeg.org/mailman/listinfo/ffmpeg-devel > > To unsubscribe, visit link above, or email > ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe". _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".
prev parent reply other threads:[~2022-07-29 14:25 UTC|newest] Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top 2022-07-11 21:44 Michael Niedermayer 2022-07-11 21:44 ` [FFmpeg-devel] [PATCH 2/3] avformat/mpc8: Check and propagate more errors Michael Niedermayer 2022-07-21 17:38 ` Michael Niedermayer 2022-07-11 21:44 ` [FFmpeg-devel] [PATCH 3/3] tools/target_dec_fuzzer: Adjust threshold for ANM Michael Niedermayer 2022-07-12 17:57 ` Michael Niedermayer 2022-07-13 13:58 ` [FFmpeg-devel] [PATCH 1/3] avformat/mxfdec: SMPTE RDD 48:2018 support Dave Rice 2022-07-18 18:35 ` Tomas Härdin 2022-07-19 11:54 ` Michael Niedermayer 2022-07-19 13:48 ` Tomas Härdin 2022-07-28 23:18 ` Michael Niedermayer 2022-07-29 4:15 ` Tomas Härdin 2022-07-29 12:14 ` Pierre-Anthony Lemieux 2022-07-29 14:19 ` Tomas Härdin 2022-07-29 14:24 ` Pierre-Anthony Lemieux [this message]
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=CAF_7JxBvcPiL7X+eh53uVTL9Pu98sePBR5VaaL5hJsw3QiOKxg@mail.gmail.com \ --to=pal@sandflow.com \ --cc=ffmpeg-devel@ffmpeg.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: link
Git Inbox Mirror of the ffmpeg-devel mailing list - see https://ffmpeg.org/mailman/listinfo/ffmpeg-devel This inbox may be cloned and mirrored by anyone: git clone --mirror https://master.gitmailbox.com/ffmpegdev/0 ffmpegdev/git/0.git # If you have public-inbox 1.1+ installed, you may # initialize and index your mirror using the following commands: public-inbox-init -V2 ffmpegdev ffmpegdev/ https://master.gitmailbox.com/ffmpegdev \ ffmpegdev@gitmailbox.com public-inbox-index ffmpegdev Example config snippet for mirrors. AGPL code for this site: git clone https://public-inbox.org/public-inbox.git