From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTP id E56ED44537 for ; Wed, 14 Sep 2022 17:22:02 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id C1CF068BB4C; Wed, 14 Sep 2022 20:22:00 +0300 (EEST) Received: from mail-pf1-f170.google.com (mail-pf1-f170.google.com [209.85.210.170]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id F236A68B69E for ; Wed, 14 Sep 2022 20:21:53 +0300 (EEST) Received: by mail-pf1-f170.google.com with SMTP id 9so4491021pfz.12 for ; Wed, 14 Sep 2022 10:21:53 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=sandflow-com.20210112.gappssmtp.com; s=20210112; h=to:subject:message-id:date:from:in-reply-to:references:mime-version :from:to:cc:subject:date; bh=o55+mA4bdNIi3pKoB3WzMiYanuKQmm7K9z3+Qj0nvpA=; b=C0DPKY6DymNaICxDj5iN0iBiFYkJSeBDc7PwBsKY+fJBNmi8yuekm8u5PoOIyZ6X/0 P70SaVcwcY86dGs8iYApQBaEsJuLH7RhOiSX7z+QzGbQXdwEW2kFIk0iWlx0epzlz+p1 y3489qIO7tx5fmbBGcl1RjhD6e/Ns4+oWh4HYgh8vCbmXEHlZefM/duAUW/wSkcXtZkk em8qUulEU2h/p+K2p9fB6ZvtCzRiDng4W521FYsvpJZaftqBIb2mjPC32rmsQjC9rokj 2ytqTpVl4hJR57O54d//p0++8h8oiO3PRKZ776KVKvpBEe8kU8+soIC72V90+4tSZtlj z6aA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=to:subject:message-id:date:from:in-reply-to:references:mime-version :x-gm-message-state:from:to:cc:subject:date; bh=o55+mA4bdNIi3pKoB3WzMiYanuKQmm7K9z3+Qj0nvpA=; b=iLJqz9igd4aVZ2DiYZhnXWTANJG4kSkh/OtkhHYIi80phN3fmQbwGzeS7eAt+7vuC7 n1dXjqc3JLx0Azn9yCijqP/1GIeUFtqgMS5RoQ16oN2I/D8Leif6GhxXMY0b4FeQRVhX n0k6ibSjrvBTNh/X8xFc8izTASFbXNKZjnApPsJLV8SJs5hslHTk+BbKt1jLOF+Jttwb 9o+8ds961JXOvip3kyoygzR6TFgB4JFi3riN/M4EJ14TXRwuHRG8oQP9v1SGSWXflFrK cfuULbC/W2Rzt5WJmhM1QLKBGd1Z69uDi+owMuDJlrww9g8sD5FyZVOZrsNMH12XcTh2 GmOw== X-Gm-Message-State: ACgBeo0TmRySh6kvAlN4kLUnhT/lbo670z22yfVCTpvcvJuXZvCfPWy7 Bj/DH9K6GT9s8O/OGxJRKKpdqfWtY5aoWw== X-Google-Smtp-Source: AA6agR4HAQnbvuz5yw+bjyMZueqe9AJilhlu++TjnDzNiTpEZRr0ZaZafPNrMSqYT7F/4McTQA2YFg== X-Received: by 2002:a65:6854:0:b0:438:b1b5:8769 with SMTP id q20-20020a656854000000b00438b1b58769mr19864495pgt.472.1663176111800; Wed, 14 Sep 2022 10:21:51 -0700 (PDT) Received: from mail-pg1-f180.google.com (mail-pg1-f180.google.com. [209.85.215.180]) by smtp.gmail.com with ESMTPSA id t4-20020a17090a3e4400b001fb3522d53asm9491342pjm.34.2022.09.14.10.21.50 for (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 14 Sep 2022 10:21:51 -0700 (PDT) Received: by mail-pg1-f180.google.com with SMTP id i19so11645554pgi.1 for ; Wed, 14 Sep 2022 10:21:50 -0700 (PDT) X-Received: by 2002:a63:2546:0:b0:438:fe66:dc3 with SMTP id l67-20020a632546000000b00438fe660dc3mr14341880pgl.113.1663176110240; Wed, 14 Sep 2022 10:21:50 -0700 (PDT) MIME-Version: 1.0 References: <20220907200233.21255-1-pal@sandflow.com> In-Reply-To: <20220907200233.21255-1-pal@sandflow.com> From: Pierre-Anthony Lemieux Date: Wed, 14 Sep 2022 10:21:39 -0700 X-Gmail-Original-Message-ID: Message-ID: To: ffmpeg-devel@ffmpeg.org Subject: Re: [FFmpeg-devel] [PATCH] format/imfdec: improve error handling when selecting tracks for playback X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: Ping. This patchset addresses a coverity issue #1512414. On Wed, Sep 7, 2022 at 1:02 PM wrote: > > From: Pierre-Anthony Lemieux > > Addresses coverity 1512414 > > --- > libavformat/imfdec.c | 15 ++++++++++++--- > 1 file changed, 12 insertions(+), 3 deletions(-) > > diff --git a/libavformat/imfdec.c b/libavformat/imfdec.c > index 5bbe7a53f8..58b1455c9f 100644 > --- a/libavformat/imfdec.c > +++ b/libavformat/imfdec.c > @@ -681,8 +681,11 @@ static IMFVirtualTrackPlaybackCtx *get_next_track_with_minimum_timestamp(AVForma > { > IMFContext *c = s->priv_data; > IMFVirtualTrackPlaybackCtx *track; > + AVRational minimum_timestamp = av_make_q(INT_MAX, 1); > + > + if (!c->track_count) > + return NULL; > > - AVRational minimum_timestamp = av_make_q(INT32_MAX, 1); > for (uint32_t i = c->track_count; i > 0; i--) { > av_log(s, AV_LOG_TRACE, "Compare track %d timestamp " AVRATIONAL_FORMAT > " to minimum " AVRATIONAL_FORMAT > @@ -697,8 +700,6 @@ static IMFVirtualTrackPlaybackCtx *get_next_track_with_minimum_timestamp(AVForma > } > } > > - av_log(s, AV_LOG_DEBUG, "Found next track to read: %d (timestamp: %lf / %lf)\n", > - track->index, av_q2d(track->current_timestamp), av_q2d(minimum_timestamp)); > return track; > } > > @@ -761,6 +762,14 @@ static int imf_read_packet(AVFormatContext *s, AVPacket *pkt) > > track = get_next_track_with_minimum_timestamp(s); > > + if (!track) { > + av_log(s, AV_LOG_ERROR, "No track found for playback\n"); > + return AVERROR_INVALIDDATA; > + } > + > + av_log(s, AV_LOG_DEBUG, "Found track %d to read at timestamp %lf\n", > + track->index, av_q2d(track->current_timestamp)); > + > ret = get_resource_context_for_timestamp(s, track, &resource); > if (ret) > return ret; > -- > 2.25.1 > _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".