From: Pierre-Anthony Lemieux <pal@sandflow.com> To: FFmpeg development discussions and patches <ffmpeg-devel@ffmpeg.org> Cc: "Kacper Michajłow" <kasper93@gmail.com> Subject: Re: [FFmpeg-devel] [PATCH 2/2] avformat/imfdec: inherit opaque from parent AVFormatContext Date: Fri, 16 May 2025 21:15:58 -0700 Message-ID: <CAF_7JxBRrWkF3QQt16zcjBtxA7DAQhN0J7Epkp_KXfGpM22cmA@mail.gmail.com> (raw) In-Reply-To: <20250517035029.202-2-kasper93@gmail.com> On Fri, May 16, 2025 at 8:51 PM Kacper Michajłow <kasper93@gmail.com> wrote: > > io_open and io_close2 callbacks may use opaque pointer stored in the > context. They are already inherited, so opaque should also be passed > through. > > Fixes IMF playback in mpv. > > Signed-off-by: Kacper Michajłow <kasper93@gmail.com> > --- > libavformat/imfdec.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/libavformat/imfdec.c b/libavformat/imfdec.c > index a86b4763ff..b4df37daa3 100644 > --- a/libavformat/imfdec.c > +++ b/libavformat/imfdec.c > @@ -380,6 +380,7 @@ static int open_track_resource_context(AVFormatContext *s, > > track_resource->ctx->io_open = s->io_open; > track_resource->ctx->io_close2 = s->io_close2; > + track_resource->ctx->opaque = s->opaque; LGTM. > track_resource->ctx->flags |= s->flags & ~AVFMT_FLAG_CUSTOM_IO; > > if ((ret = ff_copy_whiteblacklists(track_resource->ctx, s)) < 0) > -- > 2.45.1 > > _______________________________________________ > ffmpeg-devel mailing list > ffmpeg-devel@ffmpeg.org > https://ffmpeg.org/mailman/listinfo/ffmpeg-devel > > To unsubscribe, visit link above, or email > ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe". _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".
next prev parent reply other threads:[~2025-05-17 4:16 UTC|newest] Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top 2025-05-17 3:50 [FFmpeg-devel] [PATCH 1/2] avformat/demux: use io_close2 when closing avfromat Kacper Michajłow 2025-05-17 3:50 ` [FFmpeg-devel] [PATCH 2/2] avformat/imfdec: inherit opaque from parent AVFormatContext Kacper Michajłow 2025-05-17 4:15 ` Pierre-Anthony Lemieux [this message] 2025-05-22 22:58 ` Michael Niedermayer 2025-05-17 12:39 ` [FFmpeg-devel] [PATCH 1/2] avformat/demux: use io_close2 when closing avfromat Andreas Rheinhardt 2025-05-17 13:03 ` Andreas Rheinhardt 2025-05-17 18:59 ` Kacper Michajlow 2025-05-30 19:47 ` Michael Niedermayer 2025-05-30 20:48 ` Andreas Rheinhardt 2025-05-30 22:08 ` Michael Niedermayer
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=CAF_7JxBRrWkF3QQt16zcjBtxA7DAQhN0J7Epkp_KXfGpM22cmA@mail.gmail.com \ --to=pal@sandflow.com \ --cc=ffmpeg-devel@ffmpeg.org \ --cc=kasper93@gmail.com \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: link
Git Inbox Mirror of the ffmpeg-devel mailing list - see https://ffmpeg.org/mailman/listinfo/ffmpeg-devel This inbox may be cloned and mirrored by anyone: git clone --mirror https://master.gitmailbox.com/ffmpegdev/0 ffmpegdev/git/0.git # If you have public-inbox 1.1+ installed, you may # initialize and index your mirror using the following commands: public-inbox-init -V2 ffmpegdev ffmpegdev/ https://master.gitmailbox.com/ffmpegdev \ ffmpegdev@gitmailbox.com public-inbox-index ffmpegdev Example config snippet for mirrors. AGPL code for this site: git clone https://public-inbox.org/public-inbox.git