From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTP id 5662F41053 for ; Sun, 2 Jan 2022 23:38:53 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id 25FA368B0EE; Mon, 3 Jan 2022 01:38:51 +0200 (EET) Received: from mail-io1-f42.google.com (mail-io1-f42.google.com [209.85.166.42]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id C22A268A101 for ; Mon, 3 Jan 2022 01:38:44 +0200 (EET) Received: by mail-io1-f42.google.com with SMTP id h23so28410082iol.11 for ; Sun, 02 Jan 2022 15:38:44 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=sandflow-com.20210112.gappssmtp.com; s=20210112; h=mime-version:references:in-reply-to:from:date:message-id:subject:to; bh=tQ+2GHeG/H5ujgVd8j09fNQuZDhF6St97sTjZRkUo1E=; b=1t3v27TzjV8G1Jhpc0wBpF1kLcLLHgQGo3uYudSAvLoHzJNbEtDBd93Ud/9ZibdGJI AtLOObqEFfsoaFF7r2xbMCBbtfgDsCsJpzj91O7vCN+evsw0ab/UR++LrqoHN6GpUn5q omnOqcZDoT3UIIpEH1ZxT4CzLdvi8/LEz24CteWJkHzS9GqPLCp5OHiinQRyY/Nr8qYJ WpNqbx/HKkDl06e3pQtoFFPURQylQpXFDe0Laxsc596gqYB7pTWtXVX025MVoT3PmCVC NR0rD+lZnW8W8WT7RZyw9Ur3p+oT1vc3h6oHNdHZNTPklLL4Ec9arvmF1KR73Eq6OjH+ wxhg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to; bh=tQ+2GHeG/H5ujgVd8j09fNQuZDhF6St97sTjZRkUo1E=; b=oFe3c1bkTm59ykYByHrWvEWTVGpdezznz+Tc56UTGqYnJPbybYlYX3N/SO3cWyFkHI 7LDZ7uq4mkivplj5LobmFHYkjAAI61ZKuvuRgW5br1kiummZEixFyQGUBtoWkr4yqhue 8VwvBk7G7bl/fT4ijFVp7Dd7jvGrLDA9HAIiw+AqGiKChvd3qGXWhy+V5Jo39rpwowQ1 ebtr/j2eZImrs46bsRcBiXnl+KhzKutZryyRQAtH9T+B2L5THf5xwfid/HHPzJcaHYpU 9B9cU2dA7nSqlPUCcVEjQkz7mHs9DSh1Z1QhK1vtte/PUsfE/j8WxpUG6RqP3AvsQpT4 ZMzg== X-Gm-Message-State: AOAM531DcmoiiqbgN6E6BHN7HrE7pKI0/yObo7IzRni30NNXYNr2Zkt6 aeDcfq2EaiaCNg3jKbSO+3KbctSztLwueA== X-Google-Smtp-Source: ABdhPJzjzXWmksxxZEl08sV6kT7N6X+4xRZJfrZaNnekzs7rPwcFpgXsv7fr4shn7qgalbogCDaWhw== X-Received: by 2002:a6b:4f01:: with SMTP id d1mr19678564iob.33.1641166723018; Sun, 02 Jan 2022 15:38:43 -0800 (PST) Received: from mail-il1-f180.google.com (mail-il1-f180.google.com. [209.85.166.180]) by smtp.gmail.com with ESMTPSA id g11sm20485821ild.52.2022.01.02.15.38.42 for (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Sun, 02 Jan 2022 15:38:42 -0800 (PST) Received: by mail-il1-f180.google.com with SMTP id y16so24829705ilq.8 for ; Sun, 02 Jan 2022 15:38:42 -0800 (PST) X-Received: by 2002:a05:6e02:c94:: with SMTP id b20mr18612477ile.176.1641166722194; Sun, 02 Jan 2022 15:38:42 -0800 (PST) MIME-Version: 1.0 References: <20220102231628.5306-1-pal@sandflow.com> <67fe5a3e-1764-a6b0-8e31-26affa5ae5e9@gmail.com> In-Reply-To: <67fe5a3e-1764-a6b0-8e31-26affa5ae5e9@gmail.com> From: Pierre-Anthony Lemieux Date: Sun, 2 Jan 2022 15:38:29 -0800 X-Gmail-Original-Message-ID: Message-ID: To: FFmpeg development discussions and patches Subject: Re: [FFmpeg-devel] [PATCH v2] avformat/imf: add IMF CPL with repeated resources to FATE X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: On Sun, Jan 2, 2022 at 3:28 PM James Almer wrote: > > > > On 1/2/2022 8:16 PM, pal@sandflow.com wrote: > > From: Pierre-Anthony Lemieux > > > > Signed-off-by: Pierre-Anthony Lemieux > > --- > > > > Notes: > > The `fate-imf-cpl-with-repeat` target requires following files (<256 kB) > > to placed under $(TARGET_SAMPLES)/imf/countdown/: > > http://ffmpeg-imf-samples-public.s3-website-us-west-1.amazonaws.com/countdown/ASSETMAP.xml > > http://ffmpeg-imf-samples-public.s3-website-us-west-1.amazonaws.com/countdown/CPL_f5095caa-f204-4e1c-8a84-7af48c7ae16b.xml > > http://ffmpeg-imf-samples-public.s3-website-us-west-1.amazonaws.com/countdown/PKL_4671220f-c87a-4660-bf2a-6ef848791a2c.xml > > http://ffmpeg-imf-samples-public.s3-website-us-west-1.amazonaws.com/countdown/frame-counter.mxf > > > > tests/Makefile | 1 + > > tests/fate/imf.mak | 12 ++++++++ > > tests/ref/fate/imf-cpl-with-repeat | 46 ++++++++++++++++++++++++++++++ > > 3 files changed, 59 insertions(+) > > create mode 100644 tests/fate/imf.mak > > create mode 100644 tests/ref/fate/imf-cpl-with-repeat > > > > diff --git a/tests/Makefile b/tests/Makefile > > index 87807ed31f..c4c31ae871 100644 > > --- a/tests/Makefile > > +++ b/tests/Makefile > > @@ -153,6 +153,7 @@ include $(SRC_PATH)/tests/fate/hlsenc.mak > > include $(SRC_PATH)/tests/fate/hw.mak > > include $(SRC_PATH)/tests/fate/id3v2.mak > > include $(SRC_PATH)/tests/fate/image.mak > > +include $(SRC_PATH)/tests/fate/imf.mak > > include $(SRC_PATH)/tests/fate/indeo.mak > > include $(SRC_PATH)/tests/fate/libavcodec.mak > > include $(SRC_PATH)/tests/fate/libavdevice.mak > > diff --git a/tests/fate/imf.mak b/tests/fate/imf.mak > > new file mode 100644 > > index 0000000000..c9490d665b > > --- /dev/null > > +++ b/tests/fate/imf.mak > > @@ -0,0 +1,12 @@ > > +FATE_IMF += fate-imf-cpl-with-repeat > > +fate-imf-cpl-with-repeat: $(TARGET_SAMPLES)/imf/countdown/CPL_f5095caa-f204-4e1c-8a84-7af48c7ae16b.xml > > +fate-imf-cpl-with-repeat: $(TARGET_SAMPLES)/imf/countdown/ASSETMAP.xml > > +fate-imf-cpl-with-repeat: $(TARGET_SAMPLES)/imf/countdown/frame-counter.mxf > > +fate-imf-cpl-with-repeat: $(TARGET_SAMPLES)/imf/countdown/PKL_4671220f-c87a-4660-bf2a-6ef848791a2c.xml > > No need for these four lines. They wrongly make the build system assume > it needs to create these files if they are not available. > > Simply by adding the test to the FATE_SAMPLES_AVCONV list like you're > doing below will make sure it's not run unless a samples directory was > provided. > > > +fate-imf-cpl-with-repeat: CMD = framecrc -i $(TARGET_SAMPLES)/imf/countdown/CPL_f5095caa-f204-4e1c-8a84-7af48c7ae16b.xml -c:v copy > > + > > +FATE_IMF-$(CONFIG_IMF_DEMUXER) += $(FATE_IMF) > > This test also needs the mxf demuxer, right? Should instead be > > $(call ALLYES, IMF_DEMUXER MXF_DEMUXER) if so. > > > + > > +FATE_SAMPLES_AVCONV += $(FATE_IMF-yes) > > + > > +fate-imf: $(FATE_IMF-yes) > > You can do > > FATE_SAMPLES_AVCONV-$(call ALLYES, IMF_DEMUXER MXF_DEMUXER) += $(FATE_IMF) > > fate-imf: $(FATE_IMF) > > And not bother adding a FATE_IMF-yes variable. ... so basically: ``` FATE_IMF += fate-imf-cpl-with-repeat fate-imf-cpl-with-repeat: CMD = framecrc -i $(TARGET_SAMPLES)/imf/countdown/CPL_f5095caa-f204-4e1c-8a84-7af48c7ae16b.xml -c:v copy FATE_SAMPLES_AVCONV-$(call ALLYES, IMF_DEMUXER MXF_DEMUXER) += $(FATE_IMF) fate-imf: $(FATE_IMF) ``` > > > diff --git a/tests/ref/fate/imf-cpl-with-repeat b/tests/ref/fate/imf-cpl-with-repeat > > new file mode 100644 > > index 0000000000..38092d542c > > --- /dev/null > > +++ b/tests/ref/fate/imf-cpl-with-repeat > > @@ -0,0 +1,46 @@ > > +#tb 0: 1/24 > > +#media_type 0: video > > +#codec_id 0: jpeg2000 > > +#dimensions 0: 1920x1080 > > +#sar 0: 0/1 > > +0, 0, 0, 1, 5034, 0x29a972c1 > > +0, 1, 1, 1, 7214, 0x704fb452 > > +0, 2, 2, 1, 8496, 0xee9d2692 > > +0, 3, 3, 1, 4917, 0xd35c1a2f > > +0, 4, 4, 1, 8803, 0xdc01ad91 > > +0, 5, 5, 1, 8426, 0xacc4413a > > +0, 6, 6, 1, 9626, 0x46865f1e > > +0, 7, 7, 1, 7409, 0xa21efc69 > > +0, 8, 8, 1, 7409, 0xa21efc69 > > +0, 9, 9, 1, 7409, 0xa21efc69 > > +0, 10, 10, 1, 7409, 0xa21efc69 > > +0, 11, 11, 1, 7409, 0xa21efc69 > > +0, 12, 12, 1, 7409, 0xa21efc69 > > +0, 13, 13, 1, 7409, 0xa21efc69 > > +0, 14, 14, 1, 7409, 0xa21efc69 > > +0, 15, 15, 1, 7409, 0xa21efc69 > > +0, 16, 16, 1, 7409, 0xa21efc69 > > +0, 17, 17, 1, 7409, 0xa21efc69 > > +0, 18, 18, 1, 7409, 0xa21efc69 > > +0, 19, 19, 1, 7409, 0xa21efc69 > > +0, 20, 20, 1, 7409, 0xa21efc69 > > +0, 21, 21, 1, 7409, 0xa21efc69 > > +0, 22, 22, 1, 7409, 0xa21efc69 > > +0, 23, 23, 1, 7409, 0xa21efc69 > > +0, 24, 24, 1, 7409, 0xa21efc69 > > +0, 25, 25, 1, 7409, 0xa21efc69 > > +0, 26, 26, 1, 7409, 0xa21efc69 > > +0, 27, 27, 1, 7409, 0xa21efc69 > > +0, 28, 28, 1, 7409, 0xa21efc69 > > +0, 29, 29, 1, 7409, 0xa21efc69 > > +0, 30, 30, 1, 7409, 0xa21efc69 > > +0, 30, 31, 1, 8426, 0xacc4413a > > +0, 30, 32, 1, 9626, 0x46865f1e > > +0, 30, 33, 1, 5412, 0xf4884a91 > > +0, 30, 34, 1, 9129, 0xbdb77fb3 > > +0, 30, 35, 1, 10009, 0xac8a3ec5 > > +0, 30, 36, 1, 7204, 0x4e239746 > > +0, 30, 37, 1, 9413, 0x27620541 > > +0, 30, 38, 1, 10725, 0x2feb9589 > > +0, 30, 39, 1, 7101, 0x62159f85 > > +0, 30, 40, 1, 10984, 0xa2eb2e49 > _______________________________________________ > ffmpeg-devel mailing list > ffmpeg-devel@ffmpeg.org > https://ffmpeg.org/mailman/listinfo/ffmpeg-devel > > To unsubscribe, visit link above, or email > ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe". _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".