From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTP id 6DBEB43EE0 for ; Fri, 16 Sep 2022 17:39:48 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id 382A568BBF7; Fri, 16 Sep 2022 20:39:45 +0300 (EEST) Received: from mail-pl1-f178.google.com (mail-pl1-f178.google.com [209.85.214.178]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id CAAD268BB86 for ; Fri, 16 Sep 2022 20:39:38 +0300 (EEST) Received: by mail-pl1-f178.google.com with SMTP id w20so10023877ply.12 for ; Fri, 16 Sep 2022 10:39:38 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=sandflow-com.20210112.gappssmtp.com; s=20210112; h=to:subject:message-id:date:from:in-reply-to:references:mime-version :from:to:cc:subject:date; bh=KDTGEnaxSSrMhv/HHhWzVHC9LuFfih+SOPzrH4IYplM=; b=dYI7dhuq+m0MGnYRUInJsGJ+PKdzQRLIF6DBM74ClS5x9LkvLFDz986OLB/2cJ8ABA hkhtxbmAP0Kq1fyV2+LJRWgsSlEuBi9bSxjep4wVD6R4CRhEPd8c47FQbub7cmWPzK17 qSGCieDyQ6eH9oIBFkIp60doCP7DYeq9v0H4WQoxYbNtWbA+B5RM+xzRYtnOOPlIuwa0 jAxA40TF1ZPWizQGNtRNujce0K9IT6U6jjyt1Dp4OUYUvjbxOJ3KxOFXYAgDZLKnt7mQ 9hrdPdqNA9hI2W99dAomgoeCff/T7Q2wWdUBfFTME/JWB+Zkf+N+Rpk+wjdbqXwhzpqw p/9Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=to:subject:message-id:date:from:in-reply-to:references:mime-version :x-gm-message-state:from:to:cc:subject:date; bh=KDTGEnaxSSrMhv/HHhWzVHC9LuFfih+SOPzrH4IYplM=; b=Estd9nEDrK4fCGh3aRVfGMNED5MIFhiCoxXO8/coEVFi1VMxwZiz6TUxhMwmm3O0i7 8U4lT4xSy7zEZISLsmdcIN0j8c49bpo8xrhqbForZCLrEZjE53LFcv5x5A5F0ish/TX2 8MD945Xz3Ah45nT70vplbQZ73X45khEubjskn17v1h/iNs3zKQ1forytT67NBl72yL+q /QDR7/2CCOVVgW2YX+/5L4hoPMykUPWnQ1j9gN3QJrC1dn+bnpQ0pM2Id0Kbw3LuR8sW 2ABbGc3W9RJjZj5kIEDiHjpwLoddkyAqhSmKKhE8i2BnCt5Z3ZLg7xaSd5A59RxiymWl kJjA== X-Gm-Message-State: ACrzQf33qE7Lk53HKdnOLLsGLeDRB0iD5J7AlH+J1NY/rjg7tDUKyWrg TS7gX6S3VtopYOjKLCuTUNuipc1ugknRmw== X-Google-Smtp-Source: AMsMyM73NMdUFts9sYF7ZutSEApsXXfX4Lq0MF0uEaN80Ttpm5U4717+p/PH1/qDKf/gK3OM36qr+A== X-Received: by 2002:a17:90a:c402:b0:1f2:ca71:93a5 with SMTP id i2-20020a17090ac40200b001f2ca7193a5mr6739604pjt.34.1663349976151; Fri, 16 Sep 2022 10:39:36 -0700 (PDT) Received: from mail-pj1-f45.google.com (mail-pj1-f45.google.com. [209.85.216.45]) by smtp.gmail.com with ESMTPSA id y1-20020aa79421000000b00537daf64e8esm14804115pfo.188.2022.09.16.10.39.35 for (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 16 Sep 2022 10:39:35 -0700 (PDT) Received: by mail-pj1-f45.google.com with SMTP id j6-20020a17090a694600b00200bba67dadso311804pjm.5 for ; Fri, 16 Sep 2022 10:39:35 -0700 (PDT) X-Received: by 2002:a17:90a:c981:b0:1fe:55ef:b60f with SMTP id w1-20020a17090ac98100b001fe55efb60fmr17863331pjt.246.1663349974106; Fri, 16 Sep 2022 10:39:34 -0700 (PDT) MIME-Version: 1.0 References: <20220907200233.21255-1-pal@sandflow.com> <20220916172655.GV2088045@pb2> In-Reply-To: <20220916172655.GV2088045@pb2> From: Pierre-Anthony Lemieux Date: Fri, 16 Sep 2022 10:39:22 -0700 X-Gmail-Original-Message-ID: Message-ID: To: FFmpeg development discussions and patches Subject: Re: [FFmpeg-devel] [PATCH] format/imfdec: improve error handling when selecting tracks for playback X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: On Fri, Sep 16, 2022 at 10:27 AM Michael Niedermayer wrote: > > On Wed, Sep 07, 2022 at 01:02:33PM -0700, pal@sandflow.com wrote: > > From: Pierre-Anthony Lemieux > > > > Addresses coverity 1512414 > > > > --- > > libavformat/imfdec.c | 15 ++++++++++++--- > > 1 file changed, 12 insertions(+), 3 deletions(-) > > > > diff --git a/libavformat/imfdec.c b/libavformat/imfdec.c > > index 5bbe7a53f8..58b1455c9f 100644 > > --- a/libavformat/imfdec.c > > +++ b/libavformat/imfdec.c > > @@ -681,8 +681,11 @@ static IMFVirtualTrackPlaybackCtx *get_next_track_with_minimum_timestamp(AVForma > > { > > IMFContext *c = s->priv_data; > > IMFVirtualTrackPlaybackCtx *track; > > > + AVRational minimum_timestamp = av_make_q(INT_MAX, 1); > > - AVRational minimum_timestamp = av_make_q(INT32_MAX, 1); > > iam not sure thats a good idea, it would change behavior on different platforms I was following the earlier observations that "The initialization of minimum_timestamp presumes that int are 32bit which need not be true": http://ffmpeg.org/pipermail/ffmpeg-devel/2022-August/300587.html If I am not mistaken, the numerator and denominator of AVRational are defined as `int`: https://www.ffmpeg.org/doxygen/trunk/structAVRational.html What would be the alternative? > > thx > > [...] > -- > Michael GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB > > it is not once nor twice but times without number that the same ideas make > their appearance in the world. -- Aristotle > _______________________________________________ > ffmpeg-devel mailing list > ffmpeg-devel@ffmpeg.org > https://ffmpeg.org/mailman/listinfo/ffmpeg-devel > > To unsubscribe, visit link above, or email > ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe". _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".