From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTP id 8DAE8432E3 for ; Tue, 31 May 2022 15:54:59 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id CFF8E68B6CE; Tue, 31 May 2022 18:54:57 +0300 (EEST) Received: from mail-pl1-f169.google.com (mail-pl1-f169.google.com [209.85.214.169]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id 3DA7968B546 for ; Tue, 31 May 2022 18:54:51 +0300 (EEST) Received: by mail-pl1-f169.google.com with SMTP id s14so13194565plk.8 for ; Tue, 31 May 2022 08:54:51 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=sandflow-com.20210112.gappssmtp.com; s=20210112; h=mime-version:references:in-reply-to:from:date:message-id:subject:to; bh=ObDhZfzUomd7SFwRcAW4j/cmGWtkOhyN6jJ+8LyXqX4=; b=rGuSAhObGrkOrkZFWVFrd+4YxmmbWaXnfdGlPtGx6R1LeeW5ZVxYssVJ+fMtTI60U1 2H84C9XMiUO6atY6DDiu8qFtjJprFv6kSeZfVYINC+o5dxKMlExe+UXmVa6s50WJHeRc ifA3Juk05+BnDwuS+hDjOJOsGa3QPsXgLGPPkFXF8OR6t8fX8bB8IEjznsAMAx74lqo0 g3UgW5fC6hEWClDRHFwx01qgrj70fFW9MiunOcgCg35R5ptYJi3FI4MiyzJgHw9E5D9U yjjzrRLVaVsfF4Ox4XFd70XtwwFG6X4A9Jc4FEaj5BUu7L6Ta/hNPyxLtWXz8RsTJbSN jChw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to; bh=ObDhZfzUomd7SFwRcAW4j/cmGWtkOhyN6jJ+8LyXqX4=; b=ZGIswsfMGFQLU/vq5s/Zvyucn+A0Xxkd+ENCGWeTjOzb9Aj6jLpz5AsUDZ0k8EUQ+Z whMoUe7E/NDoxnpDhoO5LzwHYLK3bcDDbS5E9cdMGmLGHgAHfFvv7FXAtuPhV5BG4OFU mUsGJO/17OaHfd4oCljAveF87nrjSFA5VFtaId+/DROIAXvPdyDIrsH6nHfT2gGXneqT Q+vq8C0t0x+RRamsCrYHgo+BHHZ5E0mhIUjvc8fvgZ1C3Im4dHeaBSRSXjmxQ0ZX5cCk EW39OvF9u3M5ukGiUCNtF7/leKJN/7AusKMddeiSINwMLaNvLW48hnWjhHC3zY8xwXbz vcrg== X-Gm-Message-State: AOAM530919suTmGviHsnoZYbbzzqSsnXcpnBtasxF507smSiEDil1PP+ PMP64OTKnPCd2SntlxgGT3/wENlY2vDTrw== X-Google-Smtp-Source: ABdhPJwxafAwuBXzr1NHHkCNXtN+7s6HZuYEgtXy2IREmNT2nY/sepX+v/d9xr5jOti3PwxwNogyGg== X-Received: by 2002:a17:903:213:b0:162:15c2:e4b5 with SMTP id r19-20020a170903021300b0016215c2e4b5mr47669170plh.114.1654012489425; Tue, 31 May 2022 08:54:49 -0700 (PDT) Received: from mail-pf1-f173.google.com (mail-pf1-f173.google.com. [209.85.210.173]) by smtp.gmail.com with ESMTPSA id p8-20020a170902b08800b0015e8d4eb237sm11370110plr.129.2022.05.31.08.54.49 for (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 31 May 2022 08:54:49 -0700 (PDT) Received: by mail-pf1-f173.google.com with SMTP id u2so2648971pfc.2 for ; Tue, 31 May 2022 08:54:49 -0700 (PDT) X-Received: by 2002:aa7:9047:0:b0:519:36a2:9f63 with SMTP id n7-20020aa79047000000b0051936a29f63mr21670220pfo.60.1654012488648; Tue, 31 May 2022 08:54:48 -0700 (PDT) MIME-Version: 1.0 References: <20220531031334.19488-1-pal@sandflow.com> <20220531031334.19488-6-pal@sandflow.com> In-Reply-To: From: Pierre-Anthony Lemieux Date: Tue, 31 May 2022 08:54:36 -0700 X-Gmail-Original-Message-ID: Message-ID: To: FFmpeg development discussions and patches Subject: Re: [FFmpeg-devel] [PATCH v3 6/6] avfilter/showinfo: refactor to use avutil/uuid X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: On Tue, May 31, 2022 at 12:10 AM Andreas Rheinhardt wrote: > > pal@sandflow.com: > > From: Pierre-Anthony Lemieux > > > > --- > > libavfilter/vf_showinfo.c | 17 +++++------------ > > 1 file changed, 5 insertions(+), 12 deletions(-) > > > > diff --git a/libavfilter/vf_showinfo.c b/libavfilter/vf_showinfo.c > > index 12d39310ef..0d6f2805bb 100644 > > --- a/libavfilter/vf_showinfo.c > > +++ b/libavfilter/vf_showinfo.c > > @@ -42,6 +42,7 @@ > > #include "libavutil/mastering_display_metadata.h" > > #include "libavutil/video_enc_params.h" > > #include "libavutil/detection_bbox.h" > > +#include "libavutil/uuid.h" > > > > #include "avfilter.h" > > #include "internal.h" > > @@ -421,29 +422,21 @@ static void dump_video_enc_params(AVFilterContext *ctx, const AVFrameSideData *s > > > > static void dump_sei_unregistered_metadata(AVFilterContext *ctx, const AVFrameSideData *sd) > > { > > - const int uuid_size = 16; > > const uint8_t *user_data = sd->data; > > int i; > > > > - if (sd->size < uuid_size) { > > + if (sd->size < AV_UUID_LEN) { > > av_log(ctx, AV_LOG_ERROR, "invalid data(%"SIZE_SPECIFIER" < " > > - "UUID(%d-bytes))\n", sd->size, uuid_size); > > + "UUID(%d-bytes))\n", sd->size, AV_UUID_LEN); > > return; > > } > > > > av_log(ctx, AV_LOG_INFO, "User Data Unregistered:\n"); > > - av_log(ctx, AV_LOG_INFO, "UUID="); > > - for (i = 0; i < uuid_size; i++) { > > - av_log(ctx, AV_LOG_INFO, "%02x", user_data[i]); > > - if (i == 3 || i == 5 || i == 7 || i == 9) > > - av_log(ctx, AV_LOG_INFO, "-"); > > - } > > - av_log(ctx, AV_LOG_INFO, "\n"); > > + av_log(ctx, AV_LOG_INFO, "UUID=" AV_PRI_UUID "\n", AV_UUID_ARG(user_data)); > > > > av_log(ctx, AV_LOG_INFO, "User Data="); > > - for (; i < sd->size; i++) { > > + for (i = 16; i < sd->size; i++) > > You can (and should) now use a for-loop with variable-declaration (and > the type should be changed to size_t, as AVFrameSideData is now size_t, > too). Will fix. Thanks. > > > av_log(ctx, AV_LOG_INFO, "%02x", user_data[i]); > > - } > > av_log(ctx, AV_LOG_INFO, "\n"); > > } > > > > _______________________________________________ > ffmpeg-devel mailing list > ffmpeg-devel@ffmpeg.org > https://ffmpeg.org/mailman/listinfo/ffmpeg-devel > > To unsubscribe, visit link above, or email > ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe". _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".