[FFmpeg-devel] [PATCH] avformat/imf_cpl: Check the right variable

[FFmpeg-devel] [PATCH] avformat/imf_cpl: Check the right variable

[Andreas Rheinhardt]

Fixes Coverity issue #1512407.

Signed-off-by: Andreas Rheinhardt <andreas.rheinhardt@outlook.com>
---
 libavformat/imf_cpl.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/libavformat/imf_cpl.c b/libavformat/imf_cpl.c
index 4acc20feee..474db6b7f5 100644
--- a/libavformat/imf_cpl.c
+++ b/libavformat/imf_cpl.c
@@ -625,7 +625,7 @@ static int fill_virtual_tracks(xmlNodePtr cpl_element, FFIMFCPL *cpl)
         av_log(NULL, AV_LOG_DEBUG, "Processing IMF CPL Segment\n");
 
         sequence_list_elem = ff_imf_xml_get_child_element_by_name(segment_elem, "SequenceList");
-        if (!segment_list_elem)
+        if (!sequence_list_elem)
             continue;
 
         sequence_elem = xmlFirstElementChild(sequence_list_elem);
-- 
2.34.1

_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel

To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".

Re: [FFmpeg-devel] [PATCH] avformat/imf_cpl: Check the right variable

[Pierre-Anthony Lemieux]

LGTM

On Thu, Aug 25, 2022 at 2:01 PM Andreas Rheinhardt
<andreas.rheinhardt@outlook.com> wrote:
>
> Fixes Coverity issue #1512407.
>
> Signed-off-by: Andreas Rheinhardt <andreas.rheinhardt@outlook.com>
> ---
>  libavformat/imf_cpl.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/libavformat/imf_cpl.c b/libavformat/imf_cpl.c
> index 4acc20feee..474db6b7f5 100644
> --- a/libavformat/imf_cpl.c
> +++ b/libavformat/imf_cpl.c
> @@ -625,7 +625,7 @@ static int fill_virtual_tracks(xmlNodePtr cpl_element, FFIMFCPL *cpl)
>          av_log(NULL, AV_LOG_DEBUG, "Processing IMF CPL Segment\n");
>
>          sequence_list_elem = ff_imf_xml_get_child_element_by_name(segment_elem, "SequenceList");
> -        if (!segment_list_elem)
> +        if (!sequence_list_elem)
>              continue;
>
>          sequence_elem = xmlFirstElementChild(sequence_list_elem);
> --
> 2.34.1
>
> _______________________________________________
> ffmpeg-devel mailing list
> ffmpeg-devel@ffmpeg.org
> https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
>
> To unsubscribe, visit link above, or email
> ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".
_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel

To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".