From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTP id E386444393 for ; Tue, 6 Sep 2022 21:52:38 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id 2C2FE68BB5A; Wed, 7 Sep 2022 00:52:37 +0300 (EEST) Received: from mail-pl1-f173.google.com (mail-pl1-f173.google.com [209.85.214.173]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id 0629468BB50 for ; Wed, 7 Sep 2022 00:52:35 +0300 (EEST) Received: by mail-pl1-f173.google.com with SMTP id u22so12557553plq.12 for ; Tue, 06 Sep 2022 14:52:35 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=sandflow-com.20210112.gappssmtp.com; s=20210112; h=to:subject:message-id:date:from:in-reply-to:references:mime-version :from:to:cc:subject:date; bh=hdswEhuV4Ffw0flgvsg82F9mccE4mMPPKcarPIfU8X4=; b=exfO9vRab/e5rtJWv/JX50NSnlznVuhE/SkHxKEJp5nW9+ssDMc4vv1oYpy3FKP9Rl K7u+RVTOCl/wA7y+WXSZPEFulJH2kzoO7lFX85n1TgQIuDUcEMMXMsv+6kCOsY+JFUyr dEtSrzbP6Pj6AHJYRc8OQmpfdzGRG2Jh0vKlRM2FCFlBDap44UT5BdeT7gGKUjwYfWCr 7UnSP5vmlfLqREaKxolU14EQUzn8jg2YsJWWeqbApOg02k1o5K0KBNgJf+ghAccxeDe7 iABWQ61aBZe3G0HYcHjsKbugBooeF8ZAIEOH+fnCNseD3fw6gWskLn1HsheBa4UxgWOM /lqw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=to:subject:message-id:date:from:in-reply-to:references:mime-version :x-gm-message-state:from:to:cc:subject:date; bh=hdswEhuV4Ffw0flgvsg82F9mccE4mMPPKcarPIfU8X4=; b=GVk1tFPOtxvjETYFfYvv6rvVzoSbOpvlaJfJKJpHwfZlIIcdP7YLlv32vv1YeOevjm Rw3QIX+n8sZ41+C9ncZRlEPF2fGoge8w86cJ3CEfWEcs08uihk+60YGJZQiXNC9oLGzy lKg4bOFk2ccmE/ye+w5vSja9zXxjg4Vx3RLdJv6Ib3sZvoVQyTRNL9anUfaaHHqU7MLn XfE/mK0mc8Z6uoyhxprkS5Os2LNqh6g2BnRrS05CRCZJecObVDS3FKQa7z760c1cKl5l aJLeToIb2hl1WYDPR3YbGW7fUs6kWaFZc04wz1FkDVAZXK6YapWiWyFkHZwVngKnHEKV GJpA== X-Gm-Message-State: ACgBeo3qd3VdDbc1pG7aYA1aX9zaCEG3O42J9oE66qqHMOd3HajR7Kye 40EMA+e4mbUYhQeo/GSrBcfn1EVxsx85Mg== X-Google-Smtp-Source: AA6agR4iCHKbMqfnZ1DmVbE8zhpHHShp32ZtRkUN5i8g/W9Z+T/PW9K8RXzUROzsU3ofRZaYHwQMNQ== X-Received: by 2002:a17:90b:1c0c:b0:1f5:494a:304b with SMTP id oc12-20020a17090b1c0c00b001f5494a304bmr454964pjb.157.1662501153412; Tue, 06 Sep 2022 14:52:33 -0700 (PDT) Received: from mail-pf1-f174.google.com (mail-pf1-f174.google.com. [209.85.210.174]) by smtp.gmail.com with ESMTPSA id mn22-20020a17090b189600b001fd7cde9990sm13520781pjb.0.2022.09.06.14.52.32 for (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 06 Sep 2022 14:52:32 -0700 (PDT) Received: by mail-pf1-f174.google.com with SMTP id r12so3496857pfl.10 for ; Tue, 06 Sep 2022 14:52:32 -0700 (PDT) X-Received: by 2002:a63:6581:0:b0:434:9482:c243 with SMTP id z123-20020a636581000000b004349482c243mr603435pgb.448.1662501151888; Tue, 06 Sep 2022 14:52:31 -0700 (PDT) MIME-Version: 1.0 References: <20220905182932.7134-1-pal@sandflow.com> <20220905182932.7134-2-pal@sandflow.com> In-Reply-To: From: Pierre-Anthony Lemieux Date: Tue, 6 Sep 2022 14:52:19 -0700 X-Gmail-Original-Message-ID: Message-ID: To: FFmpeg development discussions and patches Subject: Re: [FFmpeg-devel] [PATCH v2 2/2] fate/mxf: add JPEG 2000 test X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: On Tue, Sep 6, 2022 at 2:33 PM Andreas Rheinhardt wrote: > > Pierre-Anthony Lemieux: > > On Tue, Sep 6, 2022 at 2:24 PM Andreas Rheinhardt > > wrote: > >> > >> pal@sandflow.com: > >>> From: Pierre-Anthony Lemieux > >>> > >>> --- > >>> tests/fate/mxf.mak | 4 ++ > >>> tests/ref/fate/mxf-probe-j2k | 78 ++++++++++++++++++++++++++++++++++++ > >>> 2 files changed, 82 insertions(+) > >>> create mode 100644 tests/ref/fate/mxf-probe-j2k > >>> > >>> diff --git a/tests/fate/mxf.mak b/tests/fate/mxf.mak > >>> index 3ab936b5de..38d1c2ef38 100644 > >>> --- a/tests/fate/mxf.mak > >>> +++ b/tests/fate/mxf.mak > >>> @@ -29,6 +29,10 @@ FATE_MXF_PROBE-$(call ENCDEC, DNXHD, MXF) += fate-mxf-probe-dnxhd > >>> fate-mxf-probe-dnxhd: SRC = $(TARGET_SAMPLES)/mxf/multiple_components.mxf > >>> fate-mxf-probe-dnxhd: CMD = run $(PROBE_FORMAT_STREAMS_COMMAND) -i "$(SRC)" > >>> > >>> +FATE_MXF_PROBE-$(call ENCDEC, JPEG2000, MXF) += fate-mxf-probe-j2k > >> > >> ENCDEC? Since when does ffprobe run encoders at all? > > > > I did wonder, but ended-up using the same template as fate-mxf-probe-dnxhd. > > > > Should they all be changed to DEC? > > > > I have not looked at these tests in particular, but DEMDEC is the > expected command here. Notice that there might be scenarios where you > need more (like an additional parser or the extract extradata bsf (I > expect the mxf-probe-d10 test to need the latter and maybe the former in > addition to the mpeg2video decoder.)). Fixed at v3 > > >> > >>> +fate-mxf-probe-j2k: SRC = $(TARGET_SAMPLES)/imf/countdown/countdown-small.mxf > >>> +fate-mxf-probe-j2k: CMD = run $(PROBE_FORMAT_STREAMS_COMMAND) -i "$(SRC)" > >>> + > >>> FATE_MXF_PROBE-$(call ENCDEC2, DVVIDEO, PCM_S16LE, MXF) += fate-mxf-probe-dv25 > >>> fate-mxf-probe-dv25: SRC = $(TARGET_SAMPLES)/mxf/Avid-00005.mxf > >>> fate-mxf-probe-dv25: CMD = run $(PROBE_FORMAT_STREAMS_COMMAND) -i "$(SRC)" > >>> diff --git a/tests/ref/fate/mxf-probe-j2k b/tests/ref/fate/mxf-probe-j2k > >>> new file mode 100644 > >>> index 0000000000..2dbf2ac37d > >>> --- /dev/null > >>> +++ b/tests/ref/fate/mxf-probe-j2k > >>> @@ -0,0 +1,78 @@ > >>> +[STREAM] > >>> +index=0 > >>> +codec_name=jpeg2000 > >>> +profile=1798 > >>> +codec_type=video > >>> +codec_tag_string=[0][0][0][0] > >>> +codec_tag=0x0000 > >>> +width=640 > >>> +height=360 > >>> +coded_width=640 > >>> +coded_height=360 > >>> +closed_captions=0 > >>> +film_grain=0 > >>> +has_b_frames=0 > >>> +sample_aspect_ratio=1:1 > >>> +display_aspect_ratio=16:9 > >>> +pix_fmt=rgb48le > >>> +level=-99 > >>> +color_range=unknown > >>> +color_space=unknown > >>> +color_transfer=bt709 > >>> +color_primaries=bt709 > >>> +chroma_location=unspecified > >>> +field_order=progressive > >>> +refs=1 > >>> +id=N/A > >>> +r_frame_rate=24/1 > >>> +avg_frame_rate=24/1 > >>> +time_base=1/24 > >>> +start_pts=0 > >>> +start_time=0.000000 > >>> +duration_ts=24 > >>> +duration=1.000000 > >>> +bit_rate=N/A > >>> +max_bit_rate=N/A > >>> +bits_per_raw_sample=16 > >>> +nb_frames=N/A > >>> +nb_read_frames=N/A > >>> +nb_read_packets=N/A > >>> +DISPOSITION:default=0 > >>> +DISPOSITION:dub=0 > >>> +DISPOSITION:original=0 > >>> +DISPOSITION:comment=0 > >>> +DISPOSITION:lyrics=0 > >>> +DISPOSITION:karaoke=0 > >>> +DISPOSITION:forced=0 > >>> +DISPOSITION:hearing_impaired=0 > >>> +DISPOSITION:visual_impaired=0 > >>> +DISPOSITION:clean_effects=0 > >>> +DISPOSITION:attached_pic=0 > >>> +DISPOSITION:timed_thumbnails=0 > >>> +DISPOSITION:captions=0 > >>> +DISPOSITION:descriptions=0 > >>> +DISPOSITION:metadata=0 > >>> +DISPOSITION:dependent=0 > >>> +DISPOSITION:still_image=0 > >>> +TAG:file_package_umid=0x060A2B340101010501010F201300000035E05073878E4B2FB69D2369F25ADFC9 > >>> +TAG:file_package_name=File Package: SMPTE ST 422 / ST 2067-5 frame wrapping of JPEG 2000 codestreams > >>> +TAG:track_name=Image Track > >>> +[/STREAM] > >>> +[FORMAT] > >>> +format_name=mxf > >>> +duration=1.000000 > >>> +bit_rate=577792 > >>> +TAG:operational_pattern_ul=060e2b34.04010101.0d010201.01010100 > >>> +TAG:uid=f1994e51-a844-49e4-9459-1ddd622eb65d > >>> +TAG:generation_uid=1be151ac-cc95-4314-b09f-7420eda9932b > >>> +TAG:company_name=Sandflow Consulting LLC > >>> +TAG:product_name=dcdm2imf > >>> +TAG:product_version_num=0.0.0.0.0 > >>> +TAG:product_version=1.0-beta1 > >>> +TAG:product_uid=927fc4d1-89a3-4f88-88bb-d363ed33084a > >>> +TAG:modification_date=2022-01-07T22:05:01.000000Z > >>> +TAG:toolkit_version_num=2.10.38.27240.1 > >>> +TAG:application_platform=win32 > >>> +TAG:material_package_umid=0x060A2B340101010501010F201300000072BAF0557DA749308C14738BCD4FA116 > >>> +TAG:material_package_name=Material Package > >>> +[/FORMAT] > >> > _______________________________________________ > ffmpeg-devel mailing list > ffmpeg-devel@ffmpeg.org > https://ffmpeg.org/mailman/listinfo/ffmpeg-devel > > To unsubscribe, visit link above, or email > ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe". _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".