From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTP id 40EE441A05 for ; Wed, 16 Feb 2022 16:55:10 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id B1AD468B2ED; Wed, 16 Feb 2022 18:55:09 +0200 (EET) Received: from mail-il1-f174.google.com (mail-il1-f174.google.com [209.85.166.174]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id 2765F68B2E6 for ; Wed, 16 Feb 2022 18:55:07 +0200 (EET) Received: by mail-il1-f174.google.com with SMTP id d3so225778ilr.10 for ; Wed, 16 Feb 2022 08:55:07 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=sandflow-com.20210112.gappssmtp.com; s=20210112; h=mime-version:references:in-reply-to:from:date:message-id:subject:to; bh=lWGqqecXJJqX7dY6+pahHHcTTHYDJt+MLwC6CqNZcDQ=; b=yAFXGNgNdT55Tr1pQ1RMkyJ7S+KI66TGBFbx2rTO2kZcz0qWJR15kKlX1CXgJI8juK 5Sq+7loEGqRDogvgSl5uNvJhVJsC+F6WnO9WgwiKH5Z1dCz46/lfdKlGGMkhgRn4L/w6 7xMkNyCVVsxgbjSbZwgGVZ4FH6txGAKghnf7aBdo98Te3PupC6InUwb/kw31CSW7ePth OARZtSufod+ThT+eETkjrMjqZtVtSqcUAE4tP5fZKOQeaCmEheUiQqn4onjxMfLpVscA K/IILEGssqtGbUG/Vx6xVOsxEHXYWcKFCJgKqvN8vnoDL44ire+Kraaq2PVpwnYLZmBb E+wg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to; bh=lWGqqecXJJqX7dY6+pahHHcTTHYDJt+MLwC6CqNZcDQ=; b=IqyH1T88KGeRkZTb4e7P64pQygy8wyl5uBiFR5Lzt6+C2YXeU686QqnuLUKwLuxO2n n7BUN10GxRIodXNwomkWEY+4ZbYWvmi5sZU8a0pMmWHFwnN5mjE7UGmirE0W2K1tZMFW jN1/8CBItQiJJsQTmuortC+1SdbalnGVhj2Gxdjx6pz0YmWO1+QhcgFmSBlM7hjIokLA kTAc7qz3aErtNdeZy7OQ5XJ9Q5VjSFqDHBWPwgm/756g55gHF4YiWhwwTMrt7zqCgxJ6 uIgjjyFhnjKvBgDX0xSvji3Xya51WU/ojQ7VGheIoosNy5UBv8ABUG7SCv8k3z8DwSFG HEnw== X-Gm-Message-State: AOAM533E0k/MEhRrDO79+zOBDYMvRA/dyy5jybeeKvyt2KMhIF84zrUT AqY0mQVRFLzQGwMaf2wgeWBIITbgYAhMow== X-Google-Smtp-Source: ABdhPJwMqQlNU34PnYd+QY4V2wJlho1hYUi5PPmuk1CiHx5Z8AFlOJSxmHuOKsbhklLL9Ia0HQLdcQ== X-Received: by 2002:a05:6e02:19cc:b0:2be:3e8c:6723 with SMTP id r12-20020a056e0219cc00b002be3e8c6723mr2406106ill.157.1645030504946; Wed, 16 Feb 2022 08:55:04 -0800 (PST) Received: from mail-io1-f45.google.com (mail-io1-f45.google.com. [209.85.166.45]) by smtp.gmail.com with ESMTPSA id z18sm129672ilq.47.2022.02.16.08.55.04 for (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 16 Feb 2022 08:55:04 -0800 (PST) Received: by mail-io1-f45.google.com with SMTP id z2so385405iow.8 for ; Wed, 16 Feb 2022 08:55:04 -0800 (PST) X-Received: by 2002:a05:6602:148c:b0:613:a956:4b48 with SMTP id a12-20020a056602148c00b00613a9564b48mr2449895iow.139.1645030504217; Wed, 16 Feb 2022 08:55:04 -0800 (PST) MIME-Version: 1.0 References: <20220203040745.10983-1-pal@sandflow.com> <20220203040745.10983-2-pal@sandflow.com> <5bf9971e-a6da-70a1-0238-a101de35f7d4@zanevaniperen.com> In-Reply-To: <5bf9971e-a6da-70a1-0238-a101de35f7d4@zanevaniperen.com> From: Pierre-Anthony Lemieux Date: Wed, 16 Feb 2022 08:54:52 -0800 X-Gmail-Original-Message-ID: Message-ID: To: FFmpeg development discussions and patches Subject: Re: [FFmpeg-devel] [PATCH v3 2/4] avformat/imf: fix missing error reporting when opening resources X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: On Wed, Feb 16, 2022 at 3:45 AM Zane van Iperen wrote: > > > > > On 3/2/22 14:07, pal@sandflow.com wrote: > > From: Pierre-Anthony Lemieux > > > > --- > > libavformat/imfdec.c | 4 +++- > > 1 file changed, 3 insertions(+), 1 deletion(-) > > > > diff --git a/libavformat/imfdec.c b/libavformat/imfdec.c > > index e6a1020ecc..658ddc40f2 100644 > > --- a/libavformat/imfdec.c > > +++ b/libavformat/imfdec.c > > @@ -550,7 +550,9 @@ static int set_context_streams_from_tracks(AVFormatContext *s) > > AVStream *first_resource_stream; > > > > /* Open the first resource of the track to get stream information */ > > - open_track_resource_context(s, &c->tracks[i]->resources[0]); > > + ret = open_track_resource_context(s, &c->tracks[i]->resources[0]); > > + if (ret) > > + return ret; > > first_resource_stream = c->tracks[i]->resources[0].ctx->streams[0]; > > av_log(s, AV_LOG_DEBUG, "Open the first resource of track %d\n", c->tracks[i]->index); > > > > Can you please squash this into the previous patch? Addressed by v4 > > The rest looks mostly okay. > _______________________________________________ > ffmpeg-devel mailing list > ffmpeg-devel@ffmpeg.org > https://ffmpeg.org/mailman/listinfo/ffmpeg-devel > > To unsubscribe, visit link above, or email > ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe". _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".