From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTP id 064304104F for ; Sun, 2 Jan 2022 23:49:06 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id 0DCC368A3B9; Mon, 3 Jan 2022 01:49:05 +0200 (EET) Received: from mail-il1-f178.google.com (mail-il1-f178.google.com [209.85.166.178]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id 5F2DD689997 for ; Mon, 3 Jan 2022 01:48:58 +0200 (EET) Received: by mail-il1-f178.google.com with SMTP id d14so24855310ila.1 for ; Sun, 02 Jan 2022 15:48:58 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=sandflow-com.20210112.gappssmtp.com; s=20210112; h=mime-version:references:in-reply-to:from:date:message-id:subject:to; bh=YBHnMEneJ3+4HnZAOYJ7pFkUxFxydzfus5tizFFg8g0=; b=uGsWY/EG4GXOqlZLrE165f5B+reEI5pP4F6z274zeoW6QI/jHHLjdgrxsB0TnykVMG vyN2SnE3kVeyxX6Iw9N6EIBir4mTXxjKxxJBZyNRgETFWue9mj/4o7IUSiNqIVMqawte P38OtaMmsV1UOqZXnOh1CdwL0fzq2Rw+4AM/4ahqYMmNBvOwjBUo+XOIo1wU6UzIo+TM MSOvzj07fOJX96eQ+rfsuHncT1oRdfW9kB5TzIVzFTAjviv1ppAMFPUvemWbL6NkOegW OKr3Qn6mKFoUWRTKnoDzZYBeYMwsNg2fc/5SUJnx0I2cTfDxnbge6zMIIVATC34+xVnG S2aw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to; bh=YBHnMEneJ3+4HnZAOYJ7pFkUxFxydzfus5tizFFg8g0=; b=CMFdsiVo4l58jNW7j+4aOkvodCTktTLb8UiEyvKd5kIOzfmXkyqiTum9/MojBJYAVe ZSRtLQqiBPm4Lpk4uue5YRsaTT9Rst5H/e2fuyl51Lupcmf/Z3GPnJI1HuANlO9ovVsX pd5QWtyf7+x2ejynlkuJFNFhH539TRGevtJYOTlIFxkc3dH6NpWxLT6vqm/ujM7Gbzj6 /3k2gBnhb0AKWT0J2c+v91FPWhKWuKx1Yf5ixm2dRLb9viQabCG7clcXJvSmXSPST+sV KbEuXKWu1TalwtOLFDNruLnwJzZvYuWGtNl5LTf58R4kN74YUtPvSGcruF2t5o42+Nv8 JSAA== X-Gm-Message-State: AOAM5311i7/1POyIHlC6psaHwOGhkMvJItUdYyMOz0dqlJd22AKCSqij /o4JKYPLnlIpB0clBtUTj+Ax1hUEYZX2FA== X-Google-Smtp-Source: ABdhPJyBhxzYfUSAHBRYj5HHsIinjw7Lc/iFgZxE96Gwe4dSt9oelkzZ2Z7IIVtzc0R9eHuZZ6OF5g== X-Received: by 2002:a92:2a0e:: with SMTP id r14mr20266590ile.175.1641167336547; Sun, 02 Jan 2022 15:48:56 -0800 (PST) Received: from mail-il1-f174.google.com (mail-il1-f174.google.com. [209.85.166.174]) by smtp.gmail.com with ESMTPSA id g20sm24787476iov.35.2022.01.02.15.48.56 for (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Sun, 02 Jan 2022 15:48:56 -0800 (PST) Received: by mail-il1-f174.google.com with SMTP id f17so24766982ilj.11 for ; Sun, 02 Jan 2022 15:48:56 -0800 (PST) X-Received: by 2002:a05:6e02:c94:: with SMTP id b20mr18620654ile.176.1641167335811; Sun, 02 Jan 2022 15:48:55 -0800 (PST) MIME-Version: 1.0 References: <20220102231628.5306-1-pal@sandflow.com> <67fe5a3e-1764-a6b0-8e31-26affa5ae5e9@gmail.com> <78e03ee7-afb9-d599-f2eb-c0b0ab627859@gmail.com> In-Reply-To: <78e03ee7-afb9-d599-f2eb-c0b0ab627859@gmail.com> From: Pierre-Anthony Lemieux Date: Sun, 2 Jan 2022 15:48:45 -0800 X-Gmail-Original-Message-ID: Message-ID: To: FFmpeg development discussions and patches Subject: Re: [FFmpeg-devel] [PATCH v2] avformat/imf: add IMF CPL with repeated resources to FATE X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: On Sun, Jan 2, 2022 at 3:42 PM James Almer wrote: > > > > On 1/2/2022 8:38 PM, Pierre-Anthony Lemieux wrote: > > On Sun, Jan 2, 2022 at 3:28 PM James Almer wrote: > >> > >> > >> > >> On 1/2/2022 8:16 PM, pal@sandflow.com wrote: > >>> From: Pierre-Anthony Lemieux > >>> > >>> Signed-off-by: Pierre-Anthony Lemieux > >>> --- > >>> > >>> Notes: > >>> The `fate-imf-cpl-with-repeat` target requires following files (<256 kB) > >>> to placed under $(TARGET_SAMPLES)/imf/countdown/: > >>> http://ffmpeg-imf-samples-public.s3-website-us-west-1.amazonaws.com/countdown/ASSETMAP.xml > >>> http://ffmpeg-imf-samples-public.s3-website-us-west-1.amazonaws.com/countdown/CPL_f5095caa-f204-4e1c-8a84-7af48c7ae16b.xml > >>> http://ffmpeg-imf-samples-public.s3-website-us-west-1.amazonaws.com/countdown/PKL_4671220f-c87a-4660-bf2a-6ef848791a2c.xml > >>> http://ffmpeg-imf-samples-public.s3-website-us-west-1.amazonaws.com/countdown/frame-counter.mxf > >>> > >>> tests/Makefile | 1 + > >>> tests/fate/imf.mak | 12 ++++++++ > >>> tests/ref/fate/imf-cpl-with-repeat | 46 ++++++++++++++++++++++++++++++ > >>> 3 files changed, 59 insertions(+) > >>> create mode 100644 tests/fate/imf.mak > >>> create mode 100644 tests/ref/fate/imf-cpl-with-repeat > >>> > >>> diff --git a/tests/Makefile b/tests/Makefile > >>> index 87807ed31f..c4c31ae871 100644 > >>> --- a/tests/Makefile > >>> +++ b/tests/Makefile > >>> @@ -153,6 +153,7 @@ include $(SRC_PATH)/tests/fate/hlsenc.mak > >>> include $(SRC_PATH)/tests/fate/hw.mak > >>> include $(SRC_PATH)/tests/fate/id3v2.mak > >>> include $(SRC_PATH)/tests/fate/image.mak > >>> +include $(SRC_PATH)/tests/fate/imf.mak > >>> include $(SRC_PATH)/tests/fate/indeo.mak > >>> include $(SRC_PATH)/tests/fate/libavcodec.mak > >>> include $(SRC_PATH)/tests/fate/libavdevice.mak > >>> diff --git a/tests/fate/imf.mak b/tests/fate/imf.mak > >>> new file mode 100644 > >>> index 0000000000..c9490d665b > >>> --- /dev/null > >>> +++ b/tests/fate/imf.mak > >>> @@ -0,0 +1,12 @@ > >>> +FATE_IMF += fate-imf-cpl-with-repeat > >>> +fate-imf-cpl-with-repeat: $(TARGET_SAMPLES)/imf/countdown/CPL_f5095caa-f204-4e1c-8a84-7af48c7ae16b.xml > >>> +fate-imf-cpl-with-repeat: $(TARGET_SAMPLES)/imf/countdown/ASSETMAP.xml > >>> +fate-imf-cpl-with-repeat: $(TARGET_SAMPLES)/imf/countdown/frame-counter.mxf > >>> +fate-imf-cpl-with-repeat: $(TARGET_SAMPLES)/imf/countdown/PKL_4671220f-c87a-4660-bf2a-6ef848791a2c.xml > >> > >> No need for these four lines. They wrongly make the build system assume > >> it needs to create these files if they are not available. > >> > >> Simply by adding the test to the FATE_SAMPLES_AVCONV list like you're > >> doing below will make sure it's not run unless a samples directory was > >> provided. > >> > >>> +fate-imf-cpl-with-repeat: CMD = framecrc -i $(TARGET_SAMPLES)/imf/countdown/CPL_f5095caa-f204-4e1c-8a84-7af48c7ae16b.xml -c:v copy > >>> + > >>> +FATE_IMF-$(CONFIG_IMF_DEMUXER) += $(FATE_IMF) > >> > >> This test also needs the mxf demuxer, right? Should instead be > >> > >> $(call ALLYES, IMF_DEMUXER MXF_DEMUXER) if so. > >> > >>> + > >>> +FATE_SAMPLES_AVCONV += $(FATE_IMF-yes) > >>> + > >>> +fate-imf: $(FATE_IMF-yes) > >> > >> You can do > >> > >> FATE_SAMPLES_AVCONV-$(call ALLYES, IMF_DEMUXER MXF_DEMUXER) += $(FATE_IMF) > >> > >> fate-imf: $(FATE_IMF) > >> > >> And not bother adding a FATE_IMF-yes variable. > > > > ... so basically: > > > > ``` > > FATE_IMF += fate-imf-cpl-with-repeat > > fate-imf-cpl-with-repeat: CMD = framecrc -i > > $(TARGET_SAMPLES)/imf/countdown/CPL_f5095caa-f204-4e1c-8a84-7af48c7ae16b.xml > > -c:v copy > > FATE_SAMPLES_AVCONV-$(call ALLYES, IMF_DEMUXER MXF_DEMUXER) += $(FATE_IMF) > > fate-imf: $(FATE_IMF) > > ``` > > Yes. Thanks. See v3. > > > > >> > >>> diff --git a/tests/ref/fate/imf-cpl-with-repeat b/tests/ref/fate/imf-cpl-with-repeat > >>> new file mode 100644 > >>> index 0000000000..38092d542c > >>> --- /dev/null > >>> +++ b/tests/ref/fate/imf-cpl-with-repeat > >>> @@ -0,0 +1,46 @@ > >>> +#tb 0: 1/24 > >>> +#media_type 0: video > >>> +#codec_id 0: jpeg2000 > >>> +#dimensions 0: 1920x1080 > >>> +#sar 0: 0/1 > >>> +0, 0, 0, 1, 5034, 0x29a972c1 > >>> +0, 1, 1, 1, 7214, 0x704fb452 > >>> +0, 2, 2, 1, 8496, 0xee9d2692 > >>> +0, 3, 3, 1, 4917, 0xd35c1a2f > >>> +0, 4, 4, 1, 8803, 0xdc01ad91 > >>> +0, 5, 5, 1, 8426, 0xacc4413a > >>> +0, 6, 6, 1, 9626, 0x46865f1e > >>> +0, 7, 7, 1, 7409, 0xa21efc69 > >>> +0, 8, 8, 1, 7409, 0xa21efc69 > >>> +0, 9, 9, 1, 7409, 0xa21efc69 > >>> +0, 10, 10, 1, 7409, 0xa21efc69 > >>> +0, 11, 11, 1, 7409, 0xa21efc69 > >>> +0, 12, 12, 1, 7409, 0xa21efc69 > >>> +0, 13, 13, 1, 7409, 0xa21efc69 > >>> +0, 14, 14, 1, 7409, 0xa21efc69 > >>> +0, 15, 15, 1, 7409, 0xa21efc69 > >>> +0, 16, 16, 1, 7409, 0xa21efc69 > >>> +0, 17, 17, 1, 7409, 0xa21efc69 > >>> +0, 18, 18, 1, 7409, 0xa21efc69 > >>> +0, 19, 19, 1, 7409, 0xa21efc69 > >>> +0, 20, 20, 1, 7409, 0xa21efc69 > >>> +0, 21, 21, 1, 7409, 0xa21efc69 > >>> +0, 22, 22, 1, 7409, 0xa21efc69 > >>> +0, 23, 23, 1, 7409, 0xa21efc69 > >>> +0, 24, 24, 1, 7409, 0xa21efc69 > >>> +0, 25, 25, 1, 7409, 0xa21efc69 > >>> +0, 26, 26, 1, 7409, 0xa21efc69 > >>> +0, 27, 27, 1, 7409, 0xa21efc69 > >>> +0, 28, 28, 1, 7409, 0xa21efc69 > >>> +0, 29, 29, 1, 7409, 0xa21efc69 > >>> +0, 30, 30, 1, 7409, 0xa21efc69 > >>> +0, 30, 31, 1, 8426, 0xacc4413a > >>> +0, 30, 32, 1, 9626, 0x46865f1e > >>> +0, 30, 33, 1, 5412, 0xf4884a91 > >>> +0, 30, 34, 1, 9129, 0xbdb77fb3 > >>> +0, 30, 35, 1, 10009, 0xac8a3ec5 > >>> +0, 30, 36, 1, 7204, 0x4e239746 > >>> +0, 30, 37, 1, 9413, 0x27620541 > >>> +0, 30, 38, 1, 10725, 0x2feb9589 > >>> +0, 30, 39, 1, 7101, 0x62159f85 > >>> +0, 30, 40, 1, 10984, 0xa2eb2e49 > >> _______________________________________________ > >> ffmpeg-devel mailing list > >> ffmpeg-devel@ffmpeg.org > >> https://ffmpeg.org/mailman/listinfo/ffmpeg-devel > >> > >> To unsubscribe, visit link above, or email > >> ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe". > > _______________________________________________ > > ffmpeg-devel mailing list > > ffmpeg-devel@ffmpeg.org > > https://ffmpeg.org/mailman/listinfo/ffmpeg-devel > > > > To unsubscribe, visit link above, or email > > ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe". > _______________________________________________ > ffmpeg-devel mailing list > ffmpeg-devel@ffmpeg.org > https://ffmpeg.org/mailman/listinfo/ffmpeg-devel > > To unsubscribe, visit link above, or email > ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe". _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".