From: Pierre-Anthony Lemieux <pal@sandflow.com>
To: FFmpeg development discussions and patches <ffmpeg-devel@ffmpeg.org>
Subject: Re: [FFmpeg-devel] [PATCH] configure: remove false positives with valgrind-memcheck
Date: Sat, 8 Jun 2024 22:56:46 -0700
Message-ID: <CAF_7JxALvdAnU_8xC+YF37u7T6R5Vo=6M86H3xONWzaL0Bx6pQ@mail.gmail.com> (raw)
In-Reply-To: <9ef2d6d9-48bf-4695-a8b5-859a7b6efda3@gmail.com>
On Sat, Jun 8, 2024 at 6:13 PM James Almer <jamrial@gmail.com> wrote:
>
> On 6/8/2024 9:59 PM, pal@sandflow.com wrote:
> > From: Pierre-Anthony Lemieux <pal@palemieux.com>
> >
> > If `--toolchain=valgrind-memcheck` is selected, fate-lavf-asf fails on a false positive.
>
> I can't reproduce this. Tried with both --disable-optimizations and
> without it, on Ubuntu 22.04 x86_64.
> How are you getting these false positives?
Command and log at https://pastebin.com/3TKk0RF4
>
> > ---
> > configure | 2 +-
> > 1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/configure b/configure
> > index 6c5b8aab9a..c708f2e38c 100755
> > --- a/configure
> > +++ b/configure
> > @@ -4571,7 +4571,7 @@ case "$toolchain" in
> > target_exec_args="--tool=massif --alloc-fn=av_malloc --alloc-fn=av_mallocz --alloc-fn=av_calloc --alloc-fn=av_fast_padded_malloc --alloc-fn=av_fast_malloc --alloc-fn=av_realloc_f --alloc-fn=av_fast_realloc --alloc-fn=av_realloc"
> > ;;
> > valgrind-memcheck)
> > - target_exec_args="--error-exitcode=1 --malloc-fill=0x2a --track-origins=yes --leak-check=full --gen-suppressions=all --suppressions=$source_path/tests/fate-valgrind.supp"
> > + target_exec_args="--error-exitcode=1 --expensive-definedness-checks=yes --malloc-fill=0x2a --track-origins=yes --leak-check=full --gen-suppressions=all --suppressions=$source_path/tests/fate-valgrind.supp"
> > ;;
> > esac
> > ;;
> _______________________________________________
> ffmpeg-devel mailing list
> ffmpeg-devel@ffmpeg.org
> https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
>
> To unsubscribe, visit link above, or email
> ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".
_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".
next prev parent reply other threads:[~2024-06-09 5:57 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-06-09 0:59 pal
2024-06-09 1:13 ` James Almer
2024-06-09 5:56 ` Pierre-Anthony Lemieux [this message]
2024-06-09 13:41 ` James Almer
2024-06-09 16:00 ` Pierre-Anthony Lemieux
2024-06-13 17:00 ` Pierre-Anthony Lemieux
2024-06-13 17:03 ` James Almer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAF_7JxALvdAnU_8xC+YF37u7T6R5Vo=6M86H3xONWzaL0Bx6pQ@mail.gmail.com' \
--to=pal@sandflow.com \
--cc=ffmpeg-devel@ffmpeg.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Git Inbox Mirror of the ffmpeg-devel mailing list - see https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
This inbox may be cloned and mirrored by anyone:
git clone --mirror https://master.gitmailbox.com/ffmpegdev/0 ffmpegdev/git/0.git
# If you have public-inbox 1.1+ installed, you may
# initialize and index your mirror using the following commands:
public-inbox-init -V2 ffmpegdev ffmpegdev/ https://master.gitmailbox.com/ffmpegdev \
ffmpegdev@gitmailbox.com
public-inbox-index ffmpegdev
Example config snippet for mirrors.
AGPL code for this site: git clone https://public-inbox.org/public-inbox.git