Re: [FFmpeg-devel] [PATCH 1/2] avformat/mxf: support MCA audio information

[Pierre-Anthony Lemieux <pal@sandflow.com>]

On Wed, Dec 22, 2021 at 4:38 AM Tomas Härdin <tjoppen@acc.umu.se> wrote:
>
> tis 2021-12-21 klockan 21:24 +0100 skrev Marton Balint:
> >
> >
> > On Tue, 21 Dec 2021, Tomas Härdin wrote:
> >
> > > tis 2021-12-21 klockan 11:44 +0100 skrev Marc-Antoine ARNAUD:
> > > > Le ven. 17 déc. 2021 à 19:12, Marton Balint <cus@passwd.hu> a
> > > > écrit :
> > > >
> > > > >
> > > > >
> > > > > On Fri, 17 Dec 2021, Marc-Antoine ARNAUD wrote:
> > > > >
> > > > > > Hi all,
> > > > > >
> > > > > > Can I have an update on this patch submission ?
> > > > > > Is something required to be done before it can be merged ?
> > > > >
> > > > > New channel layout API is on its way, which makes in-demuxer
> > > > > channel
> > > > > reordering uneeded. Therefore the reordering option should not
> > > > > be
> > > > > added
> > > > > as it is in this patch. I can rework the patch after the
> > > > > channel
> > > > > layout
> > > > > API is in. (should happen in a couple of weeks at most).
> > > > >
> > > > > Regards,
> > > > > Marton
> > > > >
> > > >
> > > > So it will happen only after the release 5 of FFMpeg right ?
> >
> > Not sure. There were people who wanted the merge the channel layout
> > api
> > before the release.
> >
> > > >
> > > > Is it possible to merge it, and we can rework it after the new
> > > > API is
> > > > released ?
> > > > Patches are related to IMF (new format) patches, and if FFmpeg
> > > > can
> > > > accept
> > > > IMF without MCA support it will generate a lot of errors in audio
> > > > mapping.
> > > > So even if it's not performant for now, is it possible to imagine
> > > > to
> > > > merge
> > > > patches and rework after ?
> > >
> > > I suspect this might create problems for the people writing the
> > > reordering API
> >
> > It is not matter of performance, we should not introduce a hack such
> > as
> > reordering PCM channels in a demuxer if there is a better solution on
> > the
> > horizon.

Yes, it feels like channel reordering should be a framework-level
feature and not a per-demuxer feature.

What about a roadmap where the channel-reordering-in-MXF patch is
scheduled to be merged after some reasonable time (1 month?) if the
channel API has not landed by then? This would allow contributors and
users to plan ahead.

> >
> > If this is urgent, we could merge it without reordering support.
>
> I think we can trust our users to maintain their own forks if they need
> special hacks
>
> /Tomas
>
> _______________________________________________
> ffmpeg-devel mailing list
> ffmpeg-devel@ffmpeg.org
> https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
>
> To unsubscribe, visit link above, or email
> ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".
_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel

To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".