From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTP id 6016A4423E for ; Mon, 3 Oct 2022 00:19:39 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id A4B2668BC12; Mon, 3 Oct 2022 03:19:37 +0300 (EEST) Received: from mail-pl1-f171.google.com (mail-pl1-f171.google.com [209.85.214.171]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id 7CA4968BBFE for ; Mon, 3 Oct 2022 03:19:30 +0300 (EEST) Received: by mail-pl1-f171.google.com with SMTP id x6so3073918pll.11 for ; Sun, 02 Oct 2022 17:19:30 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=sandflow-com.20210112.gappssmtp.com; s=20210112; h=content-transfer-encoding:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date; bh=6mQ/93EhK2hPvCD2+JUnWvheDQETmK/FdwrrTWXKVH8=; b=aIQ/TGDBnLlS6wQkYRIPyh1JeVsNDxuT6tg4Fg0LhpifpjKdc5ozqpMfHB6/iN30km rDMyh32ZNZRkfWme8pLKLm8zf+1PqrQDCOOtuyFtHx4DO66JeWFrVMh4A7ddzsW+lukI BtS1j1wNF10Wh9OM5YVOGzHX3lUCmGbb5G41iau2l7qnvdJPbxDQTH7RKsYS0su9txxh YGl4+sY6UjpqgFRWksRG9gVC/DRgGhA6RxDqlzo9oyz/9KpJ6WOFHUYu5D7iVSm/uXmF rQkaauwOeDAdC50uTD8TGYODunYQT5/kI9tYX7KgLXshNr4hL+CUjhdubFVO6XUmjmpE D1ow== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date; bh=6mQ/93EhK2hPvCD2+JUnWvheDQETmK/FdwrrTWXKVH8=; b=SzEQIWaSkTbvwn0r9jnpQoaMR61HWiWu2u+M6RI8rBGhyroq+vSMWHTa9L07MSi0xW hHBhSyu6jt8xe083dg7Qlwvi1gGO3UmJR8mZ8DdpDwldpbm4F4xGfWZXQ6FrcZ6P7HB4 wvBxXBwouebVG/mwSmqXaJ8AxlzGxDpxVzAxteAtBhhiAB3D6zHLZbh6YE7qZbLz5nhb ORiyPBtI0YMIUkMw4Ll09FhN9nY5vTlMs6lq8RPH0eMPv56B2j/vcEd/ULX/ptSn4gq7 8nhGr7bNYOriivm6ZXa/tI/J+anwQfSb6vg0+c47BGZBd+1lHI9+3w0yzv4gkf3yYGih uqmQ== X-Gm-Message-State: ACrzQf2YbpK4pn7pcpiB9SkMhZ5ReDSmXaejWMMw9QYKlAXlo0+3QM+v h4t47uUckrge9BEhtCn2IMW/LfwRl5RB6Q== X-Google-Smtp-Source: AMsMyM4Or1x0V2nQV55T1J84CSErdFn8IpaNVXK1pWd12pXPWgEeg4icbuEHH5BzX4vK8q1Nsz1wag== X-Received: by 2002:a17:902:7082:b0:177:f7fc:5290 with SMTP id z2-20020a170902708200b00177f7fc5290mr19048256plk.143.1664756360110; Sun, 02 Oct 2022 17:19:20 -0700 (PDT) Received: from mail-pj1-f44.google.com (mail-pj1-f44.google.com. [209.85.216.44]) by smtp.gmail.com with ESMTPSA id x21-20020a17090300d500b00176c431e7e2sm5850656plc.13.2022.10.02.17.19.17 for (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Sun, 02 Oct 2022 17:19:17 -0700 (PDT) Received: by mail-pj1-f44.google.com with SMTP id a5-20020a17090aa50500b002008eeb040eso10186032pjq.1 for ; Sun, 02 Oct 2022 17:19:17 -0700 (PDT) X-Received: by 2002:a17:902:e5c3:b0:178:192c:6b3b with SMTP id u3-20020a170902e5c300b00178192c6b3bmr20018718plf.92.1664756356599; Sun, 02 Oct 2022 17:19:16 -0700 (PDT) MIME-Version: 1.0 References: <20221002234755.3354-1-dev@rocha.red> <20221002234755.3354-2-dev@rocha.red> <81454a2b-417e-9ff3-36d1-c02b7be4271b@rothenpieler.org> In-Reply-To: <81454a2b-417e-9ff3-36d1-c02b7be4271b@rothenpieler.org> From: Pierre-Anthony Lemieux Date: Sun, 2 Oct 2022 17:19:04 -0700 X-Gmail-Original-Message-ID: Message-ID: To: FFmpeg development discussions and patches Subject: Re: [FFmpeg-devel] [PATCH 1/1] Enable building with WSL and MSVC X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: On Sun, Oct 2, 2022 at 5:14 PM Timo Rothenpieler wrote: > > On 03.10.2022 01:47, Julio C. Rocha wrote: > > --- > > configure | 7 ++++++- > > 1 file changed, 6 insertions(+), 1 deletion(-) > > > > diff --git a/configure b/configure > > index 6712d045d9..f5f5eb29dd 100755 > > --- a/configure > > +++ b/configure > > @@ -4847,7 +4847,12 @@ probe_cc(){ > > else > > _ident=$($_cc --version 2>/dev/null | head -n1 | tr -d '\r') > > fi > > - _DEPCMD='$(DEP$(1)) $(DEP$(1)FLAGS) $($(1)DEP_FLAGS) $< 2>&1 | awk '\''/including/ { sub(/^.*file: */, ""); gsub(/\\/, "/"); if (!match($$0, / /)) print "$@:", $$0 }'\'' > $(@:.o=.d)' > > + if [ "$(grep -i Microsoft /proc/version)" ]; then > > Not convinced that this is a good check. > I can think of a few other situations where Microsoft might appear in > there. Like, for example on one of their servers, Azure Cloud, Github > Actions and so on. > > > + # Windows Subsystem for Linux > > + _DEPCMD='$(DEP$(1)) $(DEP$(1)FLAGS) $($(1)DEP_FLAGS) $< 2>&1 | awk '\''/including/ { sub(/^.*file: */, ""); gsub(/\\/, "/"); if (!match($$0, / /)) { cmd="/usr/bin/wslpath \x27" $$0 "\x27"; cmd |& getline pth; print "$@:", pth } }'\'' > $(@:.o=.d)' > > + else > > + _DEPCMD='$(DEP$(1)) $(DEP$(1)FLAGS) $($(1)DEP_FLAGS) $< 2>&1 | awk '\''/including/ { sub(/^.*file: */, ""); gsub(/\\/, "/"); if (!match($$0, / /)) print "$@:", $$0 }'\'' > $(@:.o=.d)' > > + fi > > _DEPFLAGS='$(CPPFLAGS) $(CFLAGS) -showIncludes -Zs' > > _cflags_speed="-O2" > > _cflags_size="-O1" > > > What actual issue is this solving? > I've been building in WSL for years, including MSVC builds, and never > encountered any problems. FWIW. I am currently building on WSL: $ uname -a Linux pal-xxxxx 5.10.102.1-microsoft-standard-WSL2 #1 SMP Wed Mar 2 00:30:59 UTC 2022 x86_64 x86_64 x86_64 GNU/Linux $ lsb_release -a No LSB modules are available. Distributor ID: Ubuntu Description: Ubuntu 20.04.4 LTS Release: 20.04 Codename: focal > _______________________________________________ > ffmpeg-devel mailing list > ffmpeg-devel@ffmpeg.org > https://ffmpeg.org/mailman/listinfo/ffmpeg-devel > > To unsubscribe, visit link above, or email > ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe". _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".