Re: [FFmpeg-devel] [PATCH v9 00/13] Add vvc decoder

[Nuo Mi <nuomi2021@gmail.com>]

On Mon, Jan 1, 2024 at 11:50 PM Lynne <dev@lynne.ee> wrote:

> Jan 1, 2024, 16:26 by jamrial@gmail.com:
>
> > On 1/1/2024 12:16 PM, Lynne wrote:
> >
> >> Jan 1, 2024, 15:13 by nuomi2021@gmail.com:
> >>
> >>> libavcodec/vvc/Makefile              |   16 +
> >>>  libavcodec/vvc/vvc_cabac.c           | 2478 ++++++++++++++++++
> >>>  libavcodec/vvc/vvc_cabac.h           |  126 +
> >>>  libavcodec/vvc/vvc_ctu.c             | 2491 ++++++++++++++++++
> >>>  libavcodec/vvc/vvc_ctu.h             |  480 ++++
> >>>  libavcodec/vvc/vvc_data.c            | 3486 ++++++++++++++++++++++++++
> >>>  libavcodec/vvc/vvc_data.h            |   80 +
> >>>  libavcodec/vvc/vvc_filter.c          | 1332 ++++++++++
> >>>  libavcodec/vvc/vvc_filter.h          |   71 +
> >>>  libavcodec/vvc/vvc_filter_template.c | 1135 +++++++++
> >>>  libavcodec/vvc/vvc_inter.c           |  923 +++++++
> >>>  libavcodec/vvc/vvc_inter.h           |   42 +
> >>>  libavcodec/vvc/vvc_inter_template.c  | 1023 ++++++++
> >>>  libavcodec/vvc/vvc_intra.c           |  797 ++++++
> >>>  libavcodec/vvc/vvc_intra.h           |   49 +
> >>>  libavcodec/vvc/vvc_intra_template.c  | 1015 ++++++++
> >>>  libavcodec/vvc/vvc_itx_1d.c          |  708 ++++++
> >>>  libavcodec/vvc/vvc_itx_1d.h          |   52 +
> >>>  libavcodec/vvc/vvc_mvs.c             | 1798 +++++++++++++
> >>>  libavcodec/vvc/vvc_mvs.h             |   46 +
> >>>  libavcodec/vvc/vvc_ps.c              | 1150 +++++++++
> >>>  libavcodec/vvc/vvc_ps.h              |  263 ++
> >>>  libavcodec/vvc/vvc_refs.c            |  559 +++++
> >>>  libavcodec/vvc/vvc_refs.h            |   57 +
> >>>  libavcodec/vvc/vvc_thread.c          |  828 ++++++
> >>>  libavcodec/vvc/vvc_thread.h          |   36 +
> >>>  libavcodec/vvc/vvcdec.c              | 1017 ++++++++
> >>>  libavcodec/vvc/vvcdec.h              |  226 ++
> >>>  libavcodec/vvc/vvcdsp.c              |  141 ++
> >>>  libavcodec/vvc/vvcdsp.h              |  170 ++
> >>>  libavcodec/vvc/vvcdsp_template.c     |  120 +
> >>>
> >>
> >> We have larger decoders than this, could you just put all files in
> libavodec/?
> >>
> >
> > Was asked him to do it this way. Ideally, other codecs would follow
> after it, too.
>
Yeah, with over 1600+ files under libavcodec, even GitHub struggles to
fully list them.
This is not user-friendly for someone who wants to check the code in the
browser.

> >
>
> Sure.
> Future asm files should probably go into libavcodec/<arch>/vvc to avoid
> duplicating shared asm stuff and makefiles. Makes it disjointed, which
> is why I wanted to avoid it, but I don't mind it.
>
This is another story.
Arch-specific files are around 90+, and it may not be valuable to create
additional directories.
VVC can reuse 100% of inter-prediction and SAO code from HEVC with some
modifications. The challenge lies in deciding where to place the common
file if we have a separate file for VVC.

>
> We could switch to meson too, which would let us define generators and
> include directives that any component could use :)
> _______________________________________________
> ffmpeg-devel mailing list
> ffmpeg-devel@ffmpeg.org
> https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
>
> To unsubscribe, visit link above, or email
> ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".
>
_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel

To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".