Git Inbox Mirror of the ffmpeg-devel mailing list - see https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
 help / color / mirror / Atom feed
From: Nuo Mi <nuomi2021@gmail.com>
To: FFmpeg development discussions and patches <ffmpeg-devel@ffmpeg.org>
Subject: Re: [FFmpeg-devel] [PATCH] libavformat/vvc: Make probe more conservative
Date: Mon, 4 Dec 2023 13:25:18 +0800
Message-ID: <CAFXK13fuWTF=hd9xY5TJwDFDmxk5F6SFDA7kkyWnvsL5Mhey-A@mail.gmail.com> (raw)
In-Reply-To: <20231203181259.63298-1-post@frankplowman.com>

>
>                  return 0;
>
> -            if ((nal2 & 0x7) == 0) // nuh_temporal_id_plus1
> +            if (nuh_temporal_id_plus1 == 0) // nuh_temporal_id_plus1
> +                return 0;
> +            if (nuh_temporal_id_plus1 != 1 && (type >= VVC_IDR_W_RADL &&
> type <= VVC_RSV_IRAP_11
> +                                            || type == VVC_DCI_NUT ||
> type == VVC_OPI_NUT
> +                                            || type == VVC_VPS_NUT ||
> type == VVC_SPS_NUT
> +                                            || type == VVC_EOS_NUT ||
> type == VVC_EOB_NUT))
>
Hi Frank,
Thank you for the patch.
You can use a function for these two checks.

 if (!check_temporal_id(nal2 & 0x7, type))
    return 0


                 return 0;
>
>              switch (type) {
> --
> 2.43.0
>
> _______________________________________________
> ffmpeg-devel mailing list
> ffmpeg-devel@ffmpeg.org
> https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
>
> To unsubscribe, visit link above, or email
> ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".
>
_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel

To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".

  reply	other threads:[~2023-12-04  5:25 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-12-03 18:13 post
2023-12-04  5:25 ` Nuo Mi [this message]
2023-12-05  9:40 ` [FFmpeg-devel] [PATCH v2] " post

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='CAFXK13fuWTF=hd9xY5TJwDFDmxk5F6SFDA7kkyWnvsL5Mhey-A@mail.gmail.com' \
    --to=nuomi2021@gmail.com \
    --cc=ffmpeg-devel@ffmpeg.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

Git Inbox Mirror of the ffmpeg-devel mailing list - see https://ffmpeg.org/mailman/listinfo/ffmpeg-devel

This inbox may be cloned and mirrored by anyone:

	git clone --mirror https://master.gitmailbox.com/ffmpegdev/0 ffmpegdev/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 ffmpegdev ffmpegdev/ https://master.gitmailbox.com/ffmpegdev \
		ffmpegdev@gitmailbox.com
	public-inbox-index ffmpegdev

Example config snippet for mirrors.


AGPL code for this site: git clone https://public-inbox.org/public-inbox.git