From: Nuo Mi <nuomi2021@gmail.com>
To: FFmpeg development discussions and patches <ffmpeg-devel@ffmpeg.org>
Subject: Re: [FFmpeg-devel] [PATCH 4/4] lavc/vvc/refs: Use dpb_max_num_reorder_pics to control output
Date: Sat, 20 Apr 2024 11:48:14 +0800
Message-ID: <CAFXK13fqe4Ba08OZChkoNA9YNkX9dOfzF1YBKMbVmaeg0GT3rA@mail.gmail.com> (raw)
In-Reply-To: <20240419134711.3824735-4-mypopy@gmail.com>
Hi Barry and Eliny,
LGTM.
Thank you for the patch.
Is it possible to provide the clip so we can add it to our CI?
ci like https://github.com/ffvvc/FFmpeg/actions
On Fri, Apr 19, 2024 at 9:48 PM Jun Zhao <mypopy@gmail.com> wrote:
> From: Jun Zhao <mypopydev@gmail.com>
>
> Use dpb_max_num_reorder_pics to control output instead of
> dpb_max_dec_pic_buffering, when dpb_max_dec_pic_buffering
> is much larger than dpb_max_num_reorder_pics, it may cause
> dpb overflow error.
>
> Signed-off-by: Jun Zhao <barryjzhao@tencent.com>
> Signed-off-by: elinyhuang <elinyhuang@tencent.com>
> ---
> libavcodec/vvc/refs.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/libavcodec/vvc/refs.c b/libavcodec/vvc/refs.c
> index a5ee7338d6..6694bc4c51 100644
> --- a/libavcodec/vvc/refs.c
> +++ b/libavcodec/vvc/refs.c
> @@ -226,7 +226,7 @@ int ff_vvc_output_frame(VVCContext *s, VVCFrameContext
> *fc, AVFrame *out, const
>
> /* wait for more frames before output */
> if (!flush && s->seq_output == s->seq_decode && sps &&
> - nb_output <=
> sps->r->sps_dpb_params.dpb_max_dec_pic_buffering_minus1[sps->r->sps_max_sublayers_minus1]
> + 1)
> + nb_output <=
> sps->r->sps_dpb_params.dpb_max_num_reorder_pics[sps->r->sps_max_sublayers_minus1])
> return 0;
>
> if (nb_output) {
> --
> 2.25.1
>
> _______________________________________________
> ffmpeg-devel mailing list
> ffmpeg-devel@ffmpeg.org
> https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
>
> To unsubscribe, visit link above, or email
> ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".
>
_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".
next prev parent reply other threads:[~2024-04-20 3:48 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-04-19 13:47 [FFmpeg-devel] [PATCH 1/4] lavc/vvc_parser: Remove max_b_frames setting Jun Zhao
2024-04-19 13:47 ` [FFmpeg-devel] [PATCH 2/4] lavc/libxevd: Fixed the has_b_frames setting Jun Zhao
2024-04-19 13:47 ` [FFmpeg-devel] [PATCH 3/4] lavc/vvc_parser: " Jun Zhao
2024-04-20 3:49 ` Nuo Mi
2024-04-21 2:51 ` mypopy
2024-04-21 13:12 ` Nuo Mi
2024-04-19 13:47 ` [FFmpeg-devel] [PATCH 4/4] lavc/vvc/refs: Use dpb_max_num_reorder_pics to control output Jun Zhao
2024-04-20 3:48 ` Nuo Mi [this message]
2024-04-21 2:33 ` mypopy
2024-04-21 13:14 ` Nuo Mi
2024-04-20 3:51 ` [FFmpeg-devel] [PATCH 1/4] lavc/vvc_parser: Remove max_b_frames setting Nuo Mi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAFXK13fqe4Ba08OZChkoNA9YNkX9dOfzF1YBKMbVmaeg0GT3rA@mail.gmail.com \
--to=nuomi2021@gmail.com \
--cc=ffmpeg-devel@ffmpeg.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Git Inbox Mirror of the ffmpeg-devel mailing list - see https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
This inbox may be cloned and mirrored by anyone:
git clone --mirror https://master.gitmailbox.com/ffmpegdev/0 ffmpegdev/git/0.git
# If you have public-inbox 1.1+ installed, you may
# initialize and index your mirror using the following commands:
public-inbox-init -V2 ffmpegdev ffmpegdev/ https://master.gitmailbox.com/ffmpegdev \
ffmpegdev@gitmailbox.com
public-inbox-index ffmpegdev
Example config snippet for mirrors.
AGPL code for this site: git clone https://public-inbox.org/public-inbox.git