* [FFmpeg-devel] [PATCH] avcodec/vvcdec: decode extradata to support container formats
@ 2024-01-06 1:24 Nuo Mi
2024-01-06 1:27 ` Nuo Mi
0 siblings, 1 reply; 5+ messages in thread
From: Nuo Mi @ 2024-01-06 1:24 UTC (permalink / raw)
To: ffmpeg-devel; +Cc: Nuo Mi
For example:
wget https://www.elecard.com/storage/video/NovosobornayaSquare_1920x1080.mp4
./ffplay NovosobornayaSquare_1920x1080.mp4
---
libavcodec/vvc/vvcdec.c | 6 ++++++
1 file changed, 6 insertions(+)
diff --git a/libavcodec/vvc/vvcdec.c b/libavcodec/vvc/vvcdec.c
index 608d497cb7..54ada28124 100644
--- a/libavcodec/vvc/vvcdec.c
+++ b/libavcodec/vvc/vvcdec.c
@@ -977,6 +977,12 @@ static av_cold int vvc_decode_init(AVCodecContext *avctx)
if (ret)
return ret;
+ if (avctx->extradata_size > 0 && avctx->extradata) {
+ ret = ff_cbs_read_extradata_from_codec(s->cbc, &s->current_frame, avctx);
+ if (ret < 0)
+ return ret;
+ }
+
s->nb_fcs = (avctx->flags & AV_CODEC_FLAG_LOW_DELAY) ? 1 : delayed;
s->fcs = av_calloc(s->nb_fcs, sizeof(*s->fcs));
if (!s->fcs)
--
2.25.1
_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [FFmpeg-devel] [PATCH] avcodec/vvcdec: decode extradata to support container formats
2024-01-06 1:24 [FFmpeg-devel] [PATCH] avcodec/vvcdec: decode extradata to support container formats Nuo Mi
@ 2024-01-06 1:27 ` Nuo Mi
2024-01-06 1:31 ` James Almer
0 siblings, 1 reply; 5+ messages in thread
From: Nuo Mi @ 2024-01-06 1:27 UTC (permalink / raw)
To: ffmpeg-devel
On Sat, Jan 6, 2024 at 9:25 AM Nuo Mi <nuomi2021@gmail.com> wrote:
> For example:
> wget
> https://www.elecard.com/storage/video/NovosobornayaSquare_1920x1080.mp4
> ./ffplay NovosobornayaSquare_1920x1080.mp4
> ---
> libavcodec/vvc/vvcdec.c | 6 ++++++
> 1 file changed, 6 insertions(+)
>
> diff --git a/libavcodec/vvc/vvcdec.c b/libavcodec/vvc/vvcdec.c
> index 608d497cb7..54ada28124 100644
> --- a/libavcodec/vvc/vvcdec.c
> +++ b/libavcodec/vvc/vvcdec.c
> @@ -977,6 +977,12 @@ static av_cold int vvc_decode_init(AVCodecContext
> *avctx)
> if (ret)
> return ret;
>
> + if (avctx->extradata_size > 0 && avctx->extradata) {
> + ret = ff_cbs_read_extradata_from_codec(s->cbc, &s->current_frame,
> avctx);
> + if (ret < 0)
> + return ret;
> + }
> +
> s->nb_fcs = (avctx->flags & AV_CODEC_FLAG_LOW_DELAY) ? 1 : delayed;
> s->fcs = av_calloc(s->nb_fcs, sizeof(*s->fcs));
> if (!s->fcs)
> --
> 2.25.1
>
> Depends on
https://patchwork.ffmpeg.org/project/ffmpeg/patch/20231103095720.32426-3-thomas.ff@spin-digital.com/
_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [FFmpeg-devel] [PATCH] avcodec/vvcdec: decode extradata to support container formats
2024-01-06 1:27 ` Nuo Mi
@ 2024-01-06 1:31 ` James Almer
2024-01-06 2:10 ` Nuo Mi
0 siblings, 1 reply; 5+ messages in thread
From: James Almer @ 2024-01-06 1:31 UTC (permalink / raw)
To: ffmpeg-devel
On 1/5/2024 10:27 PM, Nuo Mi wrote:
> On Sat, Jan 6, 2024 at 9:25 AM Nuo Mi <nuomi2021@gmail.com> wrote:
>
>> For example:
>> wget
>> https://www.elecard.com/storage/video/NovosobornayaSquare_1920x1080.mp4
>> ./ffplay NovosobornayaSquare_1920x1080.mp4
>> ---
>> libavcodec/vvc/vvcdec.c | 6 ++++++
>> 1 file changed, 6 insertions(+)
>>
>> diff --git a/libavcodec/vvc/vvcdec.c b/libavcodec/vvc/vvcdec.c
>> index 608d497cb7..54ada28124 100644
>> --- a/libavcodec/vvc/vvcdec.c
>> +++ b/libavcodec/vvc/vvcdec.c
>> @@ -977,6 +977,12 @@ static av_cold int vvc_decode_init(AVCodecContext
>> *avctx)
>> if (ret)
>> return ret;
>>
>> + if (avctx->extradata_size > 0 && avctx->extradata) {
>> + ret = ff_cbs_read_extradata_from_codec(s->cbc, &s->current_frame,
>> avctx);
>> + if (ret < 0)
>> + return ret;
>> + }
>> +
>> s->nb_fcs = (avctx->flags & AV_CODEC_FLAG_LOW_DELAY) ? 1 : delayed;
>> s->fcs = av_calloc(s->nb_fcs, sizeof(*s->fcs));
>> if (!s->fcs)
>> --
>> 2.25.1
LGTM
>>
>> Depends on
> https://patchwork.ffmpeg.org/project/ffmpeg/patch/20231103095720.32426-3-thomas.ff@spin-digital.com/
I don't see why this depends on that patch. Decoder and muxer are two
separate things.
_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [FFmpeg-devel] [PATCH] avcodec/vvcdec: decode extradata to support container formats
2024-01-06 1:31 ` James Almer
@ 2024-01-06 2:10 ` Nuo Mi
2024-01-07 1:12 ` Nuo Mi
0 siblings, 1 reply; 5+ messages in thread
From: Nuo Mi @ 2024-01-06 2:10 UTC (permalink / raw)
To: FFmpeg development discussions and patches
On Sat, Jan 6, 2024 at 9:32 AM James Almer <jamrial@gmail.com> wrote:
> On 1/5/2024 10:27 PM, Nuo Mi wrote:
> > On Sat, Jan 6, 2024 at 9:25 AM Nuo Mi <nuomi2021@gmail.com> wrote:
> >
> >> For example:
> >> wget
> >> https://www.elecard.com/storage/video/NovosobornayaSquare_1920x1080.mp4
> >> ./ffplay NovosobornayaSquare_1920x1080.mp4
> >> ---
> >> libavcodec/vvc/vvcdec.c | 6 ++++++
> >> 1 file changed, 6 insertions(+)
> >>
> >> diff --git a/libavcodec/vvc/vvcdec.c b/libavcodec/vvc/vvcdec.c
> >> index 608d497cb7..54ada28124 100644
> >> --- a/libavcodec/vvc/vvcdec.c
> >> +++ b/libavcodec/vvc/vvcdec.c
> >> @@ -977,6 +977,12 @@ static av_cold int vvc_decode_init(AVCodecContext
> >> *avctx)
> >> if (ret)
> >> return ret;
> >>
> >> + if (avctx->extradata_size > 0 && avctx->extradata) {
> >> + ret = ff_cbs_read_extradata_from_codec(s->cbc,
> &s->current_frame,
> >> avctx);
> >> + if (ret < 0)
> >> + return ret;
> >> + }
> >> +
> >> s->nb_fcs = (avctx->flags & AV_CODEC_FLAG_LOW_DELAY) ? 1 :
> delayed;
> >> s->fcs = av_calloc(s->nb_fcs, sizeof(*s->fcs));
> >> if (!s->fcs)
> >> --
> >> 2.25.1
>
> LGTM
>
> >>
> >> Depends on
> >
> https://patchwork.ffmpeg.org/project/ffmpeg/patch/20231103095720.32426-3-thomas.ff@spin-digital.com/
>
> I don't see why this depends on that patch. Decoder and muxer are two
> separate things.
Thank you. I'll push it tomorrow if there are no objections.
Yes, we can push it separately, but the user needs the demux patch to
decode MP4 files. Just want to call out it :)
>
_______________________________________________
> ffmpeg-devel mailing list
> ffmpeg-devel@ffmpeg.org
> https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
>
> To unsubscribe, visit link above, or email
> ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".
>
_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [FFmpeg-devel] [PATCH] avcodec/vvcdec: decode extradata to support container formats
2024-01-06 2:10 ` Nuo Mi
@ 2024-01-07 1:12 ` Nuo Mi
0 siblings, 0 replies; 5+ messages in thread
From: Nuo Mi @ 2024-01-07 1:12 UTC (permalink / raw)
To: FFmpeg development discussions and patches
On Sat, Jan 6, 2024 at 10:10 AM Nuo Mi <nuomi2021@gmail.com> wrote:
>
>
> On Sat, Jan 6, 2024 at 9:32 AM James Almer <jamrial@gmail.com> wrote:
>
>> On 1/5/2024 10:27 PM, Nuo Mi wrote:
>> > On Sat, Jan 6, 2024 at 9:25 AM Nuo Mi <nuomi2021@gmail.com> wrote:
>> >
>> >> For example:
>> >> wget
>> >>
>> https://www.elecard.com/storage/video/NovosobornayaSquare_1920x1080.mp4
>> >> ./ffplay NovosobornayaSquare_1920x1080.mp4
>> >> ---
>> >> libavcodec/vvc/vvcdec.c | 6 ++++++
>> >> 1 file changed, 6 insertions(+)
>> >>
>> >> diff --git a/libavcodec/vvc/vvcdec.c b/libavcodec/vvc/vvcdec.c
>> >> index 608d497cb7..54ada28124 100644
>> >> --- a/libavcodec/vvc/vvcdec.c
>> >> +++ b/libavcodec/vvc/vvcdec.c
>> >> @@ -977,6 +977,12 @@ static av_cold int vvc_decode_init(AVCodecContext
>> >> *avctx)
>> >> if (ret)
>> >> return ret;
>> >>
>> >> + if (avctx->extradata_size > 0 && avctx->extradata) {
>> >> + ret = ff_cbs_read_extradata_from_codec(s->cbc,
>> &s->current_frame,
>> >> avctx);
>> >> + if (ret < 0)
>> >> + return ret;
>> >> + }
>> >> +
>> >> s->nb_fcs = (avctx->flags & AV_CODEC_FLAG_LOW_DELAY) ? 1 :
>> delayed;
>> >> s->fcs = av_calloc(s->nb_fcs, sizeof(*s->fcs));
>> >> if (!s->fcs)
>> >> --
>> >> 2.25.1
>>
>> LGTM
>>
>
>> >>
>> >> Depends on
>> >
>> https://patchwork.ffmpeg.org/project/ffmpeg/patch/20231103095720.32426-3-thomas.ff@spin-digital.com/
>>
>> I don't see why this depends on that patch. Decoder and muxer are two
>> separate things.
>
> Thank you. I'll push it tomorrow if there are no objections.
>
Pushed.
> Yes, we can push it separately, but the user needs the demux patch to
> decode MP4 files. Just want to call out it :)
>
>>
>
> _______________________________________________
>> ffmpeg-devel mailing list
>> ffmpeg-devel@ffmpeg.org
>> https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
>>
>> To unsubscribe, visit link above, or email
>> ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".
>>
>
_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2024-01-07 1:12 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2024-01-06 1:24 [FFmpeg-devel] [PATCH] avcodec/vvcdec: decode extradata to support container formats Nuo Mi
2024-01-06 1:27 ` Nuo Mi
2024-01-06 1:31 ` James Almer
2024-01-06 2:10 ` Nuo Mi
2024-01-07 1:12 ` Nuo Mi
Git Inbox Mirror of the ffmpeg-devel mailing list - see https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
This inbox may be cloned and mirrored by anyone:
git clone --mirror https://master.gitmailbox.com/ffmpegdev/0 ffmpegdev/git/0.git
# If you have public-inbox 1.1+ installed, you may
# initialize and index your mirror using the following commands:
public-inbox-init -V2 ffmpegdev ffmpegdev/ https://master.gitmailbox.com/ffmpegdev \
ffmpegdev@gitmailbox.com
public-inbox-index ffmpegdev
Example config snippet for mirrors.
AGPL code for this site: git clone https://public-inbox.org/public-inbox.git