From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTP id 81F4246C4F for ; Sat, 6 Apr 2024 05:04:08 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id 3222368CA9C; Sat, 6 Apr 2024 08:04:05 +0300 (EEST) Received: from mail-lj1-f171.google.com (mail-lj1-f171.google.com [209.85.208.171]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id D032B68C25D for ; Sat, 6 Apr 2024 08:03:58 +0300 (EEST) Received: by mail-lj1-f171.google.com with SMTP id 38308e7fff4ca-2d476d7972aso36659821fa.1 for ; Fri, 05 Apr 2024 22:03:58 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1712379838; x=1712984638; darn=ffmpeg.org; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date:message-id:reply-to; bh=MDgmk/dK4iepuTLv0hZ1It6bAx+PXl+vNmMXCJHanWI=; b=EViUVKc2edgS5Sr9D3w22hKb4CRCUShvm2KQzp56rixKigJPHyc2c/UpzNY7XOPIbP dSCIsFb1pnLy+4hXQgdqNEkiEmpqYw/gqxnnWwKLOgbDOWSfNPdYGEr0241kaYrSbMcZ KSmHNVbLYM/JVZpKcggIjV+lk9WfNBydMQelmG6DE2H3yGfws2ipn6MhySxMNNXg4ieN QCJvJ+A+Dvf1v6eR33CSCJTtr3/vPMKat0Xm8WSnnWm3K2aPHMpvrUO3c6AXLC3hClAH /XL4cUqC3wS8sWjTjbKyv2tXIMIGTJUPy2ruuH9beCnj1O/XwDw4ZuJzggbC2xdmd3PA Q1HQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1712379838; x=1712984638; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=MDgmk/dK4iepuTLv0hZ1It6bAx+PXl+vNmMXCJHanWI=; b=f++a/yGmlsPdHMTn6lHQaHFuKTNCbl6H8fitpeDeaVZmER9spv7cGi3cj/KflJxGnP QFSsnAEj8bOo3K5xSlvBx1PrExwOpXT8ujP8FNqeqYBOiBStnzLEMeL1Yj3JKP1iA3xp HewP0TnD6oPNrQwOSzucBzjRbXBwby2UtjV+/jwBs1j3ZKFViNVAjuIFQHRPvMsJGRun PNPAhRoLp/UBR9Ri9LD4SeMqg2LMJS43z33/FfK0OlyOhNeAAnZd6JYbJFUHDYkw/ClG 5cVgqIaTqQtMt6hnAk44JETkdUBJwfQj0D71oi/BFEwOV1HdJUkJbwIDBIYQvLyD5pyB +7RA== X-Gm-Message-State: AOJu0YxSJHHNjt89rGTm5ftYAGStND4jH7hM6bPYlb6rutOGPakI9FKC I9wsCvv3r5HSW1f9BP7ysZeMFudEg1kSdlA45MQaZGCn5MqPjJAI7gnpGH5EtKmSWo/Qltbzac3 stGQhTH6XBf+vUt+R/9tAlsuJkvo= X-Google-Smtp-Source: AGHT+IHDVxlhAnJOjfDkEiW7EdlMFrflZADYc4U6r1zefDGh6w3o5tg/naPtR6quDX6d5B0lpYRstojyxeP15yE7kmc= X-Received: by 2002:a2e:914b:0:b0:2d8:4897:39a0 with SMTP id q11-20020a2e914b000000b002d8489739a0mr2485215ljg.15.1712379837358; Fri, 05 Apr 2024 22:03:57 -0700 (PDT) MIME-Version: 1.0 References: <20240328012631.777476-1-fei.w.wang@intel.com> <20240328012631.777476-7-fei.w.wang@intel.com> In-Reply-To: From: Nuo Mi Date: Sat, 6 Apr 2024 13:03:49 +0800 Message-ID: To: "Wang, Fei W" X-Content-Filtered-By: Mailman/MimeDel 2.1.29 Subject: Re: [FFmpeg-devel] [PATCH v1 7/7] lavc/vaapi_dec: Add VVC decoder X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Cc: "ffmpeg-devel@ffmpeg.org" Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: > > > > --- a/libavcodec/vaapi_decode.c > > > +++ b/libavcodec/vaapi_decode.c > > > @@ -455,6 +455,9 @@ static const struct { > > > MAP(AV1, AV1_MAIN, AV1Profile0), > > > MAP(AV1, AV1_HIGH, AV1Profile1), > > > #endif > > > +#if VA_CHECK_VERSION(1, 22, 0) > > > + MAP(H266, VVC_MAIN_10, VVCMain10), > > > +#endif > > > > > > #undef MAP > > > }; > > > @@ -627,6 +630,10 @@ static int > > > vaapi_decode_make_config(AVCodecContext *avctx, > > > case AV_CODEC_ID_VP8: > > > frames->initial_pool_size += 3; > > > break; > > > + case AV_CODEC_ID_H266: > > > + // Add additional 16 for maximum 16 frames delay in > > > vvc native decode. > > > + frames->initial_pool_size += 32; > > > > One frame of 8k YUV444, 10 bits, is about 200MB. Thirty-two frames > > amount to approximately 6GB.Can we dynamically allocate the buffer > > pool? > > It's processing in other thread: > https://patchwork.ffmpeg.org/project/ffmpeg/list/?series=11316 > > > > > The software decoder requires a delay of 16 frames to ensure full > > utilization of CPUs. In the future, we may consider increasing this > > to 32 or even 64 frames. > > However, for hardware decoding, given that all processing occurs on > > the GPU, we do not require any delay. > > The delay can avoid sync hardware task immediately once it is > submitted, which can avoid hardware switch tasks frequently and drop > performance. If the number will increase, I'd prefer to set it as an > option and diff the default value for hardware with software. Why does VVC require such a large frame pool while other hardware codecs do not? What makes VVC so special?" _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".