From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTP id E6D8D40F4A for ; Tue, 10 Jan 2023 02:56:39 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id AEE4868BA1C; Tue, 10 Jan 2023 04:56:36 +0200 (EET) Received: from mail-lf1-f50.google.com (mail-lf1-f50.google.com [209.85.167.50]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id ABAE768B7F1 for ; Tue, 10 Jan 2023 04:56:30 +0200 (EET) Received: by mail-lf1-f50.google.com with SMTP id y25so16166772lfa.9 for ; Mon, 09 Jan 2023 18:56:30 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date:message-id:reply-to; bh=Aeop1DNUifzjVjMYounn9bf+ENNlbm0uUoUFJ7Py4sw=; b=mI1aSEi/8vHVIHHgNlL7y7Pl8eTm0naK3W8MRrt2tktSxRgMbIzR2QMGlwU4GRB6P2 wQfynM5/R7uWYvHVQB+DtEp8RfHpYlX3lw7g61JtQvDAWTLsZfaD8nelw/e4k3oHjf2b B5Oo9j2rGfTURi/PKhodU1hi4Wid2FdHp4l/y5GiWcQRiCkNMWdYq4JTG96FoYCtIgKo qtBm5C39N3JpnDvv1z+t0bhqPLED8JPFyn3Hs2W7420J6T6CsF01LyAv5G+pXPR1kISC YjK7BhPVqHpkuep4aOJyVQIxrb4Kzv+iGVG2bCY8pCQcNnz1a+ZoJ+8A7u+k+PvNqN73 6A9w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=Aeop1DNUifzjVjMYounn9bf+ENNlbm0uUoUFJ7Py4sw=; b=Lv9h5yUikdzRTX/ZbPLRrbCiQbFmN22HoGQ0+CvaCs1Yk5r9HnUmrpPvjmWz/uxLPh FiZZ4iAgINLY81kKUsbgH9pEsr4lMd4V4DR3l428h/14sOlJYdI+GWmwbKI7n0rc59AQ o+bGuPsrwUKtxc6zF/lTI6wxh1GEPRznI2U9zSumo/IRQmC7fAWdZz0s+EwHQKXi5OM6 hMAx/zi4iCJmvWUec9TYILKwZa7AwRPMxPowjB9p9P2OFEGF1Fyq4XmBL6FPveOiRekC wEGy8ITKZtzOz2gln8EdY2IlzQPX/E0eBo3xUt7vgvY/7nMoB7hVEqw//KzgPmgkQDBv jLwg== X-Gm-Message-State: AFqh2kqX2ce1PgZz46rAuI4lKx6wUiM/MX2cXAMclGkL11d+rUp0bt0F SxKDPjs+9MMb7S36V2Ojy+/jMJSuKot/zKb9igQ= X-Google-Smtp-Source: AMrXdXsf3CG+lKsJiu7HOHSZ/dT2hEgepHpEhFuetluaKSFSTSyGTgCIDHdj2IARpsTHAKK8HRQfg2RmmtZnhYAZZFo= X-Received: by 2002:a19:ac05:0:b0:4cc:77d3:51b3 with SMTP id g5-20020a19ac05000000b004cc77d351b3mr1052247lfc.391.1673319389776; Mon, 09 Jan 2023 18:56:29 -0800 (PST) MIME-Version: 1.0 References: <20221019072508.23460-1-thomas.ff@spin-digital.com> In-Reply-To: From: Nuo Mi Date: Tue, 10 Jan 2023 10:56:18 +0800 Message-ID: To: Thomas Siedel X-Content-Filtered-By: Mailman/MimeDel 2.1.29 Subject: Re: [FFmpeg-devel] [PATCH v1 00/11] Add support for H266/VVC X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Cc: FFmpeg development discussions and patches Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: Hi Thomas It works for me. BTW, I will send out a C version of VVC native decoder very soon. Please also help review and improve it. Thank you. On Tue, Jan 3, 2023 at 10:02 PM Thomas Siedel wrote: > On Thu, 15 Dec 2022 at 10:11, Thomas Siedel > wrote: > >> On Tue, 13 Dec 2022 at 07:19, Nuo Mi wrote: >> >>> Hi Thomas, >>> Thank you for sending the patch set. >>> It seems the patchset is based on >>> https://patchwork.ffmpeg.org/project/ffmpeg/list/?series=3487 >>> Please do not change the author's name. >>> >>> thank you >>> >> >> Some code regarding VVC parsing is based on another FFmpeg fork. This >> fork had been based on your patch set, it seems. >> On top of this, I did additional modifications to the parsing code and >> added the other code regarding format support and the decoder and encoder >> integration. >> >> It was not my intent to hide you as an author of the parsing code. >> Your patch set has been in an unmerged state for over 1.5 years now >> without new progress, so I assumed that these patches are kind of >> discontinued. >> Therefore I started submitting my own patchset to get VVC integrated into >> FFmpeg. >> I kept your original copyright notices in libavformat/vvcdec.c and >> livavcodec/vvc_parser.c. >> Apart from this, I am not sure how / where else this could be documented >> and how other authors can be appropriately referenced. >> >> Could you explain in more detail what you mean by changing the author's >> name? >> Do you have any suggestions on what to do in this case or how to change >> it? >> >> > I just submitted a new version of the patch set. > Among other changes, I now put you as the author of the first three > patches, as most of their content is based on your original patch set. > I made some modifications to them, so I added myself as a co-author. > For patches 4 and 5, I put you as the co-author because some of their > content is based on your original patch set, but only to a smaller extent. > All other patches are independent. > > I hope that this solution is OK for you. If not, please let me know. > > >> >> On Wed, Oct 19, 2022 at 3:26 PM wrote: >>> >>>> From: Thomas Siedel >>>> >>>> This patch set adds H266/VVC support. >>>> This includes parsing, muxing, demuxing, decoding and encoding. >>>> Decoding is done using the external library VVdeC >>>> (https://github.com/fraunhoferhhi/vvdec.git) and can be enabled with >>>> --enable-libvvdec. >>>> Encoding is done using the external library VVenC >>>> (https://github.com/fraunhoferhhi/vvenc.git) and can be enabled with >>>> --enable-libvvenc. >>>> >>>> Thomas Siedel (11): >>>> avcodec: add enum types for H266/VVC >>>> avcodec: add cbs for H266/VVC >>>> avcodec: enable cbs for H266/VVC >>>> avcodec: add bitstream parser for H266/VVC >>>> avcodec: add MP4 to annexb support for H266/VVC >>>> avformat: add demuxer and probe support for H266/VVC >>>> avformat: add muxer support for H266/VVC >>>> avcodec: add external decoder libvvdec for H266/VVC >>>> avcodec: add external encoder libvvenc for H266/VVC >>>> avformat: add ts stream types for H266/VVC >>>> avcodec: increase minor version for H266/VVC >>>> >>>> configure | 16 +- >>>> libavcodec/Makefile | 6 + >>>> libavcodec/allcodecs.c | 2 + >>>> libavcodec/bitstream_filters.c | 2 + >>>> libavcodec/cbs.c | 6 + >>>> libavcodec/cbs_h2645.c | 384 +++- >>>> libavcodec/cbs_h266.h | 791 +++++++ >>>> libavcodec/cbs_h266_syntax_template.c | 3010 +++++++++++++++++++++++++ >>>> libavcodec/cbs_internal.h | 3 +- >>>> libavcodec/cbs_sei.c | 29 + >>>> libavcodec/h2645_parse.c | 71 +- >>>> libavcodec/h266_metadata_bsf.c | 145 ++ >>>> libavcodec/libvvdec.c | 511 +++++ >>>> libavcodec/libvvenc.c | 432 ++++ >>>> libavcodec/parsers.c | 1 + >>>> libavcodec/version.h | 2 +- >>>> libavcodec/vvc.h | 142 ++ >>>> libavcodec/vvc_mp4toannexb_bsf.c | 318 +++ >>>> libavcodec/vvc_paramset.c | 972 ++++++++ >>>> libavcodec/vvc_paramset.h | 429 ++++ >>>> libavcodec/vvc_parse_extradata.c | 241 ++ >>>> libavcodec/vvc_parse_extradata.h | 36 + >>>> libavcodec/vvc_parser.c | 588 +++++ >>>> libavformat/Makefile | 8 +- >>>> libavformat/allformats.c | 2 + >>>> libavformat/demux.c | 7 +- >>>> libavformat/isom.c | 1 + >>>> libavformat/isom_tags.c | 3 + >>>> libavformat/mov.c | 6 + >>>> libavformat/movenc.c | 41 +- >>>> libavformat/mpeg.c | 3 + >>>> libavformat/mpeg.h | 1 + >>>> libavformat/mpegts.c | 2 + >>>> libavformat/mpegts.h | 1 + >>>> libavformat/mpegtsenc.c | 65 + >>>> libavformat/rawenc.c | 23 + >>>> libavformat/vvc.c | 918 ++++++++ >>>> libavformat/vvc.h | 99 + >>>> libavformat/vvcdec.c | 61 + >>>> 39 files changed, 9366 insertions(+), 12 deletions(-) >>>> create mode 100644 libavcodec/cbs_h266.h >>>> create mode 100644 libavcodec/cbs_h266_syntax_template.c >>>> create mode 100644 libavcodec/h266_metadata_bsf.c >>>> create mode 100644 libavcodec/libvvdec.c >>>> create mode 100644 libavcodec/libvvenc.c >>>> create mode 100644 libavcodec/vvc.h >>>> create mode 100644 libavcodec/vvc_mp4toannexb_bsf.c >>>> create mode 100644 libavcodec/vvc_paramset.c >>>> create mode 100644 libavcodec/vvc_paramset.h >>>> create mode 100644 libavcodec/vvc_parse_extradata.c >>>> create mode 100644 libavcodec/vvc_parse_extradata.h >>>> create mode 100644 libavcodec/vvc_parser.c >>>> create mode 100644 libavformat/vvc.c >>>> create mode 100644 libavformat/vvc.h >>>> create mode 100644 libavformat/vvcdec.c >>>> >>>> -- >>>> 2.25.1 >>>> >>>> _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".