From: Nuo Mi <nuomi2021@gmail.com>
To: FFmpeg development discussions and patches <ffmpeg-devel@ffmpeg.org>
Subject: Re: [FFmpeg-devel] [PATCH 1/2] avutil/executor: Allowing thread_count be zero
Date: Tue, 25 Jun 2024 20:36:33 +0800
Message-ID: <CAFXK13du_0ewVFm74VjOJGRzRyNsE-q9DFUiOkHGHXWhEif6dQ@mail.gmail.com> (raw)
In-Reply-To: <tencent_FF44F3E5B36C75DAC90DEEA7255073030805@qq.com>
On Mon, Jun 24, 2024 at 12:48 PM Zhao Zhili <quinkblack@foxmail.com> wrote:
> From: Zhao Zhili <zhilizhao@tencent.com>
>
> Before the patch, disable threads support at configure/build time
> was the only method to force zero thread in executor. However,
> it's common practice for libavcodec to run on caller's thread when
> user specify thread number to one. And for WASM environment, whether
> threads are supported needs to be detected at runtime. So executor
> should support zero thread at runtime.
>
> A single thread executor can be useful, e.g., to handle network
> protocol. So we can't take thread_count one as zero thread, which
> disabled a valid usercase.
>
> Other libraries take -threads 0 to mean auto. Executor as a low
> level utils doesn't do cpu detect. So take thread_count zero as
> zero thread, literally.
>
> Signed-off-by: Zhao Zhili <zhilizhao@tencent.com>
>
Hi Zhili,
Thank you for the v2
I will merge it in 3 days if there are no objections.
_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".
next prev parent reply other threads:[~2024-06-25 12:36 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-06-24 4:47 Zhao Zhili
2024-06-25 12:36 ` Nuo Mi [this message]
2024-06-27 12:57 ` Nuo Mi
-- strict thread matches above, loose matches on Subject: below --
2024-06-17 5:19 Zhao Zhili
2024-06-17 7:05 ` Anton Khirnov
2024-06-17 7:21 ` Paul B Mahol
2024-06-17 8:02 ` Zhao Zhili
2024-06-17 8:45 ` Hendrik Leppkes
2024-06-17 9:27 ` Zhao Zhili
2024-06-18 11:50 ` Nuo Mi
2024-06-18 12:05 ` Steven Liu
2024-06-19 8:40 ` Nuo Mi
2024-06-19 10:39 ` Steven Liu
2024-06-18 14:23 ` Zhao Zhili
2024-06-19 8:51 ` Nuo Mi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAFXK13du_0ewVFm74VjOJGRzRyNsE-q9DFUiOkHGHXWhEif6dQ@mail.gmail.com \
--to=nuomi2021@gmail.com \
--cc=ffmpeg-devel@ffmpeg.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Git Inbox Mirror of the ffmpeg-devel mailing list - see https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
This inbox may be cloned and mirrored by anyone:
git clone --mirror https://master.gitmailbox.com/ffmpegdev/0 ffmpegdev/git/0.git
# If you have public-inbox 1.1+ installed, you may
# initialize and index your mirror using the following commands:
public-inbox-init -V2 ffmpegdev ffmpegdev/ https://master.gitmailbox.com/ffmpegdev \
ffmpegdev@gitmailbox.com
public-inbox-index ffmpegdev
Example config snippet for mirrors.
AGPL code for this site: git clone https://public-inbox.org/public-inbox.git