* [FFmpeg-devel] [PATCH 1/2] avcodec/vvc: Remove NOP condition check in alf_filter_luma
@ 2024-07-16 2:49 Zhao Zhili
2024-07-16 12:31 ` Nuo Mi
0 siblings, 1 reply; 5+ messages in thread
From: Zhao Zhili @ 2024-07-16 2:49 UTC (permalink / raw)
To: ffmpeg-devel; +Cc: Zhao Zhili
From: Zhao Zhili <zhilizhao@tencent.com>
If (y + i == vb_above) or (y + i == vb_below), the if body has no
operation.
---
libavcodec/vvc/filter_template.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/libavcodec/vvc/filter_template.c b/libavcodec/vvc/filter_template.c
index 9b3a0e46f7..32777452b7 100644
--- a/libavcodec/vvc/filter_template.c
+++ b/libavcodec/vvc/filter_template.c
@@ -77,7 +77,7 @@ static void FUNC(alf_filter_luma)(uint8_t *_dst, ptrdiff_t dst_stride, const uin
const int is_near_vb_below = (y + i >= vb_pos) && (y + i <= vb_pos);
const int is_near_vb = is_near_vb_above || is_near_vb_below;
- if ((y + i < vb_pos) && ((y + i) >= vb_above)) {
+ if ((y + i < vb_pos) && ((y + i) > vb_above)) {
p1 = (y + i == vb_pos - 1) ? p0 : p1;
p3 = (y + i >= vb_pos - 2) ? p1 : p3;
p5 = (y + i >= vb_pos - 3) ? p3 : p5;
@@ -85,7 +85,7 @@ static void FUNC(alf_filter_luma)(uint8_t *_dst, ptrdiff_t dst_stride, const uin
p2 = (y + i == vb_pos - 1) ? p0 : p2;
p4 = (y + i >= vb_pos - 2) ? p2 : p4;
p6 = (y + i >= vb_pos - 3) ? p4 : p6;
- } else if ((y + i >= vb_pos) && ((y + i) <= vb_below)) {
+ } else if ((y + i >= vb_pos) && ((y + i) < vb_below)) {
p2 = (y + i == vb_pos ) ? p0 : p2;
p4 = (y + i <= vb_pos + 1) ? p2 : p4;
p6 = (y + i <= vb_pos + 2) ? p4 : p6;
--
2.42.0
_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [FFmpeg-devel] [PATCH 1/2] avcodec/vvc: Remove NOP condition check in alf_filter_luma
2024-07-16 2:49 [FFmpeg-devel] [PATCH 1/2] avcodec/vvc: Remove NOP condition check in alf_filter_luma Zhao Zhili
@ 2024-07-16 12:31 ` Nuo Mi
2024-07-16 16:07 ` Zhao Zhili
0 siblings, 1 reply; 5+ messages in thread
From: Nuo Mi @ 2024-07-16 12:31 UTC (permalink / raw)
To: FFmpeg development discussions and patches; +Cc: Zhao Zhili
On Tue, Jul 16, 2024 at 10:50 AM Zhao Zhili <quinkblack@foxmail.com> wrote:
> From: Zhao Zhili <zhilizhao@tencent.com>
>
> If (y + i == vb_above) or (y + i == vb_below), the if body has no
> operation.
>
👍, How did you find this? From a compiler warning or by reading the code?
> ---
> libavcodec/vvc/filter_template.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/libavcodec/vvc/filter_template.c
> b/libavcodec/vvc/filter_template.c
> index 9b3a0e46f7..32777452b7 100644
> --- a/libavcodec/vvc/filter_template.c
> +++ b/libavcodec/vvc/filter_template.c
> @@ -77,7 +77,7 @@ static void FUNC(alf_filter_luma)(uint8_t *_dst,
> ptrdiff_t dst_stride, const uin
> const int is_near_vb_below = (y + i >= vb_pos) && (y + i
> <= vb_pos);
> const int is_near_vb = is_near_vb_above ||
> is_near_vb_below;
>
> - if ((y + i < vb_pos) && ((y + i) >= vb_above)) {
> + if ((y + i < vb_pos) && ((y + i) > vb_above)) {
> p1 = (y + i == vb_pos - 1) ? p0 : p1;
> p3 = (y + i >= vb_pos - 2) ? p1 : p3;
> p5 = (y + i >= vb_pos - 3) ? p3 : p5;
> @@ -85,7 +85,7 @@ static void FUNC(alf_filter_luma)(uint8_t *_dst,
> ptrdiff_t dst_stride, const uin
> p2 = (y + i == vb_pos - 1) ? p0 : p2;
> p4 = (y + i >= vb_pos - 2) ? p2 : p4;
> p6 = (y + i >= vb_pos - 3) ? p4 : p6;
> - } else if ((y + i >= vb_pos) && ((y + i) <= vb_below)) {
> + } else if ((y + i >= vb_pos) && ((y + i) < vb_below)) {
> p2 = (y + i == vb_pos ) ? p0 : p2;
> p4 = (y + i <= vb_pos + 1) ? p2 : p4;
> p6 = (y + i <= vb_pos + 2) ? p4 : p6;
> --
> 2.42.0
>
> _______________________________________________
> ffmpeg-devel mailing list
> ffmpeg-devel@ffmpeg.org
> https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
>
> To unsubscribe, visit link above, or email
> ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".
>
_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [FFmpeg-devel] [PATCH 1/2] avcodec/vvc: Remove NOP condition check in alf_filter_luma
2024-07-16 12:31 ` Nuo Mi
@ 2024-07-16 16:07 ` Zhao Zhili
2024-07-16 16:17 ` Zhao Zhili
0 siblings, 1 reply; 5+ messages in thread
From: Zhao Zhili @ 2024-07-16 16:07 UTC (permalink / raw)
To: FFmpeg development discussions and patches
> On Jul 16, 2024, at 20:31, Nuo Mi <nuomi2021@gmail.com> wrote:
>
> On Tue, Jul 16, 2024 at 10:50 AM Zhao Zhili <quinkblack@foxmail.com <mailto:quinkblack@foxmail.com>> wrote:
>
>> From: Zhao Zhili <zhilizhao@tencent.com <mailto:zhilizhao@tencent.com>>
>>
>> If (y + i == vb_above) or (y + i == vb_below), the if body has no
>> operation.
>>
> 👍, How did you find this? From a compiler warning or by reading the code?
There is compiler warning. I found this issue when trying to simplify the logic
before rewrite in ARM assembly.
>
>
>> ---
>> libavcodec/vvc/filter_template.c | 4 ++--
>> 1 file changed, 2 insertions(+), 2 deletions(-)
>>
>> diff --git a/libavcodec/vvc/filter_template.c
>> b/libavcodec/vvc/filter_template.c
>> index 9b3a0e46f7..32777452b7 100644
>> --- a/libavcodec/vvc/filter_template.c
>> +++ b/libavcodec/vvc/filter_template.c
>> @@ -77,7 +77,7 @@ static void FUNC(alf_filter_luma)(uint8_t *_dst,
>> ptrdiff_t dst_stride, const uin
>> const int is_near_vb_below = (y + i >= vb_pos) && (y + i
>> <= vb_pos);
>> const int is_near_vb = is_near_vb_above ||
>> is_near_vb_below;
>>
>> - if ((y + i < vb_pos) && ((y + i) >= vb_above)) {
>> + if ((y + i < vb_pos) && ((y + i) > vb_above)) {
>> p1 = (y + i == vb_pos - 1) ? p0 : p1;
>> p3 = (y + i >= vb_pos - 2) ? p1 : p3;
>> p5 = (y + i >= vb_pos - 3) ? p3 : p5;
>> @@ -85,7 +85,7 @@ static void FUNC(alf_filter_luma)(uint8_t *_dst,
>> ptrdiff_t dst_stride, const uin
>> p2 = (y + i == vb_pos - 1) ? p0 : p2;
>> p4 = (y + i >= vb_pos - 2) ? p2 : p4;
>> p6 = (y + i >= vb_pos - 3) ? p4 : p6;
>> - } else if ((y + i >= vb_pos) && ((y + i) <= vb_below)) {
>> + } else if ((y + i >= vb_pos) && ((y + i) < vb_below)) {
>> p2 = (y + i == vb_pos ) ? p0 : p2;
>> p4 = (y + i <= vb_pos + 1) ? p2 : p4;
>> p6 = (y + i <= vb_pos + 2) ? p4 : p6;
>> --
>> 2.42.0
>>
>> _______________________________________________
>> ffmpeg-devel mailing list
>> ffmpeg-devel@ffmpeg.org
>> https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
>>
>> To unsubscribe, visit link above, or email
>> ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".
>>
> _______________________________________________
> ffmpeg-devel mailing list
> ffmpeg-devel@ffmpeg.org <mailto:ffmpeg-devel@ffmpeg.org>
> https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
>
> To unsubscribe, visit link above, or email
> ffmpeg-devel-request@ffmpeg.org <mailto:ffmpeg-devel-request@ffmpeg.org> with subject "unsubscribe".
_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [FFmpeg-devel] [PATCH 1/2] avcodec/vvc: Remove NOP condition check in alf_filter_luma
2024-07-16 16:07 ` Zhao Zhili
@ 2024-07-16 16:17 ` Zhao Zhili
2024-07-17 13:30 ` Nuo Mi
0 siblings, 1 reply; 5+ messages in thread
From: Zhao Zhili @ 2024-07-16 16:17 UTC (permalink / raw)
To: FFmpeg development discussions and patches
> On Jul 17, 2024, at 00:07, Zhao Zhili <quinkblack@foxmail.com> wrote:
>
>
>
>> On Jul 16, 2024, at 20:31, Nuo Mi <nuomi2021@gmail.com> wrote:
>>
>> On Tue, Jul 16, 2024 at 10:50 AM Zhao Zhili <quinkblack@foxmail.com <mailto:quinkblack@foxmail.com>> wrote:
>>
>>> From: Zhao Zhili <zhilizhao@tencent.com <mailto:zhilizhao@tencent.com>>
>>>
>>> If (y + i == vb_above) or (y + i == vb_below), the if body has no
>>> operation.
>>>
>> 👍, How did you find this? From a compiler warning or by reading the code?
>
> There is compiler warning. I found this issue when trying to simplify the logic
> before rewrite in ARM assembly.
Oops, I mean there is “no" compiler warning.
>
>>
>>
>>> ---
>>> libavcodec/vvc/filter_template.c | 4 ++--
>>> 1 file changed, 2 insertions(+), 2 deletions(-)
>>>
>>> diff --git a/libavcodec/vvc/filter_template.c
>>> b/libavcodec/vvc/filter_template.c
>>> index 9b3a0e46f7..32777452b7 100644
>>> --- a/libavcodec/vvc/filter_template.c
>>> +++ b/libavcodec/vvc/filter_template.c
>>> @@ -77,7 +77,7 @@ static void FUNC(alf_filter_luma)(uint8_t *_dst,
>>> ptrdiff_t dst_stride, const uin
>>> const int is_near_vb_below = (y + i >= vb_pos) && (y + i
>>> <= vb_pos);
>>> const int is_near_vb = is_near_vb_above ||
>>> is_near_vb_below;
>>>
>>> - if ((y + i < vb_pos) && ((y + i) >= vb_above)) {
>>> + if ((y + i < vb_pos) && ((y + i) > vb_above)) {
>>> p1 = (y + i == vb_pos - 1) ? p0 : p1;
>>> p3 = (y + i >= vb_pos - 2) ? p1 : p3;
>>> p5 = (y + i >= vb_pos - 3) ? p3 : p5;
>>> @@ -85,7 +85,7 @@ static void FUNC(alf_filter_luma)(uint8_t *_dst,
>>> ptrdiff_t dst_stride, const uin
>>> p2 = (y + i == vb_pos - 1) ? p0 : p2;
>>> p4 = (y + i >= vb_pos - 2) ? p2 : p4;
>>> p6 = (y + i >= vb_pos - 3) ? p4 : p6;
>>> - } else if ((y + i >= vb_pos) && ((y + i) <= vb_below)) {
>>> + } else if ((y + i >= vb_pos) && ((y + i) < vb_below)) {
>>> p2 = (y + i == vb_pos ) ? p0 : p2;
>>> p4 = (y + i <= vb_pos + 1) ? p2 : p4;
>>> p6 = (y + i <= vb_pos + 2) ? p4 : p6;
>>> --
>>> 2.42.0
>>>
>>> _______________________________________________
>>> ffmpeg-devel mailing list
>>> ffmpeg-devel@ffmpeg.org
>>> https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
>>>
>>> To unsubscribe, visit link above, or email
>>> ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".
>>>
>> _______________________________________________
>> ffmpeg-devel mailing list
>> ffmpeg-devel@ffmpeg.org <mailto:ffmpeg-devel@ffmpeg.org>
>> https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
>>
>> To unsubscribe, visit link above, or email
>> ffmpeg-devel-request@ffmpeg.org <mailto:ffmpeg-devel-request@ffmpeg.org> with subject "unsubscribe".
>
> _______________________________________________
> ffmpeg-devel mailing list
> ffmpeg-devel@ffmpeg.org
> https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
>
> To unsubscribe, visit link above, or email
> ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".
_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [FFmpeg-devel] [PATCH 1/2] avcodec/vvc: Remove NOP condition check in alf_filter_luma
2024-07-16 16:17 ` Zhao Zhili
@ 2024-07-17 13:30 ` Nuo Mi
0 siblings, 0 replies; 5+ messages in thread
From: Nuo Mi @ 2024-07-17 13:30 UTC (permalink / raw)
To: FFmpeg development discussions and patches
On Wed, Jul 17, 2024 at 12:17 AM Zhao Zhili <quinkblack@foxmail.com> wrote:
>
>
> > On Jul 17, 2024, at 00:07, Zhao Zhili <quinkblack@foxmail.com> wrote:
> >
> >
> >
> >> On Jul 16, 2024, at 20:31, Nuo Mi <nuomi2021@gmail.com> wrote:
> >>
> >> On Tue, Jul 16, 2024 at 10:50 AM Zhao Zhili <quinkblack@foxmail.com
> <mailto:quinkblack@foxmail.com>> wrote:
> >>
> >>> From: Zhao Zhili <zhilizhao@tencent.com <mailto:zhilizhao@tencent.com
> >>
> >>>
> >>> If (y + i == vb_above) or (y + i == vb_below), the if body has no
> >>> operation.
> >>>
> >> 👍, How did you find this? From a compiler warning or by reading the
> code?
> >
> > There is compiler warning. I found this issue when trying to simplify
> the logic
> > before rewrite in ARM assembly.
>
> Oops, I mean there is “no" compiler warning.
>
Good catch!
Applied.
Thank you
>
> >
> >>
> >>
> >>> ---
> >>> libavcodec/vvc/filter_template.c | 4 ++--
> >>> 1 file changed, 2 insertions(+), 2 deletions(-)
> >>>
> >>> diff --git a/libavcodec/vvc/filter_template.c
> >>> b/libavcodec/vvc/filter_template.c
> >>> index 9b3a0e46f7..32777452b7 100644
> >>> --- a/libavcodec/vvc/filter_template.c
> >>> +++ b/libavcodec/vvc/filter_template.c
> >>> @@ -77,7 +77,7 @@ static void FUNC(alf_filter_luma)(uint8_t *_dst,
> >>> ptrdiff_t dst_stride, const uin
> >>> const int is_near_vb_below = (y + i >= vb_pos) && (y + i
> >>> <= vb_pos);
> >>> const int is_near_vb = is_near_vb_above ||
> >>> is_near_vb_below;
> >>>
> >>> - if ((y + i < vb_pos) && ((y + i) >= vb_above)) {
> >>> + if ((y + i < vb_pos) && ((y + i) > vb_above)) {
> >>> p1 = (y + i == vb_pos - 1) ? p0 : p1;
> >>> p3 = (y + i >= vb_pos - 2) ? p1 : p3;
> >>> p5 = (y + i >= vb_pos - 3) ? p3 : p5;
> >>> @@ -85,7 +85,7 @@ static void FUNC(alf_filter_luma)(uint8_t *_dst,
> >>> ptrdiff_t dst_stride, const uin
> >>> p2 = (y + i == vb_pos - 1) ? p0 : p2;
> >>> p4 = (y + i >= vb_pos - 2) ? p2 : p4;
> >>> p6 = (y + i >= vb_pos - 3) ? p4 : p6;
> >>> - } else if ((y + i >= vb_pos) && ((y + i) <=
> vb_below)) {
> >>> + } else if ((y + i >= vb_pos) && ((y + i) < vb_below))
> {
> >>> p2 = (y + i == vb_pos ) ? p0 : p2;
> >>> p4 = (y + i <= vb_pos + 1) ? p2 : p4;
> >>> p6 = (y + i <= vb_pos + 2) ? p4 : p6;
> >>> --
> >>> 2.42.0
> >>>
> >>> _______________________________________________
> >>> ffmpeg-devel mailing list
> >>> ffmpeg-devel@ffmpeg.org
> >>> https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
> >>>
> >>> To unsubscribe, visit link above, or email
> >>> ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".
> >>>
> >> _______________________________________________
> >> ffmpeg-devel mailing list
> >> ffmpeg-devel@ffmpeg.org <mailto:ffmpeg-devel@ffmpeg.org>
> >> https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
> >>
> >> To unsubscribe, visit link above, or email
> >> ffmpeg-devel-request@ffmpeg.org <mailto:ffmpeg-devel-request@ffmpeg.org>
> with subject "unsubscribe".
> >
> > _______________________________________________
> > ffmpeg-devel mailing list
> > ffmpeg-devel@ffmpeg.org
> > https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
> >
> > To unsubscribe, visit link above, or email
> > ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".
>
> _______________________________________________
> ffmpeg-devel mailing list
> ffmpeg-devel@ffmpeg.org
> https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
>
> To unsubscribe, visit link above, or email
> ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".
>
_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2024-07-17 13:30 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2024-07-16 2:49 [FFmpeg-devel] [PATCH 1/2] avcodec/vvc: Remove NOP condition check in alf_filter_luma Zhao Zhili
2024-07-16 12:31 ` Nuo Mi
2024-07-16 16:07 ` Zhao Zhili
2024-07-16 16:17 ` Zhao Zhili
2024-07-17 13:30 ` Nuo Mi
Git Inbox Mirror of the ffmpeg-devel mailing list - see https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
This inbox may be cloned and mirrored by anyone:
git clone --mirror https://master.gitmailbox.com/ffmpegdev/0 ffmpegdev/git/0.git
# If you have public-inbox 1.1+ installed, you may
# initialize and index your mirror using the following commands:
public-inbox-init -V2 ffmpegdev ffmpegdev/ https://master.gitmailbox.com/ffmpegdev \
ffmpegdev@gitmailbox.com
public-inbox-index ffmpegdev
Example config snippet for mirrors.
AGPL code for this site: git clone https://public-inbox.org/public-inbox.git