Git Inbox Mirror of the ffmpeg-devel mailing list - see https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
 help / color / mirror / Atom feed
From: Nuo Mi <nuomi2021@gmail.com>
To: FFmpeg development discussions and patches <ffmpeg-devel@ffmpeg.org>
Subject: Re: [FFmpeg-devel] [PATCH] avcodec/vvc_thread: don't use an anonymous union
Date: Sun, 7 Jan 2024 09:13:25 +0800
Message-ID: <CAFXK13dS43HR+QZyjzLoqWxAUC_+yO4S8-hS59JgWu19WWk4Fg@mail.gmail.com> (raw)
In-Reply-To: <20240106193829.3166-1-jamrial@gmail.com>

On Sun, Jan 7, 2024 at 3:38 AM James Almer <jamrial@gmail.com> wrote:

> Should fix compilation with old GCC.
>
> Signed-off-by: James Almer <jamrial@gmail.com>
>
LGTM

> ---
>  libavcodec/vvc/vvc_thread.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/libavcodec/vvc/vvc_thread.c b/libavcodec/vvc/vvc_thread.c
> index db901585a4..31c931f050 100644
> --- a/libavcodec/vvc/vvc_thread.c
> +++ b/libavcodec/vvc/vvc_thread.c
> @@ -54,7 +54,7 @@ typedef struct VVCTask {
>      union {
>          struct VVCTask *next;                //for executor debug only
>          AVTask task;
> -    };
> +    } u;
>
>      VVCTaskStage stage;
>
> @@ -107,7 +107,7 @@ static void add_task(VVCContext *s, VVCTask *t)
>
>      atomic_fetch_add(&ft->nb_scheduled_tasks, 1);
>
> -    av_executor_execute(s->executor, &t->task);
> +    av_executor_execute(s->executor, &t->u.task);
>  }
>
>  static void task_init(VVCTask *t, VVCTaskStage stage, VVCFrameContext
> *fc, const int rx, const int ry)
> --
> 2.43.0
>
> _______________________________________________
> ffmpeg-devel mailing list
> ffmpeg-devel@ffmpeg.org
> https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
>
> To unsubscribe, visit link above, or email
> ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".
>
_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel

To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".

      reply	other threads:[~2024-01-07  1:13 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-01-06 19:38 James Almer
2024-01-07  1:13 ` Nuo Mi [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CAFXK13dS43HR+QZyjzLoqWxAUC_+yO4S8-hS59JgWu19WWk4Fg@mail.gmail.com \
    --to=nuomi2021@gmail.com \
    --cc=ffmpeg-devel@ffmpeg.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

Git Inbox Mirror of the ffmpeg-devel mailing list - see https://ffmpeg.org/mailman/listinfo/ffmpeg-devel

This inbox may be cloned and mirrored by anyone:

	git clone --mirror https://master.gitmailbox.com/ffmpegdev/0 ffmpegdev/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 ffmpegdev ffmpegdev/ https://master.gitmailbox.com/ffmpegdev \
		ffmpegdev@gitmailbox.com
	public-inbox-index ffmpegdev

Example config snippet for mirrors.


AGPL code for this site: git clone https://public-inbox.org/public-inbox.git