Git Inbox Mirror of the ffmpeg-devel mailing list - see https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
 help / color / mirror / Atom feed
* [FFmpeg-devel] [PATCH 1/2] tests/checkasm/vvc_mc: fix indentation
@ 2024-05-29 14:02 James Almer
  2024-05-29 14:02 ` [FFmpeg-devel] [PATCH 2/2] tests/checkasm/vvc_mc: don't zero the SAD buffers James Almer
  0 siblings, 1 reply; 3+ messages in thread
From: James Almer @ 2024-05-29 14:02 UTC (permalink / raw)
  To: ffmpeg-devel

Signed-off-by: James Almer <jamrial@gmail.com>
---
 tests/checkasm/vvc_mc.c | 7 ++++---
 1 file changed, 4 insertions(+), 3 deletions(-)

diff --git a/tests/checkasm/vvc_mc.c b/tests/checkasm/vvc_mc.c
index 09cac82edb..40be837d68 100644
--- a/tests/checkasm/vvc_mc.c
+++ b/tests/checkasm/vvc_mc.c
@@ -341,8 +341,10 @@ static void check_vvc_sad(void)
         for (int w = 8; w <= 16; w *= 2) {
             for(int offy = 0; offy <= 4; offy++) {
                 for(int offx = 0; offx <= 4; offx++) {
-                    if(w * h >= 128) {
-                        if(check_func(c.inter.sad, "sad_%dx%d", w, h)) {
+                    if (w * h < 128)
+                        continue;
+
+                    if (check_func(c.inter.sad, "sad_%dx%d", w, h)) {
                         int result0;
                         int result1;
 
@@ -353,7 +355,6 @@ static void check_vvc_sad(void)
                             fail();
                         if(offx == 0 && offy == 0)
                             bench_new(src0 + PIXEL_STRIDE * 2 + 2, src1 + PIXEL_STRIDE * 2 + 2, offx, offy, w, h);
-                        }
                     }
                 }
             }
-- 
2.45.1

_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel

To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".

^ permalink raw reply	[flat|nested] 3+ messages in thread

* [FFmpeg-devel] [PATCH 2/2] tests/checkasm/vvc_mc: don't zero the SAD buffers
  2024-05-29 14:02 [FFmpeg-devel] [PATCH 1/2] tests/checkasm/vvc_mc: fix indentation James Almer
@ 2024-05-29 14:02 ` James Almer
  2024-05-31 12:07   ` Nuo Mi
  0 siblings, 1 reply; 3+ messages in thread
From: James Almer @ 2024-05-29 14:02 UTC (permalink / raw)
  To: ffmpeg-devel

They will be filled immediately after.

Signed-off-by: James Almer <jamrial@gmail.com>
---
 tests/checkasm/vvc_mc.c | 3 ---
 1 file changed, 3 deletions(-)

diff --git a/tests/checkasm/vvc_mc.c b/tests/checkasm/vvc_mc.c
index 40be837d68..bc6b580f42 100644
--- a/tests/checkasm/vvc_mc.c
+++ b/tests/checkasm/vvc_mc.c
@@ -333,9 +333,6 @@ static void check_vvc_sad(void)
     declare_func(int, const int16_t *src0, const int16_t *src1, int dx, int dy, int block_w, int block_h);
 
     ff_vvc_dsp_init(&c, bit_depth);
-    memset(src0, 0, MAX_CTU_SIZE * MAX_CTU_SIZE * 4 * sizeof(uint16_t));
-    memset(src1, 0, MAX_CTU_SIZE * MAX_CTU_SIZE * 4 * sizeof(uint16_t));
-
     randomize_pixels(src0, src1, MAX_CTU_SIZE * MAX_CTU_SIZE * 4);
     for (int h = 8; h <= 16; h *= 2) {
         for (int w = 8; w <= 16; w *= 2) {
-- 
2.45.1

_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel

To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".

^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [FFmpeg-devel] [PATCH 2/2] tests/checkasm/vvc_mc: don't zero the SAD buffers
  2024-05-29 14:02 ` [FFmpeg-devel] [PATCH 2/2] tests/checkasm/vvc_mc: don't zero the SAD buffers James Almer
@ 2024-05-31 12:07   ` Nuo Mi
  0 siblings, 0 replies; 3+ messages in thread
From: Nuo Mi @ 2024-05-31 12:07 UTC (permalink / raw)
  To: FFmpeg development discussions and patches

On Wed, May 29, 2024 at 10:03 PM James Almer <jamrial@gmail.com> wrote:

> They will be filled immediately after.
>
Pushed.
thank you, James

>
> Signed-off-by: James Almer <jamrial@gmail.com>
> ---
>  tests/checkasm/vvc_mc.c | 3 ---
>  1 file changed, 3 deletions(-)
>
> diff --git a/tests/checkasm/vvc_mc.c b/tests/checkasm/vvc_mc.c
> index 40be837d68..bc6b580f42 100644
> --- a/tests/checkasm/vvc_mc.c
> +++ b/tests/checkasm/vvc_mc.c
> @@ -333,9 +333,6 @@ static void check_vvc_sad(void)
>      declare_func(int, const int16_t *src0, const int16_t *src1, int dx,
> int dy, int block_w, int block_h);
>
>      ff_vvc_dsp_init(&c, bit_depth);
> -    memset(src0, 0, MAX_CTU_SIZE * MAX_CTU_SIZE * 4 * sizeof(uint16_t));
> -    memset(src1, 0, MAX_CTU_SIZE * MAX_CTU_SIZE * 4 * sizeof(uint16_t));
> -
>      randomize_pixels(src0, src1, MAX_CTU_SIZE * MAX_CTU_SIZE * 4);
>      for (int h = 8; h <= 16; h *= 2) {
>          for (int w = 8; w <= 16; w *= 2) {
> --
> 2.45.1
>
> _______________________________________________
> ffmpeg-devel mailing list
> ffmpeg-devel@ffmpeg.org
> https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
>
> To unsubscribe, visit link above, or email
> ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".
>
_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel

To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".

^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2024-05-31 12:08 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2024-05-29 14:02 [FFmpeg-devel] [PATCH 1/2] tests/checkasm/vvc_mc: fix indentation James Almer
2024-05-29 14:02 ` [FFmpeg-devel] [PATCH 2/2] tests/checkasm/vvc_mc: don't zero the SAD buffers James Almer
2024-05-31 12:07   ` Nuo Mi

Git Inbox Mirror of the ffmpeg-devel mailing list - see https://ffmpeg.org/mailman/listinfo/ffmpeg-devel

This inbox may be cloned and mirrored by anyone:

	git clone --mirror https://master.gitmailbox.com/ffmpegdev/0 ffmpegdev/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 ffmpegdev ffmpegdev/ https://master.gitmailbox.com/ffmpegdev \
		ffmpegdev@gitmailbox.com
	public-inbox-index ffmpegdev

Example config snippet for mirrors.


AGPL code for this site: git clone https://public-inbox.org/public-inbox.git