Re: [FFmpeg-devel] [PATCH] vvcdec: Mark as experimental

From: Nuo Mi <nuomi2021@gmail.com>
To: FFmpeg development discussions and patches <ffmpeg-devel@ffmpeg.org>
Subject: Re: [FFmpeg-devel] [PATCH] vvcdec: Mark as experimental
Date: Sat, 16 Mar 2024 22:50:32 +0800
Message-ID: <CAFXK13c-Mp_fkrz6mgu1-sm_4torbrf9TCeLK=YuUgi3tytbcg@mail.gmail.com> (raw)
In-Reply-To: <AS8P250MB074442058336C25CBB286FA58F282@AS8P250MB0744.EURP250.PROD.OUTLOOK.COM>

On Fri, Mar 15, 2024 at 11:05 PM Andreas Rheinhardt <
andreas.rheinhardt@outlook.com> wrote:

> Frank Plowman:
> > On 15/03/2024 10:22, Kieran Kunhya wrote:
> >> On Thu, 14 Mar 2024, 22:54 Michael Niedermayer, <michael@niedermayer.cc
> >
> >> wrote:
> >>
> >>> On Wed, Feb 07, 2024 at 10:55:18PM +0000, Kieran Kunhya wrote:
> >>>> On Wed, 7 Feb 2024 at 22:06, Paul B Mahol <onemda@gmail.com> wrote:
> >>>>
> >>>>> On Wed, Feb 7, 2024 at 10:13 PM Kieran Kunhya <kierank@obe.tv>
> wrote:
> >>>>>
> >>>>>> $subj
> >>>>>>
> >>>>>> As discussed at FOSDEM.
> >>>>>>
> >>>>>
> >>>>> Author of this patch above is forced to FUZZ this decoder until
> >>>>> experimental flag is removed.
> >>>>>
> >>>>
> >>>> Sure, I will set some fuzzers up over the weekend.
> >>>
> >>> over a month later ...
> >>> has this been done ?
> >>>
> >>>
> >>> thx
> >>>
> >>> [...]
> >>>
> >>
> >> Frank said there was no need as he was doing it himself.
> >>
> >> I do not appreciate your passive aggressive tone.
> >>
> >> Kieran
> >>
> >
> > I have been fuzzing since the end of January.  Various patches have made
> > the decoder much more robust than it was then.  Still getting a crash on
> > occasion, but most are now false positives due to assertion failures
> > rather than segmentation faults or other potential security issues.
> > That being said, the hardware I am using is extremely modest compared to
> > oss-fuzz's.
>
> An assertion failure is not a false positive. Even if it is an av_assert2.
>
Agree, we need to return PATCH_WELCOME for them too.

>
> - Andreas
>
> _______________________________________________
> ffmpeg-devel mailing list
> ffmpeg-devel@ffmpeg.org
> https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
>
> To unsubscribe, visit link above, or email
> ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".
>
_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel

To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".