* [FFmpeg-devel] [PATCH] doc/examples/vaapi_transcode: fix null framerate
@ 2023-03-30 8:28 jianfeng.zheng
2023-03-31 14:45 ` Xiang, Haihao
2023-03-31 15:04 ` Anton Khirnov
0 siblings, 2 replies; 4+ messages in thread
From: jianfeng.zheng @ 2023-03-30 8:28 UTC (permalink / raw)
To: ffmpeg-devel
When framerate in codec layer is null, guess from stream.
Signed-off-by: jianfeng.zheng <jianfeng.zheng@mthreads.com>
---
doc/examples/vaapi_transcode.c | 4 ++++
1 file changed, 4 insertions(+)
diff --git a/doc/examples/vaapi_transcode.c b/doc/examples/vaapi_transcode.c
index 8367cb3040..cdcc4e263a 100644
--- a/doc/examples/vaapi_transcode.c
+++ b/doc/examples/vaapi_transcode.c
@@ -103,6 +103,10 @@ static int open_input_file(const char *filename)
fprintf(stderr, "Failed to open codec for decoding. Error code: %s\n",
av_err2str(ret));
+ if (decoder_ctx->framerate.num == 0 &&
+ video->r_frame_rate.num > 0 && video->r_frame_rate.den > 0)
+ decoder_ctx->framerate = video->r_frame_rate;
+
return ret;
}
--
2.25.1
_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [FFmpeg-devel] [PATCH] doc/examples/vaapi_transcode: fix null framerate
2023-03-30 8:28 [FFmpeg-devel] [PATCH] doc/examples/vaapi_transcode: fix null framerate jianfeng.zheng
@ 2023-03-31 14:45 ` Xiang, Haihao
2023-03-31 15:04 ` Anton Khirnov
1 sibling, 0 replies; 4+ messages in thread
From: Xiang, Haihao @ 2023-03-31 14:45 UTC (permalink / raw)
To: ffmpeg-devel
On Do, 2023-03-30 at 16:28 +0800, jianfeng.zheng wrote:
> When framerate in codec layer is null, guess from stream.
>
> Signed-off-by: jianfeng.zheng <jianfeng.zheng@mthreads.com>
> ---
> doc/examples/vaapi_transcode.c | 4 ++++
> 1 file changed, 4 insertions(+)
>
> diff --git a/doc/examples/vaapi_transcode.c b/doc/examples/vaapi_transcode.c
> index 8367cb3040..cdcc4e263a 100644
> --- a/doc/examples/vaapi_transcode.c
> +++ b/doc/examples/vaapi_transcode.c
> @@ -103,6 +103,10 @@ static int open_input_file(const char *filename)
> fprintf(stderr, "Failed to open codec for decoding. Error code:
> %s\n",
> av_err2str(ret));
>
> + if (decoder_ctx->framerate.num == 0 &&
> + video->r_frame_rate.num > 0 && video->r_frame_rate.den
> > 0)
> + decoder_ctx->framerate = video->r_frame_rate;
> +
> return ret;
> }
>
LGTM, will apply,
Thanks
Haihao
>
_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [FFmpeg-devel] [PATCH] doc/examples/vaapi_transcode: fix null framerate
2023-03-30 8:28 [FFmpeg-devel] [PATCH] doc/examples/vaapi_transcode: fix null framerate jianfeng.zheng
2023-03-31 14:45 ` Xiang, Haihao
@ 2023-03-31 15:04 ` Anton Khirnov
2023-04-07 11:37 ` Jianfeng Zheng
1 sibling, 1 reply; 4+ messages in thread
From: Anton Khirnov @ 2023-03-31 15:04 UTC (permalink / raw)
To: FFmpeg development discussions and patches
Quoting jianfeng.zheng (2023-03-30 10:28:27)
> When framerate in codec layer is null, guess from stream.
>
> Signed-off-by: jianfeng.zheng <jianfeng.zheng@mthreads.com>
> ---
> doc/examples/vaapi_transcode.c | 4 ++++
> 1 file changed, 4 insertions(+)
>
> diff --git a/doc/examples/vaapi_transcode.c b/doc/examples/vaapi_transcode.c
> index 8367cb3040..cdcc4e263a 100644
> --- a/doc/examples/vaapi_transcode.c
> +++ b/doc/examples/vaapi_transcode.c
> @@ -103,6 +103,10 @@ static int open_input_file(const char *filename)
> fprintf(stderr, "Failed to open codec for decoding. Error code: %s\n",
> av_err2str(ret));
>
> + if (decoder_ctx->framerate.num == 0 &&
> + video->r_frame_rate.num > 0 && video->r_frame_rate.den > 0)
> + decoder_ctx->framerate = video->r_frame_rate;
This field is to be set by decoder, not the API caller.
--
Anton Khirnov
_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [FFmpeg-devel] [PATCH] doc/examples/vaapi_transcode: fix null framerate
2023-03-31 15:04 ` Anton Khirnov
@ 2023-04-07 11:37 ` Jianfeng Zheng
0 siblings, 0 replies; 4+ messages in thread
From: Jianfeng Zheng @ 2023-04-07 11:37 UTC (permalink / raw)
To: FFmpeg development discussions and patches
Hi Anton, Haihao,
Please review patch v2.
Thanks,
Jianfeng
Anton Khirnov <anton@khirnov.net> 于2023年3月31日周五 23:04写道：
>
> Quoting jianfeng.zheng (2023-03-30 10:28:27)
> > When framerate in codec layer is null, guess from stream.
> >
> > Signed-off-by: jianfeng.zheng <jianfeng.zheng@mthreads.com>
> > ---
> > doc/examples/vaapi_transcode.c | 4 ++++
> > 1 file changed, 4 insertions(+)
> >
> > diff --git a/doc/examples/vaapi_transcode.c b/doc/examples/vaapi_transcode.c
> > index 8367cb3040..cdcc4e263a 100644
> > --- a/doc/examples/vaapi_transcode.c
> > +++ b/doc/examples/vaapi_transcode.c
> > @@ -103,6 +103,10 @@ static int open_input_file(const char *filename)
> > fprintf(stderr, "Failed to open codec for decoding. Error code: %s\n",
> > av_err2str(ret));
> >
> > + if (decoder_ctx->framerate.num == 0 &&
> > + video->r_frame_rate.num > 0 && video->r_frame_rate.den > 0)
> > + decoder_ctx->framerate = video->r_frame_rate;
>
> This field is to be set by decoder, not the API caller.
>
> --
> Anton Khirnov
> _______________________________________________
> ffmpeg-devel mailing list
> ffmpeg-devel@ffmpeg.org
> https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
>
> To unsubscribe, visit link above, or email
> ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".
_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2023-04-07 11:37 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2023-03-30 8:28 [FFmpeg-devel] [PATCH] doc/examples/vaapi_transcode: fix null framerate jianfeng.zheng
2023-03-31 14:45 ` Xiang, Haihao
2023-03-31 15:04 ` Anton Khirnov
2023-04-07 11:37 ` Jianfeng Zheng
Git Inbox Mirror of the ffmpeg-devel mailing list - see https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
This inbox may be cloned and mirrored by anyone:
git clone --mirror https://master.gitmailbox.com/ffmpegdev/0 ffmpegdev/git/0.git
# If you have public-inbox 1.1+ installed, you may
# initialize and index your mirror using the following commands:
public-inbox-init -V2 ffmpegdev ffmpegdev/ https://master.gitmailbox.com/ffmpegdev \
ffmpegdev@gitmailbox.com
public-inbox-index ffmpegdev
Example config snippet for mirrors.
AGPL code for this site: git clone https://public-inbox.org/public-inbox.git