From: Jianfeng Zheng <ggjogh@gmail.com>
To: FFmpeg development discussions and patches <ffmpeg-devel@ffmpeg.org>
Subject: Re: [FFmpeg-devel] [PATCH] doc/examples/vaapi_transcode: fix null framerate
Date: Fri, 7 Apr 2023 19:37:17 +0800
Message-ID: <CAFWZL8qR_ooYRSbVwNmBo6pKydHfkwri9aPexXwcEeFuoxqqCA@mail.gmail.com> (raw)
In-Reply-To: <168027507527.27013.2693391073292120073@lain.khirnov.net>
Hi Anton, Haihao,
Please review patch v2.
Thanks,
Jianfeng
Anton Khirnov <anton@khirnov.net> 于2023年3月31日周五 23:04写道:
>
> Quoting jianfeng.zheng (2023-03-30 10:28:27)
> > When framerate in codec layer is null, guess from stream.
> >
> > Signed-off-by: jianfeng.zheng <jianfeng.zheng@mthreads.com>
> > ---
> > doc/examples/vaapi_transcode.c | 4 ++++
> > 1 file changed, 4 insertions(+)
> >
> > diff --git a/doc/examples/vaapi_transcode.c b/doc/examples/vaapi_transcode.c
> > index 8367cb3040..cdcc4e263a 100644
> > --- a/doc/examples/vaapi_transcode.c
> > +++ b/doc/examples/vaapi_transcode.c
> > @@ -103,6 +103,10 @@ static int open_input_file(const char *filename)
> > fprintf(stderr, "Failed to open codec for decoding. Error code: %s\n",
> > av_err2str(ret));
> >
> > + if (decoder_ctx->framerate.num == 0 &&
> > + video->r_frame_rate.num > 0 && video->r_frame_rate.den > 0)
> > + decoder_ctx->framerate = video->r_frame_rate;
>
> This field is to be set by decoder, not the API caller.
>
> --
> Anton Khirnov
> _______________________________________________
> ffmpeg-devel mailing list
> ffmpeg-devel@ffmpeg.org
> https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
>
> To unsubscribe, visit link above, or email
> ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".
_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".
prev parent reply other threads:[~2023-04-07 11:37 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-03-30 8:28 jianfeng.zheng
2023-03-31 14:45 ` Xiang, Haihao
2023-03-31 15:04 ` Anton Khirnov
2023-04-07 11:37 ` Jianfeng Zheng [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAFWZL8qR_ooYRSbVwNmBo6pKydHfkwri9aPexXwcEeFuoxqqCA@mail.gmail.com \
--to=ggjogh@gmail.com \
--cc=ffmpeg-devel@ffmpeg.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Git Inbox Mirror of the ffmpeg-devel mailing list - see https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
This inbox may be cloned and mirrored by anyone:
git clone --mirror https://master.gitmailbox.com/ffmpegdev/0 ffmpegdev/git/0.git
# If you have public-inbox 1.1+ installed, you may
# initialize and index your mirror using the following commands:
public-inbox-init -V2 ffmpegdev ffmpegdev/ https://master.gitmailbox.com/ffmpegdev \
ffmpegdev@gitmailbox.com
public-inbox-index ffmpegdev
Example config snippet for mirrors.
AGPL code for this site: git clone https://public-inbox.org/public-inbox.git