From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTP id A5ACA47CAC for ; Thu, 16 Nov 2023 22:36:23 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id 4B2AD68CD3C; Fri, 17 Nov 2023 00:36:22 +0200 (EET) Received: from mail-oa1-f45.google.com (mail-oa1-f45.google.com [209.85.160.45]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id 60C8968CBAB for ; Fri, 17 Nov 2023 00:36:16 +0200 (EET) Received: by mail-oa1-f45.google.com with SMTP id 586e51a60fabf-1f00b95dc43so699295fac.3 for ; Thu, 16 Nov 2023 14:36:16 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1700174174; x=1700778974; darn=ffmpeg.org; h=to:subject:message-id:date:from:reply-to:mime-version:from:to:cc :subject:date:message-id:reply-to; bh=01tiUAhs79OfkYKYxsi+HigKv5u3UG7382K7zznHWaQ=; b=VtG8emQF7fbnGSmiEyIYMJvyXN8dJH7WbK9MPFhQ5tcxSDZfLvtluil2sIZiMJWh+X ofWblHqj62UCf15qY7R2Bv9Uw/4hTbWAh/1hreipEhNPHoE5eV8bmA/8f8KYiEMy5a/y KvEFj+1CmesVzHeL0Kbnsov/erHDTH76064beH5ISTDZFRy4gi14bi8nHALQVV2CoUPC SnHO7WA9lW7XaO+9FUaXKiYzlWvaVHwquTdgfIY73/pkfK0IWk98fekKQusbNeVzbbaE kDuKk+12gYr+6zZFqdphsHyEb5Sc7JRKlP5/kKjrzvCMG3Ibs/CCw0w3ZcNbC3CQdiwv dIww== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1700174174; x=1700778974; h=to:subject:message-id:date:from:reply-to:mime-version :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=01tiUAhs79OfkYKYxsi+HigKv5u3UG7382K7zznHWaQ=; b=Sz61SNC3ruxFEKJkbvm2j7yAbmhegy/gf2Qx31aur0o7PwxH2ggPvA31gErIKinnlN TisTsK2OmlrFZxcgEu+N2cZG7ttfG/RanqFRxrxPLsbeunGX82DLme5ViMD85zv5426t B8J8ACKsz1V/8OIV/kbZG9EGSeYQ34G292bPsFSviOqYQXQRelaMciKjfMMbv4gBOjva VKqXq621+qUqIR2H6r8z2PExS2MPszB9e4L8eGpGfFIamRT2bmHH6FKXoT7knzQdbbHQ sUakaTGyU7Y1KNCCS9/BAnOgxUCprotQ1cmHzgBj9zPt0LN9Y3BiAhKwmr5odLUgU81e oToQ== X-Gm-Message-State: AOJu0Yx+Dz4U3At2+llYyS/QxpG7w/a0Kj9T2r+izseVQr7CJZi/1Jwc JG6BFxreVFfMh5bTMkT8D37sq+owDUOHFYlHLxa0UbJuy1Y3 X-Google-Smtp-Source: AGHT+IEA8K1zl9iXXPBqIQJ1HrUiibYwUVGZebXS6IfL/Qf/L9vq3aBOjc8tOnx1TCmH2Md7Pj/c04l0Y6BVEDbD8hg= X-Received: by 2002:a05:6870:538f:b0:1f0:656b:5b99 with SMTP id h15-20020a056870538f00b001f0656b5b99mr18437363oan.11.1700174174578; Thu, 16 Nov 2023 14:36:14 -0800 (PST) MIME-Version: 1.0 From: Reed Weichler Date: Thu, 16 Nov 2023 14:35:58 -0800 Message-ID: To: ffmpeg-devel@ffmpeg.org Subject: [FFmpeg-devel] [PATCH] cherrypick ab7926341 into 4.2 X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: pretty self-explanatory. i guess they forgot to cherrypick it when it was first committed. here is my code to repro: https://pastebin.com/raw/yQr3WWvX it needs a FLAC file as input. it hit an EXC_BAD_ACCESS here: https://github.com/FFmpeg/FFmpeg/blob/c6c36aa97a/libavformat/utils.c#L2227 index was equal to -1, so that code shouldnt even run, usually means UB. --- libavformat/utils.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/libavformat/utils.c b/libavformat/utils.c index 4067d55fa1..2143d9fb59 100644 --- a/libavformat/utils.c +++ b/libavformat/utils.c @@ -2183,7 +2183,7 @@ int ff_seek_frame_binary(AVFormatContext *s, int stream_index, int64_t target_ts, int flags) { const AVInputFormat *avif = s->iformat; - int64_t av_uninit(pos_min), av_uninit(pos_max), pos, pos_limit; + int64_t pos_min = 0, pos_max = 0, pos, pos_limit; int64_t ts_min, ts_max, ts; int index; int64_t ret; -- 2.42.1 _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".