From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTP id 4215747CA4 for ; Thu, 16 Nov 2023 22:28:59 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id 4209868CC6D; Fri, 17 Nov 2023 00:28:56 +0200 (EET) Received: from mail-oa1-f46.google.com (mail-oa1-f46.google.com [209.85.160.46]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id 292D368CBDC for ; Fri, 17 Nov 2023 00:28:50 +0200 (EET) Received: by mail-oa1-f46.google.com with SMTP id 586e51a60fabf-1f00b95dc43so695738fac.3 for ; Thu, 16 Nov 2023 14:28:50 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1700173727; x=1700778527; darn=ffmpeg.org; h=to:subject:message-id:date:from:reply-to:mime-version:from:to:cc :subject:date:message-id:reply-to; bh=hLpF+p/qybSQdyq+AE5vGjTheFDDWewedTc51w0WeQM=; b=WFEsmhW753peAyIgaz+XJliYKWy1m2aAzEkOjGqeGpvMo4dYJ8SZE2ABMkknJ8rcme AEUpkL98K4+7Jf8h9BlLb/SOmTBieUNViDyRpDTPWt6gDvlZ/NMPEo25DEMkfZfiRxsP f4YNQz/wp4K3JmyptUrGWdlglFWI+q39wVtN47B+44mJLTKgW83QmTm9FUrR9bMWzaY6 jom30QiYJCS/t4mBX9+cFd5slwp1z1DiYMyn9KcO22wDxzznWAEGAxwBfUg8NENrectg IsEYAiWeGPqWminbeANoxfI/hZpLgIxH94zkhaBt4YW4RTnq5mE5pZ4VVWof35R93y9D QD4w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1700173727; x=1700778527; h=to:subject:message-id:date:from:reply-to:mime-version :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=hLpF+p/qybSQdyq+AE5vGjTheFDDWewedTc51w0WeQM=; b=SNHcjnJbfzfiekoj6R6hwls2UHYL56acV2G3ZQJq5npSjKtWrwVhy1z0u8fHOo30Ou wHSZZvM09756it3nJmRw3z/Js4mVI3lR5TCAlkRym7IvnX5im27Sr7Xp28F9gYmGmZYL CGn4eYuv678hpAfcTqCB//dbNfUs3009Br0PDWUqY80H6d6rJIidQNmJ+HIjP8Dx85I8 ZUYWcd8yFG6vp6j2TzUMPJu+QTZclk28bzgcLyOmTNpV2IUAaR+sTtZwZrZjpQRBzlUE K8sieI36b8w+ut5lapli7tuyoVk9LTPPN55xNMuTQ35ROneJjQX+XJ4kR23VaVvYxNWH mH9Q== X-Gm-Message-State: AOJu0YySy03ZP1fzpyafKj6nJvR53ECaIZyXODVxo3GM85rJ2jDaZOuR h3gG0cKiVCxhN7axtoK7iSc8PZnWOd9ffcnU9NLCWgPYFgeh X-Google-Smtp-Source: AGHT+IEk6v3wfFCimFkPxz39PcX43QxnE5Vw0FMDFn9L753v7UBerUhUvemFjsAAmNiicHqXuVuYbV5kUQuBz0gykbI= X-Received: by 2002:a05:6870:3d85:b0:1e5:89d8:81fb with SMTP id lm5-20020a0568703d8500b001e589d881fbmr23609175oab.10.1700173727354; Thu, 16 Nov 2023 14:28:47 -0800 (PST) MIME-Version: 1.0 From: Reed Weichler Date: Thu, 16 Nov 2023 14:28:31 -0800 Message-ID: To: ffmpeg-devel@ffmpeg.org X-Content-Filtered-By: Mailman/MimeDel 2.1.29 Subject: [FFmpeg-devel] [PATCH] cherrypick ab7926341 into 4.2 X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: pretty self-explanatory. i guess they forgot to cherrypick it when it was first committed. here is my code to repro: https://pastebin.com/raw/yQr3WWvX it needs a FLAC file as input. it hit an EXC_BAD_ACCESS here: https://github.com/FFmpeg/FFmpeg/blob/c6c36aa97a/libavformat/utils.c#L2227 index was equal to -1, so that code shouldnt even run, which usually means undefined behavior --- libavformat/utils.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/libavformat/utils.c b/libavformat/utils.c index 4067d55fa1..2143d9fb59 100644 --- a/libavformat/utils.c +++ b/libavformat/utils.c @@ -2183,7 +2183,7 @@ int ff_seek_frame_binary(AVFormatContext *s, int stream_index, int64_t target_ts, int flags) { const AVInputFormat *avif = s->iformat; - int64_t av_uninit(pos_min), av_uninit(pos_max), pos, pos_limit; + int64_t pos_min = 0, pos_max = 0, pos, pos_limit; int64_t ts_min, ts_max, ts; int index; int64_t ret; -- 2.42.1 _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".