Git Inbox Mirror of the ffmpeg-devel mailing list - see https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
 help / color / mirror / Atom feed
From: Henrik Gramner via ffmpeg-devel <ffmpeg-devel@ffmpeg.org>
To: FFmpeg development discussions and patches <ffmpeg-devel@ffmpeg.org>
Cc: Henrik Gramner <henrik@gramner.com>
Subject: Re: [FFmpeg-devel] [PATCH v2] checkasm: add sample argument to adjust during bench
Date: Tue, 21 May 2024 14:48:21 +0200
Message-ID: <CAFGUN0r5Ws3Shimp1AoTRXC-orECUQqFm4XV6y9d=JtrOtz8jw@mail.gmail.com> (raw)
In-Reply-To: <20240521123338.29539-1-jdek@itanimul.li>

On Tue, May 21, 2024 at 2:33 PM J. Dekker <jdek@itanimul.li> wrote:
> @@ -338,8 +338,9 @@ typedef struct CheckasmPerf {
>              uint64_t tsum = 0;\
>              int ti, tcount = 0;\
>              uint64_t t = 0; \
> +            const uint64_t truns = bench_runs;\
>              checkasm_set_signal_handler_state(1);\
> -            for (ti = 0; ti < BENCH_RUNS; ti++) {\
> +            for (ti = 0; ti < truns; ti++) {\

This is comparing int with uint64_t. We should probably just use int
for the sample count too.
_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel

To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".

  reply	other threads:[~2024-05-21 12:48 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-05-16 13:09 [FFmpeg-devel] [PATCH] " J. Dekker
2024-05-16 13:59 ` Rémi Denis-Courmont
2024-05-21 12:32   ` [FFmpeg-devel] [PATCH v2] " J. Dekker
2024-05-21 12:48     ` Henrik Gramner via ffmpeg-devel [this message]
2024-05-21 13:00     ` Lynne via ffmpeg-devel
2024-05-21 13:51       ` [FFmpeg-devel] [PATCH v3] " J. Dekker
2024-05-21 14:04         ` Lynne via ffmpeg-devel
2024-05-21 14:49           ` J. Dekker

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='CAFGUN0r5Ws3Shimp1AoTRXC-orECUQqFm4XV6y9d=JtrOtz8jw@mail.gmail.com' \
    --to=ffmpeg-devel@ffmpeg.org \
    --cc=henrik@gramner.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

Git Inbox Mirror of the ffmpeg-devel mailing list - see https://ffmpeg.org/mailman/listinfo/ffmpeg-devel

This inbox may be cloned and mirrored by anyone:

	git clone --mirror https://master.gitmailbox.com/ffmpegdev/0 ffmpegdev/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 ffmpegdev ffmpegdev/ https://master.gitmailbox.com/ffmpegdev \
		ffmpegdev@gitmailbox.com
	public-inbox-index ffmpegdev

Example config snippet for mirrors.


AGPL code for this site: git clone https://public-inbox.org/public-inbox.git