From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTP id E52F540D6E for ; Thu, 10 Mar 2022 15:22:50 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id 4EA8B68B11B; Thu, 10 Mar 2022 17:22:48 +0200 (EET) Received: from mail-pf1-f172.google.com (mail-pf1-f172.google.com [209.85.210.172]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id 6E51068B0B9 for ; Thu, 10 Mar 2022 17:22:41 +0200 (EET) Received: by mail-pf1-f172.google.com with SMTP id s42so5430757pfg.0 for ; Thu, 10 Mar 2022 07:22:41 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gramner.com; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to; bh=hy4k+eCozaRQzjHGZ/PBtnFYGBMQdeRKaUipXJj1kfM=; b=YONaSOf3Amq32htiKvI6zlCtl0Q42NZ24vVEjyDOUJ3LdrDh9Haixu4jSt8I/ETGsE tXZKDmNBsV5RBeDOCb7zOBccBCrvAcBiLn0ylQcxr5JNacmg7NxbxjIaIMcMeRBB6Nq5 q+OOnNMQvPSb5AVcEQ/JgOyzZvXxoIqk6M6Ro= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to; bh=hy4k+eCozaRQzjHGZ/PBtnFYGBMQdeRKaUipXJj1kfM=; b=mXJf3n3t87GXNi9E5EX5hrJzTiDmw2mwFJ4EfPzOQUzAO+Ks31vTc9W5W1xap87hgz ZTMYICuhrQOFHH4MsdkCvEvhYJUcJmL/QlGOl9nrJHBWUspztxEL1KJNL3jlmqelBGuE hY4YUqLdCbdyyjRLEQoR6Rb9TMj58P8aoBqyLPEh8vCR9u7MLH4iIS7RNZEVrusBXtnl E/XnFe/Waiq2PIabWxFoiq3K4VUxyQPCnAHJcm7tSFjPpKYgl6fQS6QcEbTq6hVksM+q rnpM78pkI8Vdf59X6eMqNNeOHTOiza7XM1qNhbF0xWGYhyCRQCuC5ccKhQtd/XwdKBYs DpZg== X-Gm-Message-State: AOAM532LrxJkPO6iUgLebVQJ4JPL/BU+S6oAz+ZS2EHxmgK+KcfGgZYd 5tVveM5jZ0KVD3EsGgLdfGmcyYHUEL5Ti3LWXYGN7hioM/686aNp X-Google-Smtp-Source: ABdhPJzkBKgHi4GxzmNZENK0afQiycVj23sIYACLNvWx+CXMC3dlS6mninkFCWaBlELFPxYR21VLcWgxslhi6znGl9s= X-Received: by 2002:a05:6a00:1991:b0:4f7:1322:ca04 with SMTP id d17-20020a056a00199100b004f71322ca04mr5434922pfl.85.1646925759328; Thu, 10 Mar 2022 07:22:39 -0800 (PST) MIME-Version: 1.0 References: <20220223085735.70854-1-jianhua.wu@intel.com> <20220223085735.70854-2-jianhua.wu@intel.com> In-Reply-To: <20220223085735.70854-2-jianhua.wu@intel.com> From: Henrik Gramner Date: Thu, 10 Mar 2022 16:22:29 +0100 Message-ID: To: FFmpeg development discussions and patches Subject: Re: [FFmpeg-devel] [PATCH 2/6] avcodec/x86/hevc_mc: add qpel_h8_8_avx512icl and qpel_hv8_8_avx512icl X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: On Wed, Feb 23, 2022 at 9:58 AM wrote: > +%macro HEVC_PUT_HEVC_QPEL_AVX512ICL 2 > [...] > + vpmovdw xm6, m6 > + movu [dstq], xm6 vpmovdw can take a memory operand as dst directly: vpmovdw [dstq], m6 (the same applies to the hv function) > +%macro HEVC_PUT_HEVC_QPEL_HV_AVX512ICL 2 > +cglobal hevc_put_hevc_qpel_hv%1_%2, 6, 7, 8, dst, src, srcstride, height, mx, my, tmp This functions uses 27(?) vector registers but only specifies 8, so it will break on Windows unless corrected. > + if (EXTERNAL_AVX512ICL(cpu_flags)) { > + c->put_hevc_qpel[3][0][1] = ff_hevc_put_hevc_qpel_h8_8_avx512icl; > + c->put_hevc_qpel[3][1][1] = ff_hevc_put_hevc_qpel_hv8_8_avx512icl; > + } Needs an ARCH_X86_64 guard as the code is 64-bit only. _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".