From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTP id EBD7748C05 for ; Fri, 12 Jan 2024 11:58:26 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id 9CBC268C84A; Fri, 12 Jan 2024 13:58:23 +0200 (EET) Received: from mail-pg1-f181.google.com (mail-pg1-f181.google.com [209.85.215.181]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id 1EECF688158 for ; Fri, 12 Jan 2024 13:58:16 +0200 (EET) Received: by mail-pg1-f181.google.com with SMTP id 41be03b00d2f7-5ce07cf1e5dso3590433a12.2 for ; Fri, 12 Jan 2024 03:58:16 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1705060695; x=1705665495; darn=ffmpeg.org; h=to:subject:message-id:date:from:mime-version:from:to:cc:subject :date:message-id:reply-to; bh=GYYWMJwZ7ahsto9i2MXmb73AWZU0M9tRO0Ma/29A6p8=; b=dB63hBMcj1aV91wJ2bMKH1jj/9IcPqSN1FuYd6Xiam3nkTDE3mJXPs7GhFAfwTyVMy 53Cv4FBUb3/aUMsfaz/jpFF15npMSbAlRQkmGu+NCf+jH5GchQC/SVOjYoDxhJfsb682 oFbeTAAPa5+mTD22cpIcZSabkck5BvAycVwe1kK71HvOAfo6lLwcguzMtNIhgvBludi3 7hvBPzwc0daT83IAnyLpbtK3tcksqLY8+fpJMpwBsiTcqlF8waHuHRmiK46knbrQhApw 5PtmPvRefXUk8BEOPIgQ3UOv36ZZcxzzDuc5QkCTx7Or/CUkas8nExeL7ehfox7pHRxM i6uA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1705060695; x=1705665495; h=to:subject:message-id:date:from:mime-version:x-gm-message-state :from:to:cc:subject:date:message-id:reply-to; bh=GYYWMJwZ7ahsto9i2MXmb73AWZU0M9tRO0Ma/29A6p8=; b=VbR8CJM3W7OIJJF+DYR8WFWJqXWtcyHOUGRa2+9PVluzt7Bye7BZUnfOLWAJQy4jqq ycCVReb6hWEfLr9mj6y/toDazNlbRnIS2HAlI35mXoLFm4n+mLxXbz1ZSZumnLb3VjuC kxJxcz4/Rq3dzwkiCgkO3VeLOymF8MiEswbgIT/HIDvgsHyE6AfxdoL4DT2mUhmbkyDv vgX2bEnxFAmFQ7Uq5vCOQjpqG/n2VLmm62+k9eLu//5RGMjsNm24GSIsccBrffTCqD50 30BGxeMQX+nCQxC8vtSBEYZ7YoXhXvfu7nLiEFsCh+/VyPrQGsLUSCZMqsPSqNvCxaVb k5Ag== X-Gm-Message-State: AOJu0YxupurXddsLImGQq9gL3IzzLIqL9lSGnHjpKUMoKpk025+jzptD +bG0EYbSn9RK7pzRdRbxKjJnaA2Z9Ybbh2SS10QXAixWBJA= X-Google-Smtp-Source: AGHT+IEvT5gnGtyn5/pH/rjU3DTwFS8bNgULnQoMh4Nrhn49GUTESWYpRNqzPIZR5F13603zSCI0nSKnuFjXfARDhKE= X-Received: by 2002:a05:6a20:840d:b0:19a:2fe2:e5ec with SMTP id c13-20020a056a20840d00b0019a2fe2e5ecmr694952pzd.77.1705060694843; Fri, 12 Jan 2024 03:58:14 -0800 (PST) MIME-Version: 1.0 From: Vladimir Petrov Date: Fri, 12 Jan 2024 13:58:03 +0200 Message-ID: To: ffmpeg-devel@ffmpeg.org Content-Type: multipart/mixed; boundary="00000000000009ee48060ebe61d0" Subject: [FFmpeg-devel] [PATCH] avfilter/vsrc_testsrc: fix colorchart black stripe X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: --00000000000009ee48060ebe61d0 Content-Type: text/plain; charset="UTF-8" There is a typo at 'libavfilter/vsrc_testsrc.c' in 'colorchart_fill_picture()' regarding patch height when using colorchart test image source. With current default size 64x64 all is fine, but when move to any non-square patch size, there is unexpected behavior: Test examples: [Blackstripe on bottom if height > width] ffmpeg -f lavfi -i colorchart=duration=30:rate=25:patch_size=120x144 -f mp4 -c:v libx264 colorchart1.m4v [Segmentation fault if height < width] ffmpeg -f lavfi -i colorchart=duration=30:rate=25:patch_size=120x100 -f mp4 -c:v libx264 colorchart2.m4v --00000000000009ee48060ebe61d0 Content-Type: text/x-patch; charset="US-ASCII"; name="0001-avfilter-vsrc_testsrc-fix-colorchart-black-stripe.patch" Content-Disposition: attachment; filename="0001-avfilter-vsrc_testsrc-fix-colorchart-black-stripe.patch" Content-Transfer-Encoding: base64 Content-ID: X-Attachment-Id: f_lrakwbcg0 RnJvbSBjNDg0YTQ5NzZjNTQwODM3NzBjODc0OWY5NTQzOTRjMzVkZmQ5YzYzIE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBWbGFkaW1pciBQZXRyb3YgPHZwcGV0cm92bW1zQGdtYWlsLmNv bT4KRGF0ZTogVHVlLCA5IEphbiAyMDI0IDE4OjQyOjE5ICswMjAwClN1YmplY3Q6IFtQQVRDSF0g YXZmaWx0ZXIvdnNyY190ZXN0c3JjOiBmaXggY29sb3JjaGFydCBibGFjayBzdHJpcGUKCkZpeGVk IGJsYWNrc3RyaXBlIG9uIGJvdHRvbSBvciBzZWdtZW50YXRpb24gZmF1bHQgaW4gY2FzZQp3aGVu IHBhdGNoIHdpZHRoIGFuZCBoZWlnaHQgZGlmZmVyLgoKU2lnbmVkLW9mZi1ieTogVmxhZGltaXIg UGV0cm92IDx2cHBldHJvdm1tc0BnbWFpbC5jb20+Ci0tLQogbGliYXZmaWx0ZXIvdnNyY190ZXN0 c3JjLmMgfCAyICstCiAxIGZpbGUgY2hhbmdlZCwgMSBpbnNlcnRpb24oKyksIDEgZGVsZXRpb24o LSkKCmRpZmYgLS1naXQgYS9saWJhdmZpbHRlci92c3JjX3Rlc3RzcmMuYyBiL2xpYmF2ZmlsdGVy L3ZzcmNfdGVzdHNyYy5jCmluZGV4IGRhMTdlOTUwZDguLjNiNTUzNmJhZGMgMTAwNjQ0Ci0tLSBh L2xpYmF2ZmlsdGVyL3ZzcmNfdGVzdHNyYy5jCisrKyBiL2xpYmF2ZmlsdGVyL3ZzcmNfdGVzdHNy Yy5jCkBAIC0xOTc3LDcgKzE5NzcsNyBAQCBzdGF0aWMgdm9pZCBjb2xvcmNoYXJ0X2ZpbGxfcGlj dHVyZShBVkZpbHRlckNvbnRleHQgKmN0eCwgQVZGcmFtZSAqZnJhbWUpCiAgICAgY29uc3QgaW50 IHcgPSBjb2xvcmNoYXJ0X3ByZXNldHNbcHJlc2V0XS53OwogICAgIGNvbnN0IGludCBoID0gY29s b3JjaGFydF9wcmVzZXRzW3ByZXNldF0uaDsKICAgICBjb25zdCBpbnQgcHcgPSB0ZXN0LT5wdzsK LSAgICBjb25zdCBpbnQgcGggPSB0ZXN0LT5wdzsKKyAgICBjb25zdCBpbnQgcGggPSB0ZXN0LT5w aDsKIAogICAgIGZvciAoaW50IHkgPSAwOyB5IDwgaDsgeSsrKSB7CiAgICAgICAgIGZvciAoaW50 IHggPSAwOyB4IDwgdzsgeCsrKSB7Ci0tIAoyLjQzLjAKCg== --00000000000009ee48060ebe61d0 Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe". --00000000000009ee48060ebe61d0--