From: Caleb Etemesi <etemesicaleb@gmail.com>
To: FFmpeg development discussions and patches <ffmpeg-devel@ffmpeg.org>
Subject: Re: [FFmpeg-devel] Making progress re: jpeg2000dec patchsets
Date: Tue, 21 Mar 2023 17:37:12 +0300
Message-ID: <CAF7=sGJVUHK-h1iye3bqW37jCDj9Ww3J==ctXDjhu8UWCDGikA@mail.gmail.com> (raw)
In-Reply-To: <CAF7=sGJrK20J6h7g2UCTEUPAU683OECMMPP5su1EhTuX+TN7dA@mail.gmail.com>
While supporting it is feasible, it requires significant changes which
would probably interfere with this patch, hence the suggestion
Kind regards,
Caleb
On Tue, Mar 21, 2023 at 5:33 PM Caleb Etemesi <etemesicaleb@gmail.com>
wrote:
> I haven't seen an open source implementation that implements place holder
> passes, the best one is currently openhtj2k(
> https://github.com/osamu620/OpenHTJ2K) which only acknowledges their
> existence but doesn't do anything with them
>
> I would suggest we move forward if that's the only thing blocking this.
>
> On Mon, Mar 6, 2023 at 3:45 PM Tomas Härdin <git@haerdin.se> wrote:
>
>>
>> Sorry for replying a bit late to this. Anyway:
>>
>> > Hi Caleb, Tomas et al.,
>> >
>> > I have been experimenting with combining the HTJ2K patchset [1] and
>> > the J2K test patchset [2]:
>> >
>> > (a) neither valgrind nor the fuzzer seem to complain
>>
>> Excellent.
>>
>> > (b) there are code style/cosmetic issues
>> > (c) the HTJ2K block decoder does not yet support placeholder passes
>> > [3], which are not necessarily present
>>
>> Can we error out in that case and ask for patches?
>>
>> > I do not think that (c) is a blocker and recommend that we plan on
>> > merging the combined patchset once the code style/cosmetic issues are
>> > fixed. The idea is to have a baseline from which performance and
>> > feature set can be improved.
>>
>> Sounds good.
>>
>> /Tomas
>>
>> _______________________________________________
>> ffmpeg-devel mailing list
>> ffmpeg-devel@ffmpeg.org
>> https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
>>
>> To unsubscribe, visit link above, or email
>> ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".
>>
>
_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".
prev parent reply other threads:[~2023-03-21 14:37 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-02-26 21:36 Pierre-Anthony Lemieux
2023-03-06 12:45 ` Tomas Härdin
2023-03-21 14:33 ` Caleb Etemesi
2023-03-21 14:37 ` Caleb Etemesi [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAF7=sGJVUHK-h1iye3bqW37jCDj9Ww3J==ctXDjhu8UWCDGikA@mail.gmail.com' \
--to=etemesicaleb@gmail.com \
--cc=ffmpeg-devel@ffmpeg.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Git Inbox Mirror of the ffmpeg-devel mailing list - see https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
This inbox may be cloned and mirrored by anyone:
git clone --mirror https://master.gitmailbox.com/ffmpegdev/0 ffmpegdev/git/0.git
# If you have public-inbox 1.1+ installed, you may
# initialize and index your mirror using the following commands:
public-inbox-init -V2 ffmpegdev ffmpegdev/ https://master.gitmailbox.com/ffmpegdev \
ffmpegdev@gitmailbox.com
public-inbox-index ffmpegdev
Example config snippet for mirrors.
AGPL code for this site: git clone https://public-inbox.org/public-inbox.git