Git Inbox Mirror of the ffmpeg-devel mailing list - see https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
 help / color / mirror / Atom feed
From: "Rubén Gonzalez" <rgonzalez@fluendo.com>
To: ffmpeg-devel@ffmpeg.org
Subject: Re: [FFmpeg-devel] [PATCH] avformat: allow .ec3 as extension for raw E-AC-3 stream
Date: Wed, 3 Aug 2022 19:28:05 +0200
Message-ID: <CAEzxqx497TN1Pi0KPhKeHiog8=B7XS4h_G=kKWoiEoZuvyMpcQ@mail.gmail.com> (raw)
In-Reply-To: <20220623121436.58517-1-rgonzalez@fluendo.com>

Hello community,

please, Let me know if something is pending to start the review process.


On Thu, Jun 23, 2022 at 2:14 PM Ruben Gonzalez <rgonzalez@fluendo.com>
wrote:

> In addition to .eac3, .ec3 is also commonly used by people to name raw
> E-AC-3 streams. Enables automatic recognition of the eac3 format for
> the .ac3 extension.
>
> For instance Dolby Digital Plus software only support files with
> .ec3. Files with .eac3 are not supported. Check issue #18 in the
> public dlb_mp4base repository from DolbyLaboratories.
>
> Signed-off-by: Ruben Gonzalez <rgonzalez@fluendo.com>
> ---
>  libavformat/ac3dec.c | 2 +-
>  libavformat/rawenc.c | 2 +-
>  2 files changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/libavformat/ac3dec.c b/libavformat/ac3dec.c
> index 51461befd8..989d126a81 100644
> --- a/libavformat/ac3dec.c
> +++ b/libavformat/ac3dec.c
> @@ -131,7 +131,7 @@ const AVInputFormat ff_eac3_demuxer = {
>      .read_header    = ff_raw_audio_read_header,
>      .read_packet    = ff_raw_read_partial_packet,
>      .flags          = AVFMT_GENERIC_INDEX,
> -    .extensions     = "eac3",
> +    .extensions     = "eac3,ec3",
>      .raw_codec_id   = AV_CODEC_ID_EAC3,
>      .priv_data_size = sizeof(FFRawDemuxerContext),
>      .priv_class     = &ff_raw_demuxer_class,
> diff --git a/libavformat/rawenc.c b/libavformat/rawenc.c
> index 26099cb1c1..267fce252d 100644
> --- a/libavformat/rawenc.c
> +++ b/libavformat/rawenc.c
> @@ -252,7 +252,7 @@ const AVOutputFormat ff_eac3_muxer = {
>      .name              = "eac3",
>      .long_name         = NULL_IF_CONFIG_SMALL("raw E-AC-3"),
>      .mime_type         = "audio/x-eac3",
> -    .extensions        = "eac3",
> +    .extensions        = "eac3,ec3",
>      .audio_codec       = AV_CODEC_ID_EAC3,
>      .video_codec       = AV_CODEC_ID_NONE,
>      .init              = force_one_stream,
> --
> 2.25.1
>
>
_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel

To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".

  reply	other threads:[~2022-08-03 17:28 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-06-23 12:14 Ruben Gonzalez
2022-08-03 17:28 ` Rubén Gonzalez [this message]
2022-08-04 10:42 ` Anton Khirnov
2022-08-05  8:48   ` Rubén Gonzalez

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='CAEzxqx497TN1Pi0KPhKeHiog8=B7XS4h_G=kKWoiEoZuvyMpcQ@mail.gmail.com' \
    --to=rgonzalez@fluendo.com \
    --cc=ffmpeg-devel@ffmpeg.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

Git Inbox Mirror of the ffmpeg-devel mailing list - see https://ffmpeg.org/mailman/listinfo/ffmpeg-devel

This inbox may be cloned and mirrored by anyone:

	git clone --mirror https://master.gitmailbox.com/ffmpegdev/0 ffmpegdev/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 ffmpegdev ffmpegdev/ https://master.gitmailbox.com/ffmpegdev \
		ffmpegdev@gitmailbox.com
	public-inbox-index ffmpegdev

Example config snippet for mirrors.


AGPL code for this site: git clone https://public-inbox.org/public-inbox.git