Re: [FFmpeg-devel] [PATCH v5 0/7] avformat/movenc: normalize on AC-3 parser usage

["Jan Ekström" <jeebjp@gmail.com>]

On Thu, Jun 30, 2022 at 9:42 AM Jan Ekström <jeebjp@gmail.com> wrote:
>
> The simplified parsing currently in `mov_write_ac3_tag` trusts the content
> of the packets a bit too much (the AC-3 parser returns all data fed to it,
> including any possible data before the start code), while the existing E-AC-3
> logic does proper header validation by utilizing the (E-)AC-3 parser.
>
> Thus, normalize on AC-3 parser usage for both AC-3 and E-AC-3.
>
> Difference to v4:
> * Reverted to v1 base (extending the avpriv) as it was preferred in review.
> * Reutilized the ac3_bit_rate_code variable in the parser instead of doing
>   `frame_size_code>>1` again.
> * Added avcodec minor bump as it seems like we're heading towards the end here.
>
> Jan

Applied series to master, with the following minor adjustment:

-    } else if (par->codec_id == AV_CODEC_ID_EAC3 ||
-               par->codec_id == AV_CODEC_ID_AC3) {
+    } else if (par->codec_id == AV_CODEC_ID_AC3 ||
+               par->codec_id == AV_CODEC_ID_EAC3) {

Thanks for the reviews.

Jan
_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel

To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".