[FFmpeg-devel] [PATCH] avcodec/ttmlenc: Deduplicate ttml_default_namespacing string

[FFmpeg-devel] [PATCH] avcodec/ttmlenc: Deduplicate ttml_default_namespacing string

[Andreas Rheinhardt]

String literals are allowed to be deduplicated (and toolchains
are already capable of doing so), yet the same is not allowed
for named arrays (even when they contain strings). Therefore
use a const char *const pointing to an unnamed string literal
for ttml_default_namespacing.

Signed-off-by: Andreas Rheinhardt <andreas.rheinhardt@outlook.com>
---
 libavcodec/ttmlenc.h | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/libavcodec/ttmlenc.h b/libavcodec/ttmlenc.h
index 467f35c7a6..654ca0ee4d 100644
--- a/libavcodec/ttmlenc.h
+++ b/libavcodec/ttmlenc.h
@@ -25,7 +25,7 @@
 #define TTMLENC_EXTRADATA_SIGNATURE "lavc-ttmlenc"
 #define TTMLENC_EXTRADATA_SIGNATURE_SIZE (sizeof(TTMLENC_EXTRADATA_SIGNATURE) - 1)
 
-static const char ttml_default_namespacing[] =
+static const char *const ttml_default_namespacing =
 "  xmlns=\"http://www.w3.org/ns/ttml\"\n"
 "  xmlns:ttm=\"http://www.w3.org/ns/ttml#metadata\"\n"
 "  xmlns:tts=\"http://www.w3.org/ns/ttml#styling\"\n"
-- 
2.34.1

_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel

To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".

Re: [FFmpeg-devel] [PATCH] avcodec/ttmlenc: Deduplicate ttml_default_namespacing string

[Jan Ekström]

On Fri, Jul 29, 2022 at 11:23 AM Andreas Rheinhardt
<andreas.rheinhardt@outlook.com> wrote:
>
> String literals are allowed to be deduplicated (and toolchains
> are already capable of doing so), yet the same is not allowed
> for named arrays (even when they contain strings). Therefore
> use a const char *const pointing to an unnamed string literal
> for ttml_default_namespacing.
>

Reminded myself how this variable was being utilized, LGTM.

Jan
_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel

To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".