From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTP id 94125407CF for ; Thu, 30 Jun 2022 20:18:57 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id 7286868B655; Thu, 30 Jun 2022 23:18:54 +0300 (EEST) Received: from mail-wr1-f49.google.com (mail-wr1-f49.google.com [209.85.221.49]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id B172068B501 for ; Thu, 30 Jun 2022 23:18:47 +0300 (EEST) Received: by mail-wr1-f49.google.com with SMTP id cl1so204600wrb.4 for ; Thu, 30 Jun 2022 13:18:47 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=mime-version:references:in-reply-to:from:date:message-id:subject:to; bh=0NY6Ne2goUOoA15wTjt6nKvXQJmr7GDwZvQwhDILijQ=; b=YvPzYt8ROTLF22BQRkMWxm+SMU+N+NUDGoQ/hXsLg/jG0r9i8S16SIRqpXT8Wbvki3 a/z2ro4Jp4cZ2M8BYd0U+VDW12L/lJvjmZuV/TTytM7pXhuS/5rcQY70deIVkgJ3+qIn lA/qNrfAx6B3TRBVfIigWlxl0rcTjPcmxKrHogI3wjOGt2QUCK0XpPhclvxPjDqQijsA cdDYtAhQ3vqpXiYML54NCuNJXx6vf37aEGFs58UZ07VtMbPil+vJhg3TfWu9UTEAoi6N RnujTPFxgTdiQKHpxXZuZDUJGPOOZ/sEthDBiiE3Ypg548xS/GUNcZpMyy7vEmJKCyzO khZA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to; bh=0NY6Ne2goUOoA15wTjt6nKvXQJmr7GDwZvQwhDILijQ=; b=BXbSCMthiJ+viL9q/6jETp7jLVAwJrHrtFNcdsRMiC4jidGOCfMCMHt1ZnT1FITFRF wYNPw9Y3mbgN3+hVyCdxM/rgHt8lh2TyAgfqulvv48ILHJhzh/VmSd9vxez40ZoLKa+e FD67dh3wxmNQ5bIP57Ihgt+pJwOxIHXCilF/AkzZE1GTqvWYOhXsIrHbrT5pRMXzGi8V SlkU0h1b/d9tO3GZ7vvV4+LDMzQWk5rgO8yAeeOGfjooEP8N+PwpQOPR/c4+Qk9D27mN dBv+8tWPz59KIR0gHPl4WXLRv1PZEwwGu5ZhWEcgEdEXr/t98jRdLr5FaL6cnWLXSmuG WcMQ== X-Gm-Message-State: AJIora88N4B47ho38oc0cN4u/2f3YX6RfMYL2P7rftS5kwUn5HrNIHpH srO8YcUW9OZLzRsc4f9/BC/TuhEGKmVQBXEagDWzLNXu X-Google-Smtp-Source: AGRyM1tc1UT63pj+nKHhGuNOWPIy6WrhMmIMTtojl/AnTl3dAR4Tgs6UK2t+GfGpXFbx/vwHJ+pQzvObmYfBlVM51ZI= X-Received: by 2002:a5d:5847:0:b0:21b:e465:1e5e with SMTP id i7-20020a5d5847000000b0021be4651e5emr10034425wrf.584.1656620327082; Thu, 30 Jun 2022 13:18:47 -0700 (PDT) MIME-Version: 1.0 References: In-Reply-To: From: =?UTF-8?B?SmFuIEVrc3Ryw7Zt?= Date: Thu, 30 Jun 2022 23:18:34 +0300 Message-ID: To: FFmpeg development discussions and patches Subject: Re: [FFmpeg-devel] [PATCH] avformat/movenc: Fix invalid check X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: On Thu, Jun 30, 2022 at 11:15 PM Andreas Rheinhardt wrote: > > Regression since c9de096851803d45444ae9dfe3a390a2d53ac71b. > Fixes Coverity ID 1506839. > > Signed-off-by: Andreas Rheinhardt > --- > libavformat/movenc.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/libavformat/movenc.c b/libavformat/movenc.c > index 0ef6b3c76e..a4dace7c1d 100644 > --- a/libavformat/movenc.c > +++ b/libavformat/movenc.c > @@ -424,7 +424,7 @@ static int handle_eac3(MOVMuxContext *mov, AVPacket *pkt, MOVTrack *track) > if (!info->pkt && !(info->pkt = av_packet_alloc())) > return AVERROR(ENOMEM); > > - if ((ret = avpriv_ac3_parse_header(&hdr, pkt->data, pkt->size) < 0)) { > + if ((ret = avpriv_ac3_parse_header(&hdr, pkt->data, pkt->size)) < 0) { Geez. Sorry for missing this and thanks for noticing it. LGTM. Jan _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".