From: "Jan Ekström" <jeebjp@gmail.com>
To: FFmpeg development discussions and patches <ffmpeg-devel@ffmpeg.org>
Subject: Re: [FFmpeg-devel] [PATCH] avformat/movenc: Fix invalid check
Date: Thu, 30 Jun 2022 23:18:34 +0300
Message-ID: <CAEu79SbaknbRT81eBC3j2Zxi9g95kPoxCF9+Dp4fH5ZNsv_HCQ@mail.gmail.com> (raw)
In-Reply-To: <DB6PR0101MB221424757E5449EE15EBC17F8FBA9@DB6PR0101MB2214.eurprd01.prod.exchangelabs.com>
On Thu, Jun 30, 2022 at 11:15 PM Andreas Rheinhardt
<andreas.rheinhardt@outlook.com> wrote:
>
> Regression since c9de096851803d45444ae9dfe3a390a2d53ac71b.
> Fixes Coverity ID 1506839.
>
> Signed-off-by: Andreas Rheinhardt <andreas.rheinhardt@outlook.com>
> ---
> libavformat/movenc.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/libavformat/movenc.c b/libavformat/movenc.c
> index 0ef6b3c76e..a4dace7c1d 100644
> --- a/libavformat/movenc.c
> +++ b/libavformat/movenc.c
> @@ -424,7 +424,7 @@ static int handle_eac3(MOVMuxContext *mov, AVPacket *pkt, MOVTrack *track)
> if (!info->pkt && !(info->pkt = av_packet_alloc()))
> return AVERROR(ENOMEM);
>
> - if ((ret = avpriv_ac3_parse_header(&hdr, pkt->data, pkt->size) < 0)) {
> + if ((ret = avpriv_ac3_parse_header(&hdr, pkt->data, pkt->size)) < 0) {
Geez. Sorry for missing this and thanks for noticing it.
LGTM.
Jan
_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".
prev parent reply other threads:[~2022-06-30 20:18 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-06-30 20:14 Andreas Rheinhardt
2022-06-30 20:18 ` Jan Ekström [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAEu79SbaknbRT81eBC3j2Zxi9g95kPoxCF9+Dp4fH5ZNsv_HCQ@mail.gmail.com \
--to=jeebjp@gmail.com \
--cc=ffmpeg-devel@ffmpeg.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Git Inbox Mirror of the ffmpeg-devel mailing list - see https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
This inbox may be cloned and mirrored by anyone:
git clone --mirror https://master.gitmailbox.com/ffmpegdev/0 ffmpegdev/git/0.git
# If you have public-inbox 1.1+ installed, you may
# initialize and index your mirror using the following commands:
public-inbox-init -V2 ffmpegdev ffmpegdev/ https://master.gitmailbox.com/ffmpegdev \
ffmpegdev@gitmailbox.com
public-inbox-index ffmpegdev
Example config snippet for mirrors.
AGPL code for this site: git clone https://public-inbox.org/public-inbox.git