Re: [FFmpeg-devel] [PATCH] avcodec/av1dec: fix matrix coefficients exposed by codec context

From: "Jan Ekström" <jeebjp@gmail.com>
To: FFmpeg development discussions and patches <ffmpeg-devel@ffmpeg.org>
Subject: Re: [FFmpeg-devel] [PATCH] avcodec/av1dec: fix matrix coefficients exposed by codec context
Date: Tue, 20 Feb 2024 20:58:52 +0200
Message-ID: <CAEu79SbG3hpLUdqgf_ysN38GkAN6C1Jp9r=L1_rbZ2=D0xgytA@mail.gmail.com> (raw)
In-Reply-To: <013cb056-189c-48bb-961e-1e28cc4a5d0b@gmail.com>

On Tue, Feb 20, 2024 at 8:30 PM James Almer <jamrial@gmail.com> wrote:
>
> On 2/20/2024 3:28 PM, Jan Ekström wrote:
> > `colorspace` in avcodec terms means `matrix coefficients`.
> > ---
> >   libavcodec/av1dec.c | 2 +-
> >   1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/libavcodec/av1dec.c b/libavcodec/av1dec.c
> > index 7ffa7821e9..7debc4deda 100644
> > --- a/libavcodec/av1dec.c
> > +++ b/libavcodec/av1dec.c
> > @@ -743,7 +743,7 @@ static int set_context_with_sequence(AVCodecContext *avctx,
> >       avctx->color_range =
> >           seq->color_config.color_range ? AVCOL_RANGE_JPEG : AVCOL_RANGE_MPEG;
> >       avctx->color_primaries = seq->color_config.color_primaries;
> > -    avctx->colorspace = seq->color_config.color_primaries;
> > +    avctx->colorspace = seq->color_config.matrix_coefficients;
> >       avctx->color_trc = seq->color_config.transfer_characteristics;
> >
> >       switch (seq->color_config.chroma_sample_position) {
>
> LGTM

Thanks, applied as 37936b09ce316c32c456539afeb748d472088135 on master.

Will attempt to cherry-pick this as far as possible.

Jan
_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel

To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".