Re: [FFmpeg-devel] [PATCH 2/2] avformat/hls: .ts is always ok even if its a mov/mp4

["Jan Ekström" <jeebjp@gmail.com>]

On Tue, Jan 28, 2025 at 4:24 PM Michael Niedermayer
<michael@niedermayer.cc> wrote:
>
> Maybe fixes: 11435
>

Do I understand correctly that the root issue that's being attempted
to be fixed by the initial patch set is that unusual demuxers were
possible to have been probed and opened through the HLS meta demuxer?
In that case I would say that instead of trying to make very nebulous
and easily breakable extension based checking, maybe this demuxer
should just limit its default usable input formats?

To my knowledge the officially utilized container formats for HLS are
MPEG-TS, MP4-likes (fragmented mp4) and raw audio formats such as AAC,
MP3 or AC-3. One could check what hls.js or ExoPlayer support, and
that should be a generally mostly encompassing thing that does not
depend on what extensions are in use. Adding an AVOption to add
additional formats without code changes would then allow for some
outliers to be added by users.

Finally, the `-f` format definition option and whatever logic
underneath it is just splitting the name on comma and then matching.
There probably is a helper function for this in the code base. This
enables just matching against "mp4" or so. While I consider it
unlikely that even more formats are going to be added to that list of
the mov/mp4/etc demuxer, hard-coding the full name sounds like a
somewhat bad idea (unless you're utilizing the exact same macro for
both the definition in mov.c as well as in here, making sure that both
get updated in sync).

Best regards,
Jan
_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel

To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".