From: "Jan Ekström" <jeebjp@gmail.com>
To: FFmpeg development discussions and patches <ffmpeg-devel@ffmpeg.org>
Subject: Re: [FFmpeg-devel] [PATCH 1/3] avfilter/vf_ssim360: Use correct type in sizeof
Date: Tue, 14 Mar 2023 00:53:51 +0200
Message-ID: <CAEu79Sb2t7dT4DviJiONSt5Ad2mgJ5r8B=2__NSW3VLwKeEZpg@mail.gmail.com> (raw)
In-Reply-To: <AS8P250MB07442C1C4C96DFD125BF43B18FB89@AS8P250MB0744.EURP250.PROD.OUTLOOK.COM>
On Sun, Mar 12, 2023 at 11:52 PM Andreas Rheinhardt
<andreas.rheinhardt@outlook.com> wrote:
>
> SSIM360Context.ssim360_hist is an array of four pointers to double;
> so sizeof(*ssim360_hist[0]) (=sizeof(double)) is the correct size
> to use to calculate the amount of memory to allocate, not
> sizeof(*ssim360_hist) (which is sizeof(double*)).
>
> Use FF_ALLOCZ_TYPED_ARRAY to avoid this issue altogether.
>
> Fixes Coverity issue #1520671.
>
This set LGTM. Nice fixes and clean-ups in both vf_ssim360 and libx264.
Jan
_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".
next prev parent reply other threads:[~2023-03-13 22:54 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-03-12 21:52 Andreas Rheinhardt
2023-03-12 21:53 ` [FFmpeg-devel] [PATCH 2/3] avfilter/vf_ssim360: Remove dead code Andreas Rheinhardt
2023-03-12 21:53 ` [FFmpeg-devel] [PATCH 3/3] avcodec/libx264: Fix leak in case of allocation failure Andreas Rheinhardt
2023-03-13 13:22 ` [FFmpeg-devel] [PATCH 4/6] avcodec/libx264: Pass x264_picture_t* directly Andreas Rheinhardt
2023-03-13 13:22 ` [FFmpeg-devel] [PATCH 5/6] avcodec/libx264: Use dedicated pointer for accesses Andreas Rheinhardt
2023-03-13 13:22 ` [FFmpeg-devel] [PATCH 6/6] avcodec/libx264: Use av_pix_fmt_count_planes() where appropriate Andreas Rheinhardt
2023-03-13 22:53 ` Jan Ekström [this message]
2023-03-14 5:43 [FFmpeg-devel] [PATCH 1/3] avfilter/vf_ssim360: Use correct type in sizeof Anton Khirnov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAEu79Sb2t7dT4DviJiONSt5Ad2mgJ5r8B=2__NSW3VLwKeEZpg@mail.gmail.com' \
--to=jeebjp@gmail.com \
--cc=ffmpeg-devel@ffmpeg.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Git Inbox Mirror of the ffmpeg-devel mailing list - see https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
This inbox may be cloned and mirrored by anyone:
git clone --mirror https://master.gitmailbox.com/ffmpegdev/0 ffmpegdev/git/0.git
# If you have public-inbox 1.1+ installed, you may
# initialize and index your mirror using the following commands:
public-inbox-init -V2 ffmpegdev ffmpegdev/ https://master.gitmailbox.com/ffmpegdev \
ffmpegdev@gitmailbox.com
public-inbox-index ffmpegdev
Example config snippet for mirrors.
AGPL code for this site: git clone https://public-inbox.org/public-inbox.git