From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTP id AE15A4500F for ; Fri, 20 Jan 2023 22:15:48 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id 8D7D968BD2C; Sat, 21 Jan 2023 00:15:44 +0200 (EET) Received: from mail-wr1-f44.google.com (mail-wr1-f44.google.com [209.85.221.44]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id CAAA768BCE6 for ; Sat, 21 Jan 2023 00:15:37 +0200 (EET) Received: by mail-wr1-f44.google.com with SMTP id t5so6036651wrq.1 for ; Fri, 20 Jan 2023 14:15:37 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=to:subject:message-id:date:from:in-reply-to:references:mime-version :from:to:cc:subject:date:message-id:reply-to; bh=XtOi9Qk2MQSm6sEtCxgMs8ouyWcjsJU+uboIPFC7vqE=; b=GhXDNYx5BX3/2ANHY6c72zxbrFTsUVO9kCoeZHyab4lhYp1N9+fxWmqoElITsEKpFS bGE7jdQ1fUgzWP+rzbCLYkcSQBT4JxQdjU80BAIg9dgTX4jQRKVWb6ZtZBHh/aJUJrEx pqxd544kR2nJKC6mZVxSDhhYvhABIDz1SzJyTyFoQuZmfMuYhrdkkT7lzF1aXNRQZqSe mqLdQFCFR6yfOCX5CRn9HV4c7IPPv5peB9qd73FNNVXG6cyQwQOGRc2LmmrnmRSjVN95 jLSsr8UqfrJk6Ta2quU6Q5gXQvAUrsuDBL1ARWn0FCjXe6HVZv5LW8l9im4w2ugyV3Kf 535Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=to:subject:message-id:date:from:in-reply-to:references:mime-version :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=XtOi9Qk2MQSm6sEtCxgMs8ouyWcjsJU+uboIPFC7vqE=; b=x7Gog35OtivvdmqV1V/2QEozvMyu3vwTX+HRYjeOZtNm/ozZ25EBQreabUZ/9VeM3q 7z/xJtoHQYAxbggW21qdFyut1jnt5nm0Vgn4y0/0rbByCqLFgYD9Mle9Fc9sV1e4aRII 9nBvs8HnkTI0XoVxHRC8joWcCmPg1NlUF6M8fmbWZBOXxM3yTftKn9dPVvgJH0WIqQy/ N5FNyDSiU34L7K1l+A3NyHat6sBA9oaNiplmhIiNRSRqJbwT7HU0ZCCLNWo0QFEOiAT/ tf2pPB7e0AmnQ5roZDUK3aCVcpnZKX0sAk6WVW2l6ZbWqOdrUr5Bi4mFN6iyCl/9EJzR 0Htw== X-Gm-Message-State: AFqh2komsqbNlobJNm//RnFziVreC8KiY+JywPwAYyPCTgsxhNakiPXG mEQ1cC7LL+186qPqOMQSEAhlc4iNSVZeoOwq2E6gleuX7cQ= X-Google-Smtp-Source: AMrXdXuL5gFxvDRlRmiPdcR1l4vU53V3lOW9jmlUm1Sgl4M9u6EIcnCfUn60RbXOeue+AnpfSlTh1yett6S9/UJlK5s= X-Received: by 2002:adf:fc4f:0:b0:2bc:aa57:7f49 with SMTP id e15-20020adffc4f000000b002bcaa577f49mr862764wrs.672.1674252937069; Fri, 20 Jan 2023 14:15:37 -0800 (PST) MIME-Version: 1.0 References: <20230118142405.23568-1-leo.izen@gmail.com> In-Reply-To: <20230118142405.23568-1-leo.izen@gmail.com> From: =?UTF-8?B?SmFuIEVrc3Ryw7Zt?= Date: Sat, 21 Jan 2023 00:15:25 +0200 Message-ID: To: FFmpeg development discussions and patches Subject: Re: [FFmpeg-devel] [PATCH] avcodec/libjxldec: fix gamma22 and gamma28 recognization X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: On Wed, Jan 18, 2023 at 4:24 PM Leo Izen wrote: > > Gamma 2.2 and Gamma 2.8 are tagged in the file as 0.45455 and 0.35714, > respectively (i.e. 1/2.2 and 1/2.8). Trying to identify them as 2.2 and > 2.8 instead of these values will cause the transfer function to not > properly be recognized. This patch fixes this. Agreed upon reading the spec, which notes that the value is saved as an unsigned 24bit integer consisting of the numerator part of a rational number, with a 10^7 denumerator and a valid range of (0, 1]. Only nit: recognization -> recognition > --- > libavcodec/libjxldec.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/libavcodec/libjxldec.c b/libavcodec/libjxldec.c > index 55c7366f61..0009af9615 100644 > --- a/libavcodec/libjxldec.c > +++ b/libavcodec/libjxldec.c > @@ -167,9 +167,9 @@ static enum AVColorTransferCharacteristic libjxl_get_trc(void *avctx, const JxlC > case JXL_TRANSFER_FUNCTION_DCI: return AVCOL_TRC_SMPTE428; > case JXL_TRANSFER_FUNCTION_HLG: return AVCOL_TRC_ARIB_STD_B67; > case JXL_TRANSFER_FUNCTION_GAMMA: > - if (jxl_color->gamma > 2.199 && jxl_color->gamma < 2.201) > + if (jxl_color->gamma > 0.45355 && jxl_color->gamma < 0.45555) > return AVCOL_TRC_GAMMA22; > - else if (jxl_color->gamma > 2.799 && jxl_color->gamma < 2.801) > + else if (jxl_color->gamma > 0.35614 && jxl_color->gamma < 0.35814) These values leave ~0.001 of leeway which seems like it was before. LGTM _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".