From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTP id 4494A455A8 for ; Sat, 4 Feb 2023 17:59:03 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id A7F4A68BE90; Sat, 4 Feb 2023 19:59:00 +0200 (EET) Received: from mail-ej1-f47.google.com (mail-ej1-f47.google.com [209.85.218.47]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id 0AE8B68BE2F for ; Sat, 4 Feb 2023 19:58:55 +0200 (EET) Received: by mail-ej1-f47.google.com with SMTP id hx15so23524034ejc.11 for ; Sat, 04 Feb 2023 09:58:55 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=to:subject:message-id:date:from:in-reply-to:references:mime-version :from:to:cc:subject:date:message-id:reply-to; bh=vEDEqL+LtqbnIz8N5wZPb89f0wNXUvCdpAJnXbjZvIQ=; b=m4U7TXh+pY2w+n7Bk595KsQkhVwE0I9owDvfBqCfz1Cys9NWnBzbqwWS30dH1XSl0A wFjkzZb7GKfGDImwpwabztZDeLblxFiVL1tSGkjAzcWG1/CApPdsMnCVYAVrYsEKTMeF O6yM9QPOBFXkqI3qu4nJtsV4p0+mdK57DaSKKDeAaB5KajaucJVGvUXifOvfhRvf/Ymg rZe+aqacGNFGtIBtmZqE+7pXKdIDHrzSX6UQ2dGViCyMS8qqraqmb1ONGQDRrL6bhIhN qSpA7EtWLwVuo7yYKNyPtC0DQrXwDtKf26mMN0HTesiIQEfsaagAbTH9gICD2+rcMjq5 2g/Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=to:subject:message-id:date:from:in-reply-to:references:mime-version :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=vEDEqL+LtqbnIz8N5wZPb89f0wNXUvCdpAJnXbjZvIQ=; b=kpjpXr+izJtjOXUkAwhgg9cTjHLKzSrtDxmqSX7wlBHHdANeplaTP6c/GiHi7AYCwm lpBXn9ryvQvjiOKLjj6sFVQB6DyOswYA5m5o15VIYZoBHpwXd84xLksmyONFzqCxGg4N 7QstspeEPZDcrTq8yqFwi9VdgjzEp2VGL5lbA9nJUsqWG7NBM7V39RmWp/+ZmCMDr41G O8AQv3VRW2D0XfG3zSNIizpJNPgQ7HPU4l6b92+G8CecShFjrl3Y4HJx7qzIlnZ22t0/ KH4y9jy2KdvDDDJuD9Ter375DwvSY4MggjMn/Nsr51Kh4gKU4fzEhAC5IRhcjWB5p779 8Nwg== X-Gm-Message-State: AO0yUKW3OgN7sM7c32augr3Szj+pU62FrZaa0q/DtqjWocg3KxKakrwD +68dJy7Vl9WhhXA/eLmwtaeh72rqecUovwH+4jO38wjj X-Google-Smtp-Source: AK7set/+4dM4hCdy9gvkqqtNFRm39FB/S0pDyRItkZpPu5GOY9dzw60ghb3b5nqE/LgJxb7gL7vhw+pk+YVcURArEvM= X-Received: by 2002:a17:906:328d:b0:88c:a725:7ab3 with SMTP id 13-20020a170906328d00b0088ca7257ab3mr4560890ejw.23.1675533534194; Sat, 04 Feb 2023 09:58:54 -0800 (PST) MIME-Version: 1.0 References: <20230204133239.246049-1-leo.izen@gmail.com> <4f2e1bde-112a-316d-9380-bb6d03892da4@gmail.com> In-Reply-To: <4f2e1bde-112a-316d-9380-bb6d03892da4@gmail.com> From: =?UTF-8?B?SmFuIEVrc3Ryw7Zt?= Date: Sat, 4 Feb 2023 19:58:42 +0200 Message-ID: To: FFmpeg development discussions and patches Subject: Re: [FFmpeg-devel] [PATCH] configure: update libjxl pkg-config versions X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: On Sat, Feb 4, 2023 at 6:59 PM Leo Izen wrote: > > On 2/4/23 10:24, Andreas Rheinhardt wrote: > > Leo Izen: > >> Commit fb823161a8e3dfc864a7bd83a9b968f4912c5b1d added a dependency of > >> JxlBitDepth, which wasn't present in 0.7.0. This updates the library > >> versions in ./configure required to match 0.8.0, the new required > >> version. > >> --- > >> configure | 4 ++-- > >> 1 file changed, 2 insertions(+), 2 deletions(-) > >> > >> diff --git a/configure b/configure > >> index d67855c729..013bd3dcfd 100755 > >> --- a/configure > >> +++ b/configure > >> @@ -6596,8 +6596,8 @@ enabled libgsm && { for gsm_hdr in "gsm.h" "gsm/gsm.h"; do > >> check_lib libgsm "${gsm_hdr}" gsm_create -lgsm && break; > >> done || die "ERROR: libgsm not found"; } > >> enabled libilbc && require libilbc ilbc.h WebRtcIlbcfix_InitDecode -lilbc $pthreads_extralibs > >> -enabled libjxl && require_pkg_config libjxl "libjxl >= 0.7.0" jxl/decode.h JxlDecoderVersion && > >> - require_pkg_config libjxl_threads "libjxl_threads >= 0.7.0" jxl/thread_parallel_runner.h JxlThreadParallelRunner > >> +enabled libjxl && require_pkg_config libjxl "libjxl >= 0.8.0" jxl/decode.h JxlDecoderVersion && > >> + require_pkg_config libjxl_threads "libjxl_threads >= 0.8.0" jxl/thread_parallel_runner.h JxlThreadParallelRunner > >> enabled libklvanc && require libklvanc libklvanc/vanc.h klvanc_context_create -lklvanc > >> enabled libkvazaar && require_pkg_config libkvazaar "kvazaar >= 0.8.1" kvazaar.h kvz_api_get > >> enabled liblensfun && require_pkg_config liblensfun lensfun lensfun.h lf_db_new > > > > How recent is this? > > > > - Andreas > > > > Version 0.8.0 was released about two weeks ago. Is this too recent? > > - Leo Izen (thebombzen) Generally keeping backwards compatibility becomes more relevant when either: 1. the library is already stable and well-established 2. some addition can be easily #ifdef'd or so with version guards. At this point the lack of this bump is failing compilation on my Fedora 37 system as it currently still packages libjxl version 0.7.0, so as it seems like libjxl is still in the process of adding basic APIs, I'd maybe edge on the side of just bumping the requirement, even if the bit depth feature itself isn't that critical and could in theory be ifdef'd around (if libjxl even has useful defines for such checks). Jan _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".