Re: [FFmpeg-devel] [PATCH] configure: update libjxl pkg-config versions

["Jan Ekström" <jeebjp@gmail.com>]

On Sat, Feb 4, 2023 at 6:59 PM Leo Izen <leo.izen@gmail.com> wrote:
>
> On 2/4/23 10:24, Andreas Rheinhardt wrote:
> > Leo Izen:
> >> Commit fb823161a8e3dfc864a7bd83a9b968f4912c5b1d added a dependency of
> >> JxlBitDepth, which wasn't present in 0.7.0. This updates the library
> >> versions in ./configure required to match 0.8.0, the new required
> >> version.
> >> ---
> >>   configure | 4 ++--
> >>   1 file changed, 2 insertions(+), 2 deletions(-)
> >>
> >> diff --git a/configure b/configure
> >> index d67855c729..013bd3dcfd 100755
> >> --- a/configure
> >> +++ b/configure
> >> @@ -6596,8 +6596,8 @@ enabled libgsm            && { for gsm_hdr in "gsm.h" "gsm/gsm.h"; do
> >>                                      check_lib libgsm "${gsm_hdr}" gsm_create -lgsm && break;
> >>                                  done || die "ERROR: libgsm not found"; }
> >>   enabled libilbc           && require libilbc ilbc.h WebRtcIlbcfix_InitDecode -lilbc $pthreads_extralibs
> >> -enabled libjxl            && require_pkg_config libjxl "libjxl >= 0.7.0" jxl/decode.h JxlDecoderVersion &&
> >> -                             require_pkg_config libjxl_threads "libjxl_threads >= 0.7.0" jxl/thread_parallel_runner.h JxlThreadParallelRunner
> >> +enabled libjxl            && require_pkg_config libjxl "libjxl >= 0.8.0" jxl/decode.h JxlDecoderVersion &&
> >> +                             require_pkg_config libjxl_threads "libjxl_threads >= 0.8.0" jxl/thread_parallel_runner.h JxlThreadParallelRunner
> >>   enabled libklvanc         && require libklvanc libklvanc/vanc.h klvanc_context_create -lklvanc
> >>   enabled libkvazaar        && require_pkg_config libkvazaar "kvazaar >= 0.8.1" kvazaar.h kvz_api_get
> >>   enabled liblensfun        && require_pkg_config liblensfun lensfun lensfun.h lf_db_new
> >
> > How recent is this?
> >
> > - Andreas
> >
>
> Version 0.8.0 was released about two weeks ago. Is this too recent?
>
> - Leo Izen (thebombzen)

Generally keeping backwards compatibility becomes more relevant when either:

1. the library is already stable and well-established
2. some addition can be easily #ifdef'd or so with version guards.

At this point the lack of this bump is failing compilation on my
Fedora 37 system as it currently still packages libjxl version 0.7.0,
so as it seems like libjxl is still in the process of adding basic
APIs, I'd maybe edge on the side of just bumping the requirement, even
if the bit depth feature itself isn't that critical and could in
theory be ifdef'd around (if libjxl even has useful defines for such
checks).

Jan
_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel

To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".