From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTP id 717C840B3A for ; Fri, 4 Feb 2022 11:11:05 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id 11D7568B24B; Fri, 4 Feb 2022 13:11:02 +0200 (EET) Received: from mail-yb1-f172.google.com (mail-yb1-f172.google.com [209.85.219.172]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id 0AEB068B23B for ; Fri, 4 Feb 2022 13:10:56 +0200 (EET) Received: by mail-yb1-f172.google.com with SMTP id g14so17527855ybs.8 for ; Fri, 04 Feb 2022 03:10:55 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=mime-version:references:in-reply-to:from:date:message-id:subject:to; bh=ndeRvopVNEQcJ2CIYXAvsVX7RGBg7Pj1yb7Y1Bbzn/I=; b=WXEpSvMEORYdjmUfkWebnfffCrw6Ymf6PLytH0lC2dFkTJJ6mJQ3G8NOyAN5M4iVzA TS/C8ovvKiNepiCIn0qx1ald08WvPaCM39QjXFuffJOz259IFZ4FH1P+KJu8skdyUMNI apzUmbQrAqSKE7Ua69OfoKjnXpfTrp/omSqdOcbYNA6jtdiMBRfqdCmTsyHbVxdmGTnc L6IvMyqNE/8JixahsA8lvQfhCsPWaRTzYMDFw8Jq2domIFXPbd6q3aaVRQ626sSy4CLd 4nreaIM4ShtKVo8SxOwvzZqZCzw5gvVyJ4QEx4+enLipFtZv+Hg1ZDnoWe2v6ERGZwlz uG2A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to; bh=ndeRvopVNEQcJ2CIYXAvsVX7RGBg7Pj1yb7Y1Bbzn/I=; b=6cz7oLLVqcnf5BUdqQP0FGJP1GwO0l6B99L/hPmHWO3v8lzpy5OM3InCk6G+Dms8E+ opulWQgUKUgAQP3qfCj1l9KWX4vTSNa65ADhgAt/EqX8ARehcvM2GGjfCHQZYAv0trgc A9/r2ic1h43eEkYAimMA8aGLAHFUAu1P+Vfp+fJCzhQfG9cDZD2FxagLcl0vjQxBdnCr 755g3sB/ATYR/ecM4kI/84xOuaGdGeJ90mImKyS3pC7fuls0+ZX7959C3dcifc1Bo/rc 8nfnc3SAEyOOEL9Yzaoxkd9g9pqpIsAkWMRb5ImtHW/DYpaM8sfFOMvYG2Ll7RdVJNh+ 7kcw== X-Gm-Message-State: AOAM533uuxrwie9PaMMcUh//FEt39nkXJP1NsF0c6MaBwW55fbyZsMrI 4R9QubvJCf4FVlJ9Vadh6BHgU+ue2SKZ2apHmUIDDVHI X-Google-Smtp-Source: ABdhPJxEZycCrVYBN9OTMd7z90Q6dx8ODXS/IcVamweHsx9ssES+moye7AiLI0tEvmVWOSeueHWPMnWXK5p/b8ZUpDQ= X-Received: by 2002:a81:78c3:: with SMTP id t186mr2280633ywc.520.1643973054077; Fri, 04 Feb 2022 03:10:54 -0800 (PST) MIME-Version: 1.0 References: In-Reply-To: From: =?UTF-8?B?SmFuIEVrc3Ryw7Zt?= Date: Fri, 4 Feb 2022 13:10:42 +0200 Message-ID: To: FFmpeg development discussions and patches Subject: Re: [FFmpeg-devel] [PATCH 2/2] libavformat/mov: fix udta reading in trak box X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: On Fri, Feb 4, 2022 at 5:24 AM Wang Chuan wrote: > > Ping? > On Jan 28, 2022, 11:24 AM +0800, Wang Chuan , wrote: > > if we are reading udta in trak box, the data should go to metadata > > of current stream. > > > > Signed-off-by: Wang Chuan > > --- > > libavformat/mov.c | 5 ++++- > > 1 file changed, 4 insertions(+), 1 deletion(-) > > > > diff --git a/libavformat/mov.c b/libavformat/mov.c > > index 1437d160f8..cb983defb3 100644 > > --- a/libavformat/mov.c > > +++ b/libavformat/mov.c > > @@ -522,7 +522,10 @@ retry: > > str[str_size] = 0; > > } > > c->fc->event_flags |= AVFMT_EVENT_FLAG_METADATA_UPDATED; > > - av_dict_set(&c->fc->metadata, key, str, 0); > > + if (c->trak_index != -1) > > + av_dict_set(&c->fc->streams[c->trak_index]->metadata, key, > > str, 0); > > + else > > + av_dict_set(&c->fc->metadata, key, str, 0); > > if (*language && strcmp(language, "und")) { > > snprintf(key2, sizeof(key2), "%s-%s", key, language); > > av_dict_set(&c->fc->metadata, key2, str, 0); > > -- > > 2.29.2 I recall having some patches on my github regarding something related, will attempt to check this during the week-end. Jan _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".