Re: [FFmpeg-devel] [PATCH v3 1/2] avcodec/libsvtav1: update avctx bit rate according to RC mode

From: "Jan Ekström" <jeebjp@gmail.com>
To: FFmpeg development discussions and patches <ffmpeg-devel@ffmpeg.org>
Subject: Re: [FFmpeg-devel] [PATCH v3 1/2] avcodec/libsvtav1: update avctx bit rate according to RC mode
Date: Mon, 9 May 2022 23:10:19 +0300
Message-ID: <CAEu79Saa=LUs-sEx0tm6_gnJWrbVNzJ2OGjurGzz0WHAMt0gLA@mail.gmail.com> (raw)
In-Reply-To: <032a0aab-af7a-36cc-61d6-94bf43f84d92@gmail.com>

On Mon, May 9, 2022 at 10:07 PM James Almer <jamrial@gmail.com> wrote:
>
> On 5/9/2022 3:47 PM, Jan Ekström wrote:
> > This way we can filter out the default value for this member, which
> > is nonzero. Bases on the current affairs that bit rate based rate
> > control is nonzero in SVT-AV1.
> > ---
> >   libavcodec/libsvtav1.c | 3 ++-
> >   1 file changed, 2 insertions(+), 1 deletion(-)
> >
> > diff --git a/libavcodec/libsvtav1.c b/libavcodec/libsvtav1.c
> > index b4112004ad..2c4ddd4641 100644
> > --- a/libavcodec/libsvtav1.c
> > +++ b/libavcodec/libsvtav1.c
> > @@ -297,7 +297,8 @@ static int config_enc_params(EbSvtAv1EncConfiguration *param,
> >           param->profile = FF_PROFILE_AV1_HIGH;
> >       }
> >
> > -    avctx->bit_rate                 = param->target_bit_rate;
> > +    avctx->bit_rate = param->rate_control_mode > 0 ?
> > +                      param->target_bit_rate : 0;
> >
> >       return 0;
> >   }
>
> Set LGTM.

Thanks, applied set as
70887d44ffa31b95704b85531fc53ddd4d9aab14
fe100bc556d7b25d301ed65f7ae7a74880770f09

Jan
_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel

To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".