Re: [FFmpeg-devel] [PATCH v2] avcodec/libsvtav1: add support for setting chroma sample location

["Jan Ekström" <jeebjp@gmail.com>]

On Tue, Apr 26, 2022 at 2:44 AM James Almer <jamrial@gmail.com> wrote:
>
> On 4/25/2022 6:59 PM, Jan Ekström wrote:
> > Support for configuring this was added with version 1.0.0.
> > ---
> >   libavcodec/libsvtav1.c | 27 +++++++++++++++++++++++++++
> >   1 file changed, 27 insertions(+)
> >
> > diff --git a/libavcodec/libsvtav1.c b/libavcodec/libsvtav1.c
> > index 2e3d96ce37..49c396387f 100644
> > --- a/libavcodec/libsvtav1.c
> > +++ b/libavcodec/libsvtav1.c
> > @@ -205,6 +205,33 @@ static int config_enc_params(EbSvtAv1EncConfiguration *param,
> >       else
> >           param->color_range = !!(desc->flags & AV_PIX_FMT_FLAG_RGB);
> >
> > +#if SVT_AV1_CHECK_VERSION(1, 0, 0)
> > +    if (avctx->chroma_sample_location != AVCHROMA_LOC_UNSPECIFIED) {
> > +        const char *name =
> > +            av_chroma_location_name(avctx->chroma_sample_location);
> > +
> > +        switch (avctx->chroma_sample_location) {
> > +        case AVCHROMA_LOC_LEFT:
> > +            param->chroma_sample_position = EB_CSP_VERTICAL;
> > +            break;
> > +        case AVCHROMA_LOC_TOPLEFT:
> > +            param->chroma_sample_position = EB_CSP_COLOCATED;
> > +            break;
> > +        default:
> > +            if (!name)
> > +                break;
> > +
> > +            av_log(avctx, AV_LOG_WARNING,
> > +                   "Specified chroma sample location %s is unsupported "
> > +                   "on the AV1 bit stream level. Usage of a container that "
> > +                   "allows passing this information - such as Matroska - "
> > +                   "is recommended.\n",
> > +                   name);
> > +            break;
> > +        }
> > +    }
> > +#endif
> > +
> >       if (avctx->profile != FF_PROFILE_UNKNOWN)
> >           param->profile = avctx->profile;
>
> Should be ok.

Thanks, applied as ded0334d214f9617122ccf5466f99df5c908277b .

Jan
_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel

To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".