From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTP id 2B6FB40FDA for ; Mon, 14 Mar 2022 15:27:56 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id 7871C68B075; Mon, 14 Mar 2022 17:27:54 +0200 (EET) Received: from mail-lj1-f174.google.com (mail-lj1-f174.google.com [209.85.208.174]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id 33E6268A7ED for ; Mon, 14 Mar 2022 17:27:48 +0200 (EET) Received: by mail-lj1-f174.google.com with SMTP id o6so22454378ljp.3 for ; Mon, 14 Mar 2022 08:27:48 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=mime-version:references:in-reply-to:from:date:message-id:subject:to; bh=EMdMwo1d1tDBkqi4moZV1Pq715gAC3+oIdQfX/8jDkw=; b=lwPndrh1+ba0kemwjDgBSNTwJIjz5ZQNpek8Rx2ULEf1XoBbgeN/l18N3UBhNwbEWy 9qEqLNdjV8oDHLQPntwWQzHdsOqY+58UgSRuBeN10/Pn2z3rjow84C1iAyuvGMTue/+u f9Iws8wogrldghkWNoT2i/N8C2JodYZmIKdnf+W34Zgp4W0UhvTbA01HnKVe14qJ+Ht3 2tJEgbcqQAcdN3jxhMvre0+tVNxp0mdt6oTgoDqVo9hiZ1wz0VriJngBkFrULJwhUIXr qurlbWhmJenVpA/tCKz+LP4hB8BMiVJP5MWuylpmKBgtbSZ9z8Yghe3p1YnwIabbPN9x UGOg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to; bh=EMdMwo1d1tDBkqi4moZV1Pq715gAC3+oIdQfX/8jDkw=; b=Mz72w75c6s3R8gpUx0Hyi3Y/+leagUgnH36QsNCZmhQsVI5qglQOn+Fj44obaISzjo CF49X9n9r2LjnDf0Pz8HOb9b8++Y0nPAhWLQkRKDDhxoWw2sznI5hQqx2cT9Tmu3n5ZI Hxhprd5l+J4SYxYZ4AVGqcpfhJkp2M12PSDgQR/4B7EYb1AWoDJ+wWSkRHvrD9XUfiQO G8uJoncV7mQkbiRmNF5CGy6zDaIrGQU1TlDelrJQLlk7fpBhQ1b97vXvB9If5O8FZgDJ /BOYrksSimZMpo3qN8iRJ6D7oXSPoFgG7mecMKhUPsNgnswiXRtz/xe4jr+y8GgvuI7T abow== X-Gm-Message-State: AOAM532e08b5ej5QozkFw6krmH40yWMKz3gOBLMUeatTRUmkwdTKyYOF Et6jwdrWp+hcNpsWibpP/CLN/CsqoWLRy1fSWtU6nAhQFBQ= X-Google-Smtp-Source: ABdhPJzx3OxBiy8wpT7hpLUZWimW6o9vQvAUFtUmQdVpsCQMSc9hj3+GIQIE9fcH+0hgJ54HBZbH8LmSgeKeldCVulQ= X-Received: by 2002:a05:651c:1542:b0:244:e12b:8b83 with SMTP id y2-20020a05651c154200b00244e12b8b83mr14590099ljp.436.1647271667431; Mon, 14 Mar 2022 08:27:47 -0700 (PDT) MIME-Version: 1.0 References: <20220314130459.88494-1-danilchap@google.com> In-Reply-To: <20220314130459.88494-1-danilchap@google.com> From: =?UTF-8?B?SmFuIEVrc3Ryw7Zt?= Date: Mon, 14 Mar 2022 17:27:36 +0200 Message-ID: To: FFmpeg development discussions and patches Subject: Re: [FFmpeg-devel] [PATCH] Allow to modify max qp configuration parameter in libvpx without reseting the encoder X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: On Mon, Mar 14, 2022 at 3:05 PM Danil Chapovalov wrote: > > --- Probably something a la avcodec/libvpxenc: enable dynamic quantizer reconfiguration ? > libavcodec/libvpxenc.c | 7 +++++++ > 1 file changed, 7 insertions(+) > > diff --git a/libavcodec/libvpxenc.c b/libavcodec/libvpxenc.c > index 8f94ba15dc..45baeed435 100644 > --- a/libavcodec/libvpxenc.c > +++ b/libavcodec/libvpxenc.c > @@ -1658,6 +1658,13 @@ static int vpx_encode(AVCodecContext *avctx, AVPacket *pkt, > flags |= strtoul(en->value, NULL, 10); > } > > + en = av_dict_get(frame->metadata, "max-quantizer", NULL, 0); > + if (en) { > + struct vpx_codec_enc_cfg cfg = *enccfg; > + cfg.rc_max_quantizer = strtoul(en->value, NULL, 10); > + vpx_codec_enc_config_set(&ctx->encoder, &cfg); > + } > + There is side data already defined for quantizers, AVVideoEncParams / AV_FRAME_DATA_VIDEO_ENC_PARAMS . In other words, this should be handled in a similar manner to ROI, not as an ad-hoc metadata key in the AVFrame. Cheers, Jan _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".